Skip to content

chore: calc slippage percentage #5723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: calc slippage percentage #5723

wants to merge 2 commits into from

Conversation

GustavoRSSilva
Copy link
Contributor

@GustavoRSSilva GustavoRSSilva commented Apr 29, 2025 •
edited
Loading

Explanation

Calculate slippage percentage

References

Changelog

  • calcSlippagePercentage added to Bridge Controller Utils (#5723)

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@GustavoRSSilva GustavoRSSilva marked this pull request as ready for review April 29, 2025 09:02
@GustavoRSSilva GustavoRSSilva requested review from a team as code owners April 29, 2025 09:02
bfullam
bfullam previously approved these changes Apr 29, 2025
View reviewed changes
@GustavoRSSilva GustavoRSSilva requested a review from bfullam April 29, 2025 13:53
cryptodev-2s
cryptodev-2s approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cryptodev-2s
cryptodev-2s requested changes May 4, 2025
View reviewed changes
@GustavoRSSilva GustavoRSSilva force-pushed the chore/calc-slippage-percentage branch from a6e4522 to ce2b22e Compare May 7, 2025 14:43
micaelae
micaelae reviewed May 7, 2025
View reviewed changes
packages/bridge-controller/src/utils/quote.ts
.toFixed(2),
)
: null,
percentageInUsd:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't the percentages always be equal? We can just return 1 value in this case, and can we use a string and let the clients round/trim as needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can 👍 . I coped the logic to always return the same as what we had, but we can change it to just one amount.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micaelae micaelae micaelae left review comments

@ghgoodreau ghgoodreau ghgoodreau approved these changes

@bfullam bfullam Awaiting requested review from bfullam

@cryptodev-2s cryptodev-2s Awaiting requested review from cryptodev-2s

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GustavoRSSilva @bfullam @ghgoodreau @micaelae @cryptodev-2s