feat: add Monad Testnet to network-controller and controller-utils
#5724
+77
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
Keep in mind, due to Monad is using 'MON' as symbol, hence, we will not add it into controller-utils constants |
darkwing
reviewed
Apr 30, 2025
darkwing
reviewed
Apr 30, 2025
mcmire
reviewed
May 2, 2025
|
@mcmire i also agree with that, may be to align with other constants, we can use chainId as key export const BUILT_IN_CUSTOM_NETWORKS_RPC = {
[ChainId['megaeth-testnet']]: 'https://carrot.megaeth.com/rpc',
[ChainId['monad-testnet']]: 'https://testnet-rpc.monad.xyz',
};keep in mind that, we change this constants will causing a breaking change for controller-utils but i guess we are okay to move it to a breaking version, wdyt? |
|
@stanleyyconsensys Hmm... I would say despite the comments, let's do what we can to avoid a breaking change for now, since |
…core into feat/add-monad-testnet
github-project-automation
bot
moved this from Needs dev review
to Review finalised - Ready to be merged
in PR review queue
github-project-automation
bot
moved this from Review finalised - Ready to be merged
to Merged, Closed or Archived
in PR review queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR is to add Monad Testnet as default network on
network-controllerdefault state -networkConfigurationsByChainIdwith the constants and type from the latestcontroller-utilsChanges:
Refactor
network-controllermethodsgetDefaultCustomNetworkConfigurationsByChainIdto build the configuration fromCustomNetworkTypeinstead of hardcode network 1 by 1Add
Monad Testnetinfo intocontroller-utilsInclude
Monad Testnetintonetwork-controllermethodgetDefaultCustomNetworkConfigurationsByChainIdIntegration PR in mobile: MetaMask/metamask-mobile#14963
References
Changelog
Checklist