Skip to content

fix: remove metadata for unsupported keyrings #5725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
+730 −356
Open

fix: remove metadata for unsupported keyrings #5725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
d494780
fix: remove metadata for unsupported keyrings
mikesposito Apr 29, 2025
9466227
Merge branch 'main' into mikesposito/fix/unsupported-keyrings
mikesposito May 7, 2025
dedc873
update changelog
mikesposito May 7, 2025
b66337e
refactor!: remove `keyringsMetadata` from the state
mikesposito May 8, 2025
7313185
update accounts-controller
mikesposito May 8, 2025
002c421
update profile-sync-controller
mikesposito May 8, 2025
2efe4b4
update notification-services-controller
mikesposito May 8, 2025
db3accc
update tests
mikesposito May 8, 2025
6c6c36d
update preferences-controller tests
mikesposito May 8, 2025
765a3ae
fix lint
mikesposito May 8, 2025
f753328
fix: update vault on login if new metadata is generated
mikesposito May 8, 2025
0e1e571
adjust lint threshold
mikesposito May 8, 2025
3a9d671
update changelog
mikesposito May 8, 2025
8aed354
test: check if vault is updated on login
mikesposito May 8, 2025
c71d8a6
add test for `submitEncryptionKey`
mikesposito May 8, 2025
7a8953a
fix test case for vault not updated
mikesposito May 8, 2025
f43bdf5
Apply suggestions from code review
mikesposito May 8, 2025
28afa46
remove unused constant
mikesposito May 8, 2025
40930dd
Merge branch 'main' into mikesposito/fix/unsupported-keyrings
mikesposito May 8, 2025
38ac8e7
fix test typo
mikesposito May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions eslint-warning-thresholds.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,9 +437,6 @@
"packages/polling-controller/src/AbstractPollingController.ts": {
"@typescript-eslint/prefer-readonly": 1
},
"packages/preferences-controller/src/PreferencesController.test.ts": {
"prettier/prettier": 4
},
"packages/queued-request-controller/src/QueuedRequestController.ts": {
"@typescript-eslint/prefer-readonly": 2
},
Expand Down
Loading
Loading