-
-
Notifications
You must be signed in to change notification settings - Fork 231
feat: add sequential batch support #5762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0e732db
to
8b9e6f7
Compare
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
matthewwalsh0
requested changes
May 8, 2025
packages/transaction-controller/src/hooks/SequentialPublishBatchHook.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/hooks/SequentialPublishBatchHook.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/hooks/SequentialPublishBatchHook.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/hooks/SequentialPublishBatchHook.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/hooks/SequentialPublishBatchHook.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/hooks/SequentialPublishBatchHook.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/hooks/SequentialPublishBatchHook.ts
Outdated
Show resolved
Hide resolved
matthewwalsh0
requested changes
May 19, 2025
packages/transaction-controller/src/helpers/PendingTransactionTracker.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/helpers/PendingTransactionTracker.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/helpers/PendingTransactionTracker.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/hooks/SequentialPublishBatchHook.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/hooks/SequentialPublishBatchHook.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/hooks/SequentialPublishBatchHook.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/hooks/SequentialPublishBatchHook.ts
Outdated
Show resolved
Hide resolved
matthewwalsh0
approved these changes
May 20, 2025
pedronfigueiredo
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The
TransactionController
currently lacks support for sequential batch transactions, which are required for the stablecoin lending feature. Specifically, there is no mechanism to execute multiple transactions (e.g., approval + token deposit) sequentially while ensuring confirmation for each transaction. This limitation prevents efficient batch processing to support new features.What solution do these changes offer?
The
SequentialPublishBatchHook
introduces a default mechanism for handling batch transactions when no custompublishBatchHook
is provided. It ensures transactions are published sequentially, waiting for confirmation before proceeding to the next. If any transaction fails to publish or confirm, the batch process halts and throws an error.Key Features:
References
Fixes https://github.com/MetaMask/MetaMask-planning/issues/4695
Changelog
Checklist