Skip to content

feat: Incrementally load NFTs #5838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

gambinish
Copy link
Contributor

Explanation

References

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@gambinish gambinish requested a review from a team as a code owner May 21, 2025 04:03
@gambinish gambinish changed the title Chore/incrementally load nfts feat: Incrementally load NFTs May 21, 2025
* @returns Promise resolving to an object containing the NFTs found, whether there are more to load,
* and a continuation token for the next request.
*/
async detectMoreNfts(
Copy link
Contributor

@sahar-fehri sahar-fehri May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! perhaps if we go eventually with this approach, we wont need to have two public functions detectMoreNfts and detectNfts;
I imagined we could just update the detectNfts fct to not have a loop to go through all cursors, instead only fetch a page at a time when client requests it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants