fix(rpc-service): improve error handling for HTTP status codes

[cryptodev-2s]

Explanation

Improves error handling in the RPC service by making it more specific and consistent. The changes include:

• Clarifies error handling for different HTTP status codes:
  • 401: Unauthorized error
  • 402/404/5xx: Resource unavailable error
  • 429: Rate limiting error
  • Other 4xx responses now throw a generic HTTP client error
  • Invalid JSON: Parse error

Note: A previous attempt to merge this work has already been done in #5843 then reverted back in #5881

References

Fixes #5844

Changelog

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
• I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

[mcmire]

Apologies for not re-creating this. Just had a few comments.

[mcmire]

Actually, can you reach out to the Wallet API team and ask them to review this PR? I wanted to make sure that this won't cause any incompatibility issues with dapps before merging this. (I'm marking as "request changes" just as a shortcut)

[cryptodev-2s]

Actually, can you reach out to the Wallet API team and ask them to review this PR? I wanted to make sure that this won't cause any incompatibility issues with dapps before merging this. (I'm marking as "request changes" just as a shortcut)

Yes I already shared the PR with the Wallet API team in slack.

[jiexi]

wondering why 404 doesn't get a 32002 instead

[mcmire]

Isn't that what "resource unavailable" is? https://github.com/MetaMask/rpc-errors/blob/4dd3f3dcedca8bbd57474915dbd92b892c548c5e/src/error-constants.ts#L5

[jiexi]

oops i meant -32001

[mcmire]

My thought here was that according to the JSON-RPC spec -32001 is for when an RPC method is not found. In my mind this assumes that the endpoint is available and is ready to serve JSON-RPC, it's just that the server doesn't know what to do with the given JSON-RPC method. HTTP 404, on the other hand, means that the server doesn't know even what to do with the given path. So that feels more like "resource unavailable" than "RPC method not found".

[jiexi]

wondering if it makes sense to the constants found here https://github.com/MetaMask/rpc-errors/blob/main/src/error-constants.ts#L1C14-L1C24

[mcmire]

@jiexi

wondering if it makes sense to the constants found here

Which constants, and where?

[jiexi]

the errorCodes.rpc ones in place of some of the inlined 3xxxx values