fix(bridge-status-controller): use SnapKeyring.submitRequest to dispatch Snap keyring requests #5924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tch Snap keyring requests
ccharly
force-pushed
the
fix/use-snap-keyring-in-bridge
branch
from
8512029 to
bd4ede5
Compare
ccharly
commented
Jun 5, 2025
Comment on lines
-2857
to
-2884
| Array [ | ||
| "SnapController:handleRequest", | ||
| Object { | ||
| "handler": "onKeyringRequest", | ||
| "origin": "metamask", | ||
| "request": Object { | ||
| "id": "test-uuid-1234", | ||
| "jsonrpc": "2.0", | ||
| "method": "keyring_submitRequest", | ||
| "params": Object { | ||
| "account": undefined, | ||
| "id": "test-uuid-1234", | ||
| "request": Object { | ||
| "method": "signAndSendTransaction", | ||
| "params": Object { | ||
| "account": Object { | ||
| "address": "0x123...", | ||
| }, | ||
| "scope": "solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp", | ||
| "transaction": "AQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACAAQAHDXLY8oVRIwA8ZdRSGjM5RIZJW8Wv+Twyw3NqU4Hov+OHoHp/dmeDvstKbICW3ezeGR69t3/PTAvdXgZVdJFJXaxkoKXUTWfEAyQyCCG9nwVoDsd10OFdnM9ldSi+9SLqHpqWVDV+zzkmftkF//DpbXxqeH8obNXHFR7pUlxG9uNVOn64oNsFdeUvD139j1M51iRmUY839Y25ET4jDRscT081oGb+rLnywLjLSrIQx6MkqNBhCFbxqY1YmoGZVORW/QMGRm/lIRcy/+ytunLDm+e8jOW7xfcSayxDmzpAAAAAjJclj04kifG7PRApFI4NgwtaE5na/xCEBI572Nvp+FkAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAbd9uHXZaGT2cvhRs7reawctIXtX1s3kTqM9YV+/wCpBHnVW/IxwG7udMVuzmgVB/2xst6j9I5RArHNola8E4+0P/on9df2SnTAmx8pWHneSwmrNt/J3VFLMhqns4zl6JmXkZ+niuxMhAGrmKBaBo94uMv2Sl+Xh3i+VOO0m5BdNZ1ElenbwQylHQY+VW1ydG1MaUEeNpG+EVgswzPMwPoLBgAFAsBcFQAGAAkDQA0DAAAAAAAHBgABAhMICQAHBgADABYICQEBCAIAAwwCAAAAUEYVOwAAAAAJAQMBEQoUCQADBAETCgsKFw0ODxARAwQACRQj5RfLl3rjrSoBAAAAQ2QAAVBGFTsAAAAAyYZnBwAAAABkAAAJAwMAAAEJDAkAAAIBBBMVCQjGASBMKQwnooTbKNxdBwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAUHTKomh4KXvNgA0ovYKS5F8GIOBgAAAAAAAAAAAAAAAAAQgAAAAAAAAAAAAAAAAAAAAAAAEIF7RFOAwAAAAAAAAAAAAAAaAIAAAAAAAC4CwAAAAAAAOAA2mcAAAAAAAAAAAAAAAAAAAAApapuIXG0FuHSfsU8qME9s/kaic0AAwGCsZdSuxV5eCm+Ria4LEQPgTg4bg65gNrTAefEzpAfPQgCABIMAgAAAAAAAAAAAAAACAIABQwCAAAAsIOFAAAAAAADWk6DVOZO8lMFQg2r0dgfltD6tRL/B1hH3u00UzZdgqkAAxEqIPdq2eRt/F6mHNmFe7iwZpdrtGmHNJMFlK7c6Bc6k6kjBezr6u/tAgvu3OGsJSwSElmcOHZ21imqH/rhJ2KgqDJdBPFH4SYIM1kBAAA=", | ||
| }, | ||
| }, | ||
| "scope": "solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp", | ||
| }, | ||
| }, | ||
| "snapId": "test-snap", | ||
| }, | ||
| ], |
There was a problem hiding this comment.
We no longer uses the SnapController to dispatch those request.
ccharly
commented
Jun 5, 2025
| "@metamask/gas-fee-controller": "npm:^23.0.0" | ||
| "@metamask/keyring-api": "npm:^18.0.0" | ||
| "@metamask/multichain-transactions-controller": "npm:^2.0.0" | ||
| "@metamask/network-controller": "npm:^23.5.1" | ||
| "@metamask/polling-controller": "npm:^13.0.0" | ||
| "@metamask/snaps-controllers": "npm:^12.3.1" |
There was a problem hiding this comment.
Removed this dependency now that we rely solely on the SnapKeyring to dispatch keyring requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
I missed this when introducing the
KeyringRequest.originfeature.The main problem is that this controller is dispatching "raw Snap request", thus, preventing any type-checking when doing keyring API updades.
By using
SnapKeyringthis should prevent this kind of problems in the future and it aligns well on how other controllers interact with the Snap keyring requests!References
N/A
Changelog
Checklist