Fix/bridge status controller mobile hardware wallets #5931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
tommasini
reviewed
Jun 6, 2025
| ); | ||
| } else { | ||
| // For hardware wallets on Mobile, this is fixes an issue where the Ledger does not get prompted for the 2nd approval | ||
| if (requireApproval) { |
There was a problem hiding this comment.
I wonder what's causing the prompt for the second approval that get's fixed with a delay, this doens't seem ideal
There was a problem hiding this comment.
The issue I saw was that the 2nd Ledger confirmation modal gets dismissed for some reason if you don't delay. I think it's an issue with navigation.
- 1st Ledger modal appears
- You confirm it on your Ledger
- 1st Ledger modal dismisses
- At or near the same time, you submit the 2nd tx
- 2nd Ledger modal appears for a split second
- 2nd Ledger modal gets dismissed almost immediately
You never see the confirmation prompt on the Ledger itself for the 2nd tx
There was a problem hiding this comment.
I can leave a comment in the code if you would like as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR fixes an issue with Mobile and hardware wallets and EVM bridge transactions.
References
Mobile implementation of patch branch: MetaMask/metamask-mobile#15751
Related to patch branch: https://github.com/MetaMask/core/compare/%40metamask/bridge-status-controller%4025.0.0...patch/%40metamask/bridge-status-controller%4025.0.0-mobile-hardware-wallet?expand=1
Changelog
Checklist