feat: Add NetworkVisibilityController
#5939
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NetworkVisibilityController
is a core implementation of network ordering and enablement functionality that was previously only available in the extension. This PR moves and expands this functionality from the extension'sNetworkOrder
controller to core, enabling network ordering and visibility features across both extension and mobile platforms. It also renames it toNetworkVisibilityController
to more accurately represent what it does. Maybe in the future this can be expanded to include other UX enhancements that don't need to be tightly coupled with theNetworkController
Key motivations for this change:
Platform Parity: Network ordering was previously only implemented in the extension via
NetworkOrder
controller, leaving mobile without this functionality. Moving this to core will unlock the ability to have this feature built on mobile.Network Enablement Feature: This work is part of the broader Network Enablement initiative (Network Controller: Multi Networks Enablement feature #5737). The controller has been expanded to include
enabledNetworkMap
state, allowing us to:Code Quality Improvements: The move to core has provided an opportunity to:
The controller now handles three key aspects:
References
Checklist