refactor: bridge QuoteMetadata read/write#9507
Open
micaelae wants to merge 9 commits into
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9afe7b6. Configure here.
| const l1GasFeesInDecGWei = weiHexToGweiDec(toHex(l1GasFeesInHexWei ?? '0')); | ||
| const gasFeesInDecGwei = totalGasLimitInDec | ||
| .times(feePerGasInDecGwei ?? '0') | ||
| ?.times(feePerGasInDecGwei ?? '0') |
There was a problem hiding this comment.
Missing trade gas crashes fee
High Severity
When tradeGasLimit is missing or zero, calcTotalGasFee leaves totalGasLimitInDec undefined, then optional chaining on times yields undefined and the following .plus(l1GasFeesInDecGWei) runs on undefined, which throws. Approval-only gas and L1 fees are also skipped instead of being summed like before.
Reviewed by Cursor Bugbot for commit 9afe7b6. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Explanation
References
Checklist
Note
High Risk
Breaking
QuoteMetadatatyping plus changed fee/amount semantics (undefined vs former0/null) can affect quote sorting, displayed fees, and any consumer that assumed always-present metadata.Overview
Breaking:
QuoteMetadataand nested fee fields are now optional (DeepPartial) instead of always populated; derived quote math no longer fills missing inputs with0ornullwhere it previously did—those values are oftenundefinednow (e.g. relayer fee withouttrade.value, zero/missing gas limits).TokenAmountValues/QuoteMetadatamove out oftypes.tsinto newutils/quote-metadata, withcalcQuoteMetadatacentralizing metadata assembly andmergeQuoteMetadataattaching metadata to quote responses. Bridge selectors call those helpers instead of inlining fee/return calculations; sorting uses optional chaining oncost?.valueInCurrency.mergeQuoteMetadatais exported from@metamask/bridge-controller; bridge-status-controller builds test/fixture quotes via merge and reads metadata with optional access. Tests/mocks fix nativeslip44IDs (e.g.60for ETH) and add coverage for quotes withoutassetId.Reviewed by Cursor Bugbot for commit d088ab9. Bugbot is set up for automated code reviews on this repo. Configure here.