Skip to content

feat: add sample-snap#8

Merged
mikesposito merged 17 commits into
mainfrom
me/add-sample-snap
Jun 9, 2026
Merged

feat: add sample-snap#8
mikesposito merged 17 commits into
mainfrom
me/add-sample-snap

Conversation

@mikesposito

@mikesposito mikesposito commented Jun 8, 2026

Copy link
Copy Markdown
Member

Explanation

The example snap package included in https://github.com/MetaMask/template-snap-monorepo is being added to this monorepo as first usage demonstration, and proof that CI scripts are compatible with snaps

References

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Comment thread packages/sample-snap/CHANGELOG.md Outdated
@mikesposito mikesposito force-pushed the me/add-sample-snap branch from 85c3ce9 to b819215 Compare June 9, 2026 09:11
@mikesposito mikesposito force-pushed the me/add-sample-snap branch from b819215 to caf2a52 Compare June 9, 2026 09:15

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is essentially reverting a change made in #9. Now that we have at least one package, the original script should work properly

@mikesposito mikesposito marked this pull request as ready for review June 9, 2026 09:26
@mikesposito mikesposito requested a review from a team as a code owner June 9, 2026 09:26

@khanti42 khanti42 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikesposito mikesposito added this pull request to the merge queue Jun 9, 2026
Merged via the queue into main with commit 4c138bc Jun 9, 2026
38 checks passed
@mikesposito mikesposito deleted the me/add-sample-snap branch June 9, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants