feat(figma): add BannerAlert Code Connect and fix ButtonIcon node URL#1233
Open
georgewrmarshall wants to merge 1 commit into
Open
feat(figma): add BannerAlert Code Connect and fix ButtonIcon node URL#1233georgewrmarshall wants to merge 1 commit into
georgewrmarshall wants to merge 1 commit into
Conversation
- Add BannerAlert.figma.tsx for React and React Native pointing to Figma
node 9315-372; maps severity enum (Info/Success/Warning/Danger), title,
and description
- Update ButtonIcon.figma.tsx for both platforms to point to current Figma
node 5226-5609 (was stale 1:2860); fix prop names to match Figma
('disabled' → isDisabled, 'state' → variant)
Contributor
📖 Storybook Preview |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds Figma Code Connect files for
BannerAlertin both React and React Native, and fixes a stale Figma node URL inButtonIconfor both platforms.BannerAlert (
9315-372)BannerAlert.figma.tsxfor React and React Nativeseverityenum (Info / Success / Warning / Danger) — Figma's "Neutral" variant falls through to the component defaulttitleanddescriptionstring propshas Art,has Title,is Dismissible,has ActionButtonIcon (
5226-5609, was1:2860)'isDisabled'→'disabled','variant'→'state'to match actual Figma property namesRelated issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
1:2860(unmapped in Figma)After
5226-5609with correct prop mappings9315-372for both React and React NativePre-merge author checklist
Pre-merge reviewer checklist