-
-
Notifications
You must be signed in to change notification settings - Fork 3
chore: adding github workflow to publish storybook react #610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a728880
to
47bc524
Compare
After further inspection I'm not sure this action will work the same as it did in the design tokens repo. Will try forking the repo Update: I forked our repo and the action is now working you can see the deployed fork at georgewrmarshall.github.io/metamask-design-system |
47bc524
to
8c3ecfe
Compare
8c3ecfe
to
500ce32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove cache-node-modules
and try to use the official github action for deployment if possible.
Description
This PR adds GitHub Actions workflow to automatically build and deploy the Storybook React to GitHub Pages whenever changes are merged to the
main
branch.main
branchRelated issues
Fixes: #3
Manual testing steps
The action has been successfully tested(again) in a fork environment. You can see the working deployment at georgewrmarshall.github.io/metamask-design-system
Screenshots/Recordings
Before
N/A - No previous Storybook deployment
After
after480.mov
Technical Implementation Details
Pre-merge author checklist
Pre-merge reviewer checklist