fix: ESlint config #630
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,136 @@ | ||
| { | ||
|
There was a problem hiding this comment. Created to ensure we aren't introducing more eslint violations thanks to @mcmire's implementation in Core's eslint fix PR MetaMask/core#5132 |
||
| "packages/design-system-react-native/global.d.ts": { | ||
| "@typescript-eslint/naming-convention": 1 | ||
| }, | ||
| "packages/design-system-react-native/src/components/BadgeCount/BadgeCount.test.tsx": { | ||
| "jest/prefer-strict-equal": 1 | ||
| }, | ||
| "packages/design-system-react-native/src/components/BadgeIcon/BadgeIcon.test.tsx": { | ||
| "jest/prefer-strict-equal": 1 | ||
| }, | ||
| "packages/design-system-react-native/src/components/BadgeWrapper/BadgeWrapper.tsx": { | ||
| "@typescript-eslint/no-unused-vars": 1 | ||
| }, | ||
| "packages/design-system-react-native/src/components/Button/Button.test.tsx": { | ||
| "no-empty-function": 1 | ||
| }, | ||
| "packages/design-system-react-native/src/types/index.ts": { | ||
| "@typescript-eslint/no-shadow": 4 | ||
| }, | ||
| "packages/design-system-react/global.d.ts": { | ||
| "@typescript-eslint/naming-convention": 1 | ||
| }, | ||
| "packages/design-system-react/scripts/create-component/create-component.test.ts": { | ||
| "jest/no-conditional-in-test": 2 | ||
| }, | ||
| "packages/design-system-react/scripts/generate-icons-index.test.ts": { | ||
| "@typescript-eslint/no-base-to-string": 1, | ||
| "@typescript-eslint/no-shadow": 1 | ||
| }, | ||
| "packages/design-system-react/src/components/AvatarAccount/AvatarAccount.tsx": { | ||
| "import-x/no-named-as-default-member": 1 | ||
| }, | ||
| "packages/design-system-react/src/components/AvatarBase/AvatarBase.tsx": { | ||
| "import-x/no-named-as-default-member": 1 | ||
| }, | ||
| "packages/design-system-react/src/components/AvatarFavicon/AvatarFavicon.tsx": { | ||
| "import-x/no-named-as-default-member": 1 | ||
| }, | ||
| "packages/design-system-react/src/components/AvatarIcon/AvatarIcon.test.tsx": { | ||
| "import-x/no-named-as-default-member": 1 | ||
| }, | ||
| "packages/design-system-react/src/components/AvatarIcon/AvatarIcon.tsx": { | ||
| "import-x/no-named-as-default-member": 1 | ||
| }, | ||
| "packages/design-system-react/src/components/AvatarNetwork/AvatarNetwork.tsx": { | ||
| "import-x/no-named-as-default-member": 1 | ||
| }, | ||
| "packages/design-system-react/src/components/AvatarToken/AvatarToken.tsx": { | ||
| "import-x/no-named-as-default-member": 1 | ||
| }, | ||
| "packages/design-system-react/src/components/BadgeCount/BadgeCount.tsx": { | ||
| "import-x/no-named-as-default-member": 1 | ||
| }, | ||
| "packages/design-system-react/src/components/BadgeIcon/BadgeIcon.test.tsx": { | ||
| "import-x/no-named-as-default-member": 1 | ||
| }, | ||
| "packages/design-system-react/src/components/BadgeIcon/BadgeIcon.tsx": { | ||
| "import-x/no-named-as-default-member": 1 | ||
| }, | ||
| "packages/design-system-react/src/components/BadgeNetwork/BadgeNetwork.tsx": { | ||
| "import-x/no-named-as-default-member": 1 | ||
| }, | ||
| "packages/design-system-react/src/components/BadgeStatus/BadgeStatus.test.tsx": { | ||
| "import-x/no-named-as-default-member": 1 | ||
| }, | ||
| "packages/design-system-react/src/components/BadgeStatus/BadgeStatus.tsx": { | ||
| "import-x/no-named-as-default-member": 1 | ||
| }, | ||
| "packages/design-system-react/src/components/BadgeWrapper/BadgeWrapper.tsx": { | ||
| "import-x/no-named-as-default-member": 1 | ||
| }, | ||
| "packages/design-system-react/src/components/Button/Button.test.tsx": { | ||
| "import-x/no-named-as-default-member": 3 | ||
| }, | ||
| "packages/design-system-react/src/components/Button/Button.tsx": { | ||
| "import-x/no-named-as-default-member": 1 | ||
| }, | ||
| "packages/design-system-react/src/components/Button/variants/ButtonPrimary/ButtonPrimary.tsx": { | ||
| "import-x/no-named-as-default-member": 1 | ||
| }, | ||
| "packages/design-system-react/src/components/Button/variants/ButtonSecondary/ButtonSecondary.tsx": { | ||
| "import-x/no-named-as-default-member": 1 | ||
| }, | ||
| "packages/design-system-react/src/components/Button/variants/ButtonTertiary/ButtonTertiary.test.tsx": { | ||
| "import-x/no-named-as-default-member": 1 | ||
| }, | ||
| "packages/design-system-react/src/components/Button/variants/ButtonTertiary/ButtonTertiary.tsx": { | ||
| "import-x/no-named-as-default-member": 1 | ||
| }, | ||
| "packages/design-system-react/src/components/ButtonBase/ButtonBase.tsx": { | ||
| "import-x/no-named-as-default-member": 1 | ||
| }, | ||
| "packages/design-system-react/src/components/ButtonIcon/ButtonIcon.tsx": { | ||
| "import-x/no-named-as-default-member": 1 | ||
| }, | ||
| "packages/design-system-react/src/components/Icon/template.test.ts": { | ||
| "@typescript-eslint/no-base-to-string": 1, | ||
| "jest/no-conditional-in-test": 1 | ||
| }, | ||
| "packages/design-system-react/src/components/TextButton/TextButton.tsx": { | ||
| "import-x/no-named-as-default-member": 1 | ||
| }, | ||
| "packages/design-system-react/src/components/temp-components/Jazzicon/Jazzicon.utilities.ts": { | ||
| "jsdoc/require-param-description": 3, | ||
| "jsdoc/require-returns": 3 | ||
| }, | ||
| "packages/design-system-react/src/types/index.ts": { | ||
| "@typescript-eslint/no-shadow": 7 | ||
| }, | ||
| "packages/design-system-tailwind-preset/src/colors.test.ts": { | ||
| "jest/no-conditional-in-test": 1 | ||
| }, | ||
| "packages/design-system-tailwind-preset/src/index.test.ts": { | ||
| "jest/no-conditional-in-test": 3 | ||
| }, | ||
| "packages/design-system-tailwind-preset/src/typography.test.ts": { | ||
| "jest/no-conditional-in-test": 1 | ||
| }, | ||
| "packages/design-system-twrnc-preset/src/Theme/Theme.providers.tsx": { | ||
| "no-empty-function": 2 | ||
| }, | ||
| "packages/design-tokens/src/js/brandColor/brandColor.test.ts": { | ||
| "jest/no-conditional-in-test": 2 | ||
| }, | ||
| "packages/design-tokens/stories/Typography.stories.tsx": { | ||
| "@typescript-eslint/no-unused-vars": 2 | ||
| }, | ||
| "scripts/create-package/utils.test.ts": { | ||
| "@typescript-eslint/no-unsafe-enum-comparison": 3, | ||
| "import-x/no-named-as-default-member": 2, | ||
| "jest/no-conditional-in-test": 1 | ||
| }, | ||
| "scripts/create-package/utils.ts": { | ||
| "@typescript-eslint/no-unsafe-enum-comparison": 5 | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This update to our linting step is required for ensuring that the Tailwind Prettier plugin operates correctly. By running
yarn workspace @metamask/design-system-tailwind-preset build, we ensure that the Tailwind preset is built and its configuration is available. Without this step, the Tailwind Prettier plugin would fail to lint properly since it relies on the preset's configuration to validate styles accurately.Without this update our CI will fail at the linting step.
yarn lintwill also fail locally if the tailwind preset is not built.