Skip to content

Fix Sidebar issue. #2090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bgravenorst merged 3 commits into from
Jun 17, 2025
Merged

Fix Sidebar issue. #2090

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7323ce8
Fix Sidebar issue.
bgravenorst Jun 17, 2025
bee7608
Fix styling.
bgravenorst Jun 17, 2025
e49cf8b
Merge branch 'main' into DOC-1854
bgravenorst Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 22 additions & 13 deletions src/components/CustomReferencePage/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import React from 'react';
import React from "react";
Comment thread
bgravenorst marked this conversation as resolved.
import Layout from "@theme/Layout";
import ParserOpenRPC from "@site/src/components/ParserOpenRPC";
import DocSidebar from '@theme/DocSidebar';
import DocSidebar from "@theme/DocSidebar";
import { useLocation } from "@docusaurus/router";
import { prepareLinkItems, MM_REF_PATH } from '@site/src/plugins/plugin-json-rpc';
import { prepareLinkItems, MM_REF_PATH } from "@site/src/plugins/plugin-json-rpc";
import styles from "./styles.module.css";
const sidebar = require("../../../wallet-sidebar.js");

Expand All @@ -29,39 +29,48 @@ function transformItems(items, dynamicItems) {
}
}
if (newItem.href) {
if (!newItem.href.startsWith("/")) {
newItem.href = `/${newItem.href}`;
}
if (newItem.href.endsWith("/index")) {
newItem.href = newItem.href.slice(0, -5);
}
if (!newItem.href.startsWith("/")) {
newItem.href = `/${newItem.href}`;
if (newItem.href === "/") {
newItem.href = "/wallet/";
} else {
newItem.href = `/wallet${newItem.href}`;
}
Comment on lines +32 to 42

Copilot AI Jun 17, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider consolidating the URL normalization logic in the transformItems function. For clarity, ensure that the decision to always prefix with '/wallet' aligns with handling both absolute and relative paths uniformly.

Suggested change
if (!newItem.href.startsWith("/")) {
newItem.href = `/${newItem.href}`;
}
if (newItem.href.endsWith("/index")) {
newItem.href = newItem.href.slice(0, -5);
}
if (!newItem.href.startsWith("/")) {
newItem.href = `/${newItem.href}`;
if (newItem.href === "/") {
newItem.href = "/wallet/";
} else {
newItem.href = `/wallet${newItem.href}`;
}
newItem.href = normalizeHref(newItem.href);

Copilot uses AI. Check for mistakes.
newItem.href = `/wallet${newItem.href}`;
}
return newItem;
});
}

const CustomReferencePage = (props) => {
const CustomReferencePage = props => {
const customData = props.route.customData;
const { pathname } = useLocation();
const refItems = prepareLinkItems(props.methodsData, MM_REF_PATH).map(item => ({...item, href: item.href.replace("/wallet", "")}))
const refItems = prepareLinkItems(props.methodsData, MM_REF_PATH).map(item => ({
...item,
href: item.href.replace("/wallet", ""),
}));
const updatedSidebar = transformItems(sidebar.walletSidebar, refItems);
return (
<Layout>
<div className={styles.pageWrapper}>
<aside>
<div className={styles.sidebarViewport}>
<div className={styles.sidebar}>
<DocSidebar sidebar={updatedSidebar} path={pathname} onCollapse={() => {}} isHidden={false} />
<DocSidebar
sidebar={updatedSidebar}
path={pathname}
onCollapse={() => {}}
isHidden={false}
/>
</div>
</div>
</aside>
<div className={styles.mainContainer}>
<div className={styles.contentWrapper}>
<ParserOpenRPC
network={customData.networkName}
method={customData.name}
/>
<ParserOpenRPC network={customData.networkName} method={customData.name} />
</div>
</div>
</div>
Expand Down
Loading