Rollback centra font#2093
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR rolls back the primary font from MM Centra to Euclid Circular B by adding the necessary font-face declarations and updating all references.
- Introduces Euclid Circular B @font-face rules (regular, medium, bold, italic)
- Adds a new CSS variable
--font-mm-euclidand switches base font-family to it - Updates all
var(--font-mm-centra)references tovar(--font-mm-euclid)
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/scss/theme/_fonts.scss | Added Euclid Circular B @font-face declarations |
| src/scss/custom.scss | Defined new --font-mm-euclid and swapped usages |
| src/scss/commons/_typescale.scss | Changed .font-primary to use Euclid variable |
| src/scss/app.scss | Updated global font-family to Euclid variable |
Comments suppressed due to low confidence (2)
src/scss/theme/_fonts.scss:61
- The Medium font reference omits the
-WebXLsuffix used by the Regular and Bold files; ensure the filename matches the actual asset to avoid 404s.
src: url('/fonts/EuclidCircularB/EuclidCircularB-Medium.ttf') format('truetype');
src/scss/custom.scss:704
- [nitpick] This change switches from double to single quotes for an empty string. For consistency with the rest of the codebase (which uses double quotes), consider reverting to
""or aligning all content strings.
content: '';
| font-style: normal; | ||
| font-weight: 400; | ||
| font-display: swap; | ||
| src: url('/fonts/EuclidCircularB/EuclidCircularB-Regular-WebXL.ttf') format('truetype'); |
There was a problem hiding this comment.
Consider adding a WOFF2 source before the TTF for better compression and browser support, e.g., url(.../Regular-WebXL.woff2) format('woff2').
Suggested change
| src: url('/fonts/EuclidCircularB/EuclidCircularB-Regular-WebXL.ttf') format('truetype'); | |
| src: url('/fonts/EuclidCircularB/EuclidCircularB-Regular-WebXL.woff2') format('woff2'), | |
| url('/fonts/EuclidCircularB/EuclidCircularB-Regular-WebXL.ttf') format('truetype'); |
alexandratran
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description