Rearrange API methods in the sidebar.#2098
Merged
Merged
Conversation
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
Adds a configurable sorting system for JSON-RPC methods in the wallet API sidebar so that methods are grouped and ordered by prefix priorities.
- Introduces
METHOD_SORT_PRIORITIES,METHOD_SORT_CONFIG,getMethodPrefix, andsortMethods - Updates
prepareLinkItemsandfetchAndGenerateDynamicSidebarItemsto apply the sorting - Minor refactoring for consistent quoting and formatting
alexandratran
previously approved these changes
Jun 18, 2025
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
alexandratran
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add configurable method sorting to wallet API sidebar
Problem
Methods in the wallet API sidebar were not displayed in a consistent order, making it difficult for users to find specific methods.
Solution
Implemented a configurable sorting system that groups methods by prefix with configurable priorities:
wallet_methods appear first (alphabetically)eth_methods appear second (alphabetically)personal_methods appear third (alphabetically)web3_methods appear fourth (alphabetically)Issue(s) fixed
Fixes #782
Checklist
Complete this checklist before merging your PR: