Skip to content

update node to 20 from 18#2150

Merged
alexandratran merged 2 commits into
mainfrom
node20
Jul 16, 2025
Merged

update node to 20 from 18#2150
alexandratran merged 2 commits into
mainfrom
node20

Conversation

@joshuafernandes

Copy link
Copy Markdown
Collaborator

Description

update node to 20 from 18 as it has ended support

@joshuafernandes joshuafernandes requested review from a team as code owners July 16, 2025 22:17
@vercel

vercel Bot commented Jul 16, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metamask-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2025 10:27pm

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Node Version Constraint Too Restrictive

The engines.node constraint was changed from ">=18" to "20.x". This is overly restrictive, preventing the package from running on Node.js versions 21 and higher. The constraint should be ">=20" to set Node 20 as the new minimum while maintaining forward compatibility with future Node.js versions.

package.json#L112-L113

metamask-docs/package.json

Lines 112 to 113 in be2824c

"engines": {
"node": "20.x"

Fix in CursorFix in Web


Was this report helpful? Give feedback by reacting with 👍 or 👎

@alexandratran alexandratran merged commit ccaceec into main Jul 16, 2025
19 checks passed
@alexandratran alexandratran deleted the node20 branch July 16, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants