Fix mmc release v31#2876
Merged
Merged
Conversation
Add a new troubleshooting 'Cause C' that explains how a strict Content Security Policy can prevent the MetaMask QR code from rendering (the fox SVG is embedded as a data: URI and materialized via a fetch-style call). The entry documents the console error, outlines the required CSP directives (allow data: in connect-src/img-src, include mm-sdk relay and analytics origins, and style-src 'unsafe-inline'), provides a minimal meta-tag example, and links to the connect-monorepo CSP reference.
Document breaking API changes: connectAndSign and connectWith now return objects ({ accounts, chainId, signature }) and ({ accounts, chainId, result }) respectively. Updated examples across quickstart, guides, and reference to destructure these fields and log accounts/chainId alongside results, and added breaking-change notes. Also adjusted the EVM client status type name to ConnectEvmStatus in the reference and clarified CSP troubleshooting guidance for the QR-code fox SVG (img-src data: and older-version fallbacks).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Update wording in EVM guides and reference to clarify that connectAndSign and connectWith now return objects and callers should read `.signature` and `.result` from the returned object (rather than implying destructuring). Minor punctuation/phrasing tweaks in migrate-from-sdk guide and methods reference for clearer guidance.
AyushBherwani1998
previously approved these changes
Apr 22, 2026
alexandratran
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Document breaking API changes: connectAndSign and connectWith now return objects ({ accounts, chainId, signature }) and ({ accounts, chainId, result }) respectively. Updated examples across quickstart, guides, and reference to destructure these fields and log accounts/chainId alongside results, and added breaking-change notes. Also adjusted the EVM client status type name to ConnectEvmStatus in the reference and clarified CSP troubleshooting guidance for the QR-code fox SVG (img-src data: and older-version fallbacks).
Issue(s) fixed
Fixes #
Preview
Checklist
External contributor checklist
Note
Low Risk
Documentation-only changes; main risk is confusing developers if the updated return shapes/CSP guidance are incorrect.
Overview
Updates MetaMask Connect EVM docs to reflect breaking return-shape changes:
connectAndSignnow returns{ accounts, chainId, signature }andconnectWithreturns{ accounts, chainId, result }, and all affected examples/event-handler snippets are updated to destructure and log the new fields.Clarifies related documentation details, including renaming the documented client
statustype toConnectEvmStatus, tightening CSP guidance for QR rendering (requiredata:inimg-srcrather thanconnect-src), and updating the Linea Sepolia bridge link.Reviewed by Cursor Bugbot for commit bbb99fd. Bugbot is set up for automated code reviews on this repo. Configure here.