Skip to content

mmuftic/fix manifest generation #13007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 7, 2021
Merged

Conversation

kumavis
Copy link
Member

@kumavis kumavis commented Dec 7, 2021

merge conflict fix for #12533 (could not modify directly)

@kumavis kumavis requested a review from a team as a code owner December 7, 2021 19:03
@kumavis kumavis requested a review from jpuri December 7, 2021 19:03
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [0e92ebd]
Page Load Metrics (1044 ± 39 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint631191171254122
domContentLoaded934119910427938
load934121510448039
domInteractive934119910427938

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@darkwing darkwing merged commit 7dac6f2 into develop Dec 7, 2021
@darkwing darkwing deleted the mmuftic/fix-manifest-generation branch December 7, 2021 22:31
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants