Test, please ignore #31090
Draft
Test, please ignore #31090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Moving solana code fences to `beta` <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/30613?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
#30616) ## **Description** V1 does not support non-evm token detail navigation. We should disable the click handler for non-evm tokens, so that the below warning does not get thrown on click:  [](https://codespaces.new/MetaMask/metamask-extension/pull/30616?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Start flask build 2. Add Solana Account, and Evm Account 3. TokenListItem clicks should remain functional for evm tokens, non-evm tokens should not be functional, but should not throw warning to console. ## **Screenshots/Recordings** https://github.com/user-attachments/assets/fe6f5d77-3231-4316-b525-8bff22fba0e8 ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
…30594) ## **Description** Adds 5 decimal place precision to token cell and account list item. Also should remove trailing zeros. ## **Related issues** Fixes: ## **Manual testing steps** ## **Screenshots/Recordings** <img width="357" alt="Screenshot 2025-02-27 at 8 21 48 AM" src="https://github.com/user-attachments/assets/899037a5-282b-4757-9eb9-c379bfe869f4" /> <img width="360" alt="Screenshot 2025-02-27 at 8 22 18 AM" src="https://github.com/user-attachments/assets/39e649f8-e64a-4da5-a258-283a366cb89e" /> <img width="360" alt="Screenshot 2025-02-27 at 8 22 49 AM" src="https://github.com/user-attachments/assets/e04ca338-76e0-4705-ab85-abddcee855ef" /> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/30615?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/30574?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/30600?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Hacky way to display when Solana txs in the activity log are bridges. Polling and more robust code to be added. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/30619?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to bridge page on Solana. 2. Bridge to EVM network. 3. Observe transaction labeled as Bridge populate in activity after it is detected. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Micaela Estabillo <[email protected]>
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least oncea --> ## **Description** Changes include - Follow up changes to [30313](https://github.com/MetaMask/metamask-extension/pull/30313/files#r1970625441) for addressing comments by @darkwing - Pass a srcChainId to AssetPicker when swapping so that the selected asset's balance is included in data <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/30622?quickstart=1) ## **Related issues** Fixes: N/A ## **Manual testing steps** 1. Open in Flask 2. Go to Solana 3. Select a token 4. balance should be visible ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <img width="367" alt="Screenshot 2025-02-27 at 3 25 55 PM" src="https://github.com/user-attachments/assets/71543031-c230-46ff-9e8e-394b6fe85338" /> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/30618?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
…n or network (#30550) ## **Description** Adding info alert when new confirmation is from different origin or network ## **Related issues** Fixes: MetaMask/MetaMask-planning#4278 ## **Manual testing steps** 1. Connect extension to multiple dapps 2. Send confirmation request from first and then from second 3. Notice info alerts on second confirmation ## **Screenshots/Recordings** <img width="359" alt="Screenshot 2025-02-26 at 10 48 44 AM" src="https://github.com/user-attachments/assets/757726e6-7692-4104-9f9d-cb9f1911859e" /> <img width="359" alt="Screenshot 2025-02-26 at 10 49 01 AM" src="https://github.com/user-attachments/assets/af125590-eb12-4548-82b9-9cf46d921cc4" /> ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
## **Description** Integrate alert system into template based confirmations. ## **Related issues** Fixes: MetaMask/MetaMask-planning#4284 ## **Manual testing steps** NA ## **Screenshots/Recordings** <img width="350" alt="Screenshot 2025-02-26 at 5 39 23 PM" src="https://github.com/user-attachments/assets/d69ff86e-21bb-498e-858a-09f33a58cbf5" /> <img width="494" alt="Screenshot 2025-02-26 at 5 39 46 PM" src="https://github.com/user-attachments/assets/b8009205-c4f1-4095-872c-402f71985ced" /> ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
## **Description** This PR adds `profile_id` as a MetaMetrics user trait so that it gets attached to every event when present in the state. [](https://codespaces.new/MetaMask/metamask-extension/pull/30552?quickstart=1) ## **Related issues** Related to: https://consensyssoftware.atlassian.net/browse/IDENTITY-39 Segment PR: Consensys/segment-schema#243 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
#30631) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR aims to fix flaky test on `send-max.spec.js` and improves readability. [](https://codespaces.new/MetaMask/metamask-extension/pull/30631?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: dddddanica <[email protected]>
## **Description** [Trezor's changelog](https://github.com/trezor/trezor-suite/blob/develop/packages/connect/CHANGELOG.md) > _Starting with this release we changed de target in all @trezor packages to ES2022. It might be problematic in some very old environment or if you use Typescript with lower than ES2022 you might have to add ES2022 lib to your tsconfig. We are also include esm builds in our npm packages. For now only in @trezor/connect-plugin-stellar and @trezor/connect-plugin-ethereum._ > > _Another important change comes from 013f14a where we ping trezor-bridge and if it comes online connect would ditch webusb transport and start using bridge instead. This should help potential inconsistent states of device communication._ ``` └─ @trezor/connect-web ├─ ID: @trezor/connect-web (deprecation) ├─ Issue: This version is no longer supported ├─ Severity: moderate ├─ Vulnerable Versions: 9.4.0 │ ├─ Tree Versions │ └─ 9.4.0 │ └─ Dependents └─ metamask-crx@workspace:. ``` [](https://codespaces.new/MetaMask/metamask-extension/pull/30640?quickstart=1) ## **Related issues** N/A ## **Manual testing steps** TODO ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
## **Description** This PR addresses an issue introduced in PR #30408 where elements using `color: inherit` incorrectly inherit `var(--brand-colors-white)` in light mode. The previous PR fixed error page text visibility in dark mode but inadvertently created contrast and readability issues in light mode. The issue stems from changes in the CSS cascade and selector structure in `ui/css/base-styles.scss`, specifically how color is applied to the `body` element within the dark mode media query. This fix ensures proper color inheritance based on the current theme while maintaining the dark mode improvements. ## **Related issues** Fixes: #30650 Related to: #30408 (original dark mode error page fix) ## **Manual testing steps** 1. Set your system to light mode 2. Verify text using `color: inherit` appears with proper contrast (dark text on light background) in more menu and send screens 3. Switch to dark mode and verify text is still visible (light text on dark background) 4. Test the error page in both modes to ensure it maintains proper text visibility (testing steps in #30408) 5. Test components using `color: inherit` in both modes to verify correct inheritance ## **Screenshots/Recordings** ### **Before**   ### **After** Colors are correctly inheriting theme level design tokens again https://github.com/user-attachments/assets/ca17a98c-37e8-4e48-98b6-4967ef8f5bc0 Error page still works as expected https://github.com/user-attachments/assets/f99c1f96-619b-4325-bc68-6cd722277aa9 ## **Pre-merge author checklist** - [x] I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards. - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using JSDoc format if applicable - [x] I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
…void exceeding our quota (#30610) ## **Description** - Reduce by 25% our sentry trace sample rate to avoid exceeding our quota. ## **Related issues** Fixes: None ## **Manual testing steps** - None ## **Screenshots/Recordings** - None ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
## **Description** Fix the first step of the transaction details when arriving in linea [](https://codespaces.new/MetaMask/metamask-extension/pull/30644?quickstart=1) ## **Related issues** Fixes: Transaction details for a bridge transaction ## **Manual testing steps** 1. Go to bridge page 2. Create a bridge 3. Check status ## **Screenshots/Recordings** <img width="418" alt="Screenshot 2025-02-28 at 16 07 47" src="https://github.com/user-attachments/assets/578e468b-6aeb-4474-9ac6-a53031c984d6" /> <img width="418" alt="Screenshot 2025-02-28 at 16 14 11" src="https://github.com/user-attachments/assets/301fda54-024f-4da6-ab86-d1680a934843" /> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
## **Description** There was a bug introduced in #26845 where E2E test failures would create folders named `test-artifacts/undefined` in some situations (see _Before_ screenshot). This happened because the `artifactDir` function was referencing `this.browser` outside of the scope where it was defined. I moved the function so that it's in scope now. [](https://codespaces.new/MetaMask/metamask-extension/pull/30591?quickstart=1) ## **Related issues** Fixes: bug introduced in #26845 ## **Manual testing steps** 1. Create a deliberate failure in an E2E test 2. Run the E2E test 3. Check folder output ## **Screenshots/Recordings** ### **Before**  ### **After**  <!--## **Pre-merge author checklist** ## **Pre-merge reviewer checklist**-->
…est (#30680) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This temporarily disables the "Test Snap update via snaps component" test because it's broken on `main`. [](https://codespaces.new/MetaMask/metamask-extension/pull/30680?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Addressing MetaMask/MetaMask-planning#4017 We want to create a merger for the Caip25Permission specification in order to enable wallet_addEthereumChain and wallet_switchEthereumChain to call to the PermissionController rather than the ApprovalController for incremental permission requests (i.e. for the permittedChains flow). Merger created in this [core PR](MetaMask/core#5283) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/30042?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** We can start everything off by making sure we use the dev build of extension via `yarn && yarn webpack` or `yarn && yarn start` ### `wallet_requestPermissions` empty `eth_accounts` request (default) 1. Send the following request through dev tools console via [wallet_requestPermissions](https://docs.metamask.io/wallet/reference/json-rpc-methods/wallet_requestPermissions/) ```js await window.ethereum.request({ method: 'wallet_requestPermissions', params: [ { 'eth_accounts': {}, } ] }); ``` 2. Should render the following UI <img width="353" alt="Screenshot 2025-02-26 at 18 15 26" src="https://github.com/user-attachments/assets/e6a01efa-a15a-4790-89e9-2710e387b02b" /> <img width="358" alt="Screenshot 2025-02-26 at 18 15 19" src="https://github.com/user-attachments/assets/03a777a0-da68-4f0f-b2d1-fc8c76ed6f7d" /> 3. After approval, the dapp should also have `eth_accounts` and `endowment:permitted-chains` permission for the recently added chain via `wallet_getPermissions` ### `wallet_requestPermissions` `eth_accounts` account permission request 1. Send the following request through dev tools console via [wallet_requestPermissions](https://docs.metamask.io/wallet/reference/json-rpc-methods/wallet_requestPermissions/) ```js await window.ethereum.request({ method: 'wallet_requestPermissions', params: [ { 'eth_accounts': { 'caveats': [ { 'type': 'restrictReturnedAccounts', 'value': ["0x0aC9D99d92AB266e33b27469f8ce84FE7C56b6d5"] // replace this account with your local account public address } ] }, } ] }); ``` 2. Should render the following UI <img width="358" alt="Screenshot 2025-02-26 at 18 19 32" src="https://github.com/user-attachments/assets/33384044-2205-4d06-bced-51fd4a3b0301" /> <img width="353" alt="Screenshot 2025-02-26 at 18 19 23" src="https://github.com/user-attachments/assets/27af0e19-cfe9-43f5-a039-06cf1b0cb939" /> 3. After approval, the dapp should also have `eth_accounts` and `endowment:permitted-chains` permission for the recently added chain via `wallet_getPermissions` ### `wallet_requestPermissions` `endowment:permitted-chains` chain permission request 1. Send the following request through dev tools console via [wallet_requestPermissions](https://docs.metamask.io/wallet/reference/json-rpc-methods/wallet_requestPermissions/) ```js await window.ethereum.request({ method: 'wallet_requestPermissions', params: [ { 'eth_accounts': { 'caveats': [ { 'type': 'restrictReturnedAccounts', 'value': [] } ] }, 'endowment:permitted-chains': { 'caveats': [ { 'type': 'restrictNetworkSwitching', 'value': ["0x1"] // replace with desired chain, here we default to mainnet } ] } } ] }); ``` 2. Should render the following UI <img width="352" alt="Screenshot 2025-02-26 at 18 22 15" src="https://github.com/user-attachments/assets/ad93a621-0282-4d59-b91e-4d6d66b1a64d" /> <img width="354" alt="Screenshot 2025-02-26 at 18 22 09" src="https://github.com/user-attachments/assets/5eb7a5bf-41f0-4c5a-9280-f1a926180e1c" /> 3. After approval, the dapp should also have `eth_accounts` and `endowment:permitted-chains` permission for the recently added chain via `wallet_getPermissions` ### `wallet_requestPermissions` `eth_accounts` and `endowment:permitted-chains` account + chain permission request 1. Send the following request through dev tools console via [wallet_requestPermissions](https://docs.metamask.io/wallet/reference/json-rpc-methods/wallet_requestPermissions/) ```js await window.ethereum.request({ method: 'wallet_requestPermissions', params: [ { 'eth_accounts': { 'caveats': [ { 'type': 'restrictReturnedAccounts', 'value': ["0x0aC9D99d92AB266e33b27469f8ce84FE7C56b6d5"] // replace this account with your local account public address } ] }, 'endowment:permitted-chains': { 'caveats': [ { 'type': 'restrictNetworkSwitching', 'value': ["0x1"] // replace with desired chain, here we default to mainnet } ] } } ] }); ``` 2. Should render the following UI <img width="356" alt="Screenshot 2025-02-26 at 18 23 34" src="https://github.com/user-attachments/assets/f63530ff-820a-4c43-a0e4-4b9bf7fa955a" /> <img width="350" alt="Screenshot 2025-02-26 at 18 23 29" src="https://github.com/user-attachments/assets/b2db17b6-0395-4c08-ad3f-2176cb4dcea8" /> 3. After approval, the dapp should also have `eth_accounts` and `endowment:permitted-chains` permission for the recently added chain via `wallet_getPermissions` ### `wallet_requestPermissions` malformed `eth_accounts` address 1. Send the following request through dev tools console via [wallet_requestPermissions](https://docs.metamask.io/wallet/reference/json-rpc-methods/wallet_requestPermissions/) ```js await window.ethereum.request({ method: 'wallet_requestPermissions', params: [ { 'eth_accounts': { 'caveats': [ { 'type': 'restrictReturnedAccounts', 'value': ["malformed.eth"] } ] }, 'endowment:permitted-chains': { 'caveats': [ { 'type': 'restrictNetworkSwitching', 'value': [] } ] } } ] }); ``` 2. Should see an exception being thrown in the console, with the message `Value must be a hexadecimal string, starting with "0x".` <img width="730" alt="Screenshot 2025-02-27 at 10 16 31" src="https://github.com/user-attachments/assets/0a13f3f9-3ec3-4093-a9fc-331faa4e29ee" /> ### `wallet_switchEthereumChain` Permissions for new chain 1. Send the following request through dev tools console via [wallet_switchEthereumChain](https://docs.metamask.io/wallet/reference/json-rpc-methods/wallet_switchethereumchain/) ```js await window.ethereum.request({ jsonrpc: '2.0', method: 'wallet_switchEthereumChain', params: [{ chainId: '0xe705' }], // replace by a chain that's currently not permitted, I used Linea Sepolia }) ``` 2. Should render the following UI <img width="350" alt="Screenshot 2025-02-26 at 18 26 20" src="https://github.com/user-attachments/assets/c93a9487-ebab-43fd-9713-6ef4adbffc39" /> 4. After approval, the dapp should also have `eth_accounts` and `endowment:permitted-chains` permission for the recently added chain via `wallet_getPermissions` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: ffmcgee <[email protected]> Co-authored-by: ffmcgee <[email protected]> Co-authored-by: Alex Donesky <[email protected]> Co-authored-by: ffmcgee <[email protected]>
**Note to QA testers. This file does not change runtime behavior. It is a linting tool only. You do not need to test it for a release.** --- This PR prevents circular dependencies from being added to our codebase in the specified directories (see `.madgerc`). It also fixes an issue with our previous version of this check. The previous version ignored many files, because it tried to use a non-existent webpack config. We no longer use the `webpackConfig` option (it doesn't do anything for us anyway), and we now have an additional check to ensure we do not skip tracking any imported files. We now check a list of folders that are allowed to have circular dependencies. If a circular dependency is added that it not allowed, the `[check](circular-deps:check)` job fails, even if it was added to the `./development/circular-deps.jsonc` file. It also does a check to make sure that all "allowed" files/folders actually have circular dependencies within them. If a user removes the last circular dependency from an "allowed" file/folder, the check fails (with a celebratory message and instructions on how to resolve the issue). ## Example failure outputs for `yarn circular-deps:check`: ### User needs to run `yarn circular-deps:update`:  ### User introduced a new circular dependency in a folder that isn't permitted:  ### User removed the last circular dependency in a file/folder that is _allowed_ circular dependencies. They need to remove the allowed folder/file from .madgerc:  ### User introduced a file madge can't parse:  There is currently no good resolution for this error. We may need to add a way of working around this in the future. This check exists to ensure we don't skip any circular dependencies again. --- _Note: behavior of `yarn circular-deps:update` is not changed; it still only tracks circular deps, it doesn't care about our "allowed" directories or "skipped" files._ ## To test: ### To trigger the new "New circular dependencies issues were found in disallowed folders" error: Remove any folder/file in the `allowedCircularGlob` array in `.madgerc`, run `yarn circular-deps:update`, then run `yarn circular-deps:check` to generate the new error message. ### To trigger the new "The following allowed circular dependency patterns do not match any files" check: Add a new file/folder (it doesn't need to exist) to the `allowedCircularGlob` array in `.madgerc` then run `yarn circular-deps:check` to generate the new error message. ### To trigger the new "✖ Skipped files found" error: Add an import to a file that madge can't parse, like a scss file (`import '../ui/css/index.scss';`). You can test this by adding `import '../ui/css/index.scss';` to `/app/scripts/load/ui.ts`, then running `yarn circular-deps:update`. <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? [](https://codespaces.new/MetaMask/metamask-extension/pull/30148?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --> --------- Co-authored-by: MetaMask Bot <[email protected]>
## **Description** This allows us to capture errors when rendering grid items and prevent them from bubbling up and crashing the app. Ideally we want to handle the actual causes for the crash. In this case it was an NFT that has 2 images, when we expect a single image string. [](https://codespaces.new/MetaMask/metamask-extension/pull/30486?quickstart=1) ## **Related issues** ## **Manual testing steps** ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: salimtb <[email protected]>
## **Description** ### Major changes - **prep-deps** - There's a new workflow that parallels the CircleCI workflow. `prep-deps` runs first and caches the result, then `prep-build-test-webpack` makes an artifact, then the benchmarks run. - Several of the existing workflows were changed to now depend on `prep-deps` - Many of the file changes are just using the new `checkout-and-setup@caching` and deleting the independent "Checkout repository" step - ~~**vars.USE_CACHING**~~ No longer using this - ~~This allows us to toggle the caching feature on and off in a centralized way. I left instructions as a comment in `main.yml` for how to toggle it. We can discuss implementing this in a different way, but passing this variable through different workflows is actually kind of a pain (that's the first way I implemented it). Several of the jobs are 30-60 seconds faster when this is turned on.~~ - **~~test-short-suite~~ repository-health-checks** - I think this could be slightly controversial, but I think it's for the better. - I noticed that there were 7 individual really short tests, that each ran on their own VM. Each VM instance took about 1m30s to execute. I combined these together into a single VM that runs all the short tests in sequence, and takes about 1m20s combined. The `if: always()` statements make all independent tests run, even if one fails. - The 7 jobs were: `test-lint-shellcheck, test-lint-changelog, test-lint-lockfile, test-deps-audit, test-yarn-dedupe, test-deps-depcheck, validate-lavamoat-allow-scripts` - If this were running on VMs that cost money, this would be a no-brainer. As is on GitHub runners, it doesn't really cost us any time or money. All we can really say is 7 separate jobs burn fossil fuels for a slight bit of convenience in terms of seeing individual test failures in the GitHub PR page. ### Prerequisites to merging this PR - ~~Depends on #29955~~ **MERGED** - ~~Merge this `caching` branch of `github-tools`: MetaMask/github-tools#42~~ **MERGED** - ~~Change `checkout-and-setup@caching` and `checkout-and-setup-secure@caching` to new `@hash`~~ [](https://codespaces.new/MetaMask/metamask-extension/pull/29979?quickstart=1) ## **Related issues** Split off from: #29955 <!-- ## **Manual testing steps** ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** ## **Pre-merge reviewer checklist** --> --------- Co-authored-by: Hassan Malik <[email protected]>
## **Description** When the users does not have a non Evm account, the bridge cannot calculated the users balance. [](https://codespaces.new/MetaMask/metamask-extension/pull/30671?quickstart=1) ## **Related issues** Fixes: #30662 ## **Manual testing steps** 1. Build the App 2. Go to the brige page ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** ### **After** <img width="679" alt="Screenshot 2025-03-03 at 10 00 26" src="https://github.com/user-attachments/assets/144d091f-f73e-4270-9cc1-85275fdd9574" /> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
…#30515) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** A variety of E2E tests now have console errors in the service worker process related to failures fetching remote feature flags. The error is caused by an invalid mock metametrics ID (`fake-metrics-id`). Since we introduced validation in @metamas/remote-feature-flags controller: https://github.com/MetaMask/core/blob/main/packages/remote-feature-flag-controller/src/utils/user-segmentation-utils.ts#L52, we need to modify the existing e2e test how `metametricsId` is mocked into a valid hex value. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/30515?quickstart=1) ## **Related issues** Fixes: #30509 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** In this PR, we remove the `ganacheServer` variable from the `testSuite`, as we now have the `localNodes` array, which we already expose on the `testSuite`. That array contains all the localnodes that we have started for that specific test, no matter if Ganache or Anvil, or several. So we can directly use the localNodes array instead of the specific `ganacheServer` variable. This variable is removed from withFixtures as well, as we handle the ganacheServer in the array. Additionally, I've set the local balance from the page object `check_localNodeBalanceIsDisplayed` to '25 ETH', this way we can omit passing the node in the method, as in most cases that is already the default balance. Only in the case we have another balance (ie. when we have deployed a smart contract, or use a different SRP) we can then pass the localNodes. [](https://codespaces.new/MetaMask/metamask-extension/pull/30536?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
## **Description** Issue: The Beta 3D asset isn't ready yet Solution: Replace all instances of the 3D asset for Beta with the 2D counterpart temporarily until we get the asset [](https://codespaces.new/MetaMask/metamask-extension/pull/30686?quickstart=1) ## **Related issues** Fixes: [#30665](#30665) ## **Manual testing steps** 1. Run `yarn start --build-type beta` 2. Confirm that the 2D beta logo is visible in the following flows 3. Swap Quote flow 4. Create Wallet flow 5. Login ## **Screenshots/Recordings** `ui/pages/onboarding-flow/welcome/welcome.js` | Before | After | |:---:|:---:| ||| `ui/pages/swaps/awaiting-swap/awaiting-swap.js` | Before | After | |:---:|:---:| ||| `ui/pages/swaps/loading-swaps-quotes/loading-swaps-quotes.js` | Before | After | |:---:|:---:| ||| `ui/pages/swaps/mascot-background-animation/mascot-background-animation.js` | Before | After | |:---:|:---:| ||| `ui/pages/unlock-page/unlock-page.component.js` | Before | After | |:---:|:---:| ||| ### **Before** NA ### **After** NA ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/30614?quickstart=1) Fix Caip <> Hex conversion error for network switching event ## **Related issues** Fixes: NA ## **Manual testing steps** 1. Switch from Solana to Ethereum or other EVM network 2. See the error in the logs ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before**  ### **After** The error should not be logged ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: MetaMask Bot <[email protected]>
## **Description** Adding Token Alerts with multichain integration [](https://codespaces.new/MetaMask/metamask-extension/pull/30528?quickstart=1) ## **Related issues** Fixes: [mms-1933](https://consensyssoftware.atlassian.net/browse/MMS-1933) ## **Manual testing steps** 1. Go to bridge 2. Choose for destination a token with alerts 3. See the alert ## **Screenshots/Recordings** https://github.com/user-attachments/assets/3df41f9d-1c72-4b3f-804d-16a521f77a22 ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Updates solana snap to [v1.10.0](https://github.com/MetaMask/snap-solana-wallet/releases) ## **Related issues** Adds: - Update balances post transaction (MetaMask/snap-solana-wallet#208) Fixes: - Account keeps incrementing after rejecting add account (MetaMask/snap-solana-wallet#222) - Loss of precision on transfer amounts (MetaMask/snap-solana-wallet#219) - Solve race condition when simulating transaction in send form (MetaMask/snap-solana-wallet#221) ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
…tworks selected (#30905) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR changes the unintended ticker selector from selected network to transaction meta chain native currency by changing the selector itself. [](https://codespaces.new/MetaMask/metamask-extension/pull/30905?quickstart=1) ## **Related issues** Fixes: #30711 ## **Manual testing steps** Triggering a dapp EVM tx with Solana account selected ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <img width="472" alt="Screenshot 2025-03-11 at 13 59 22" src="https://github.com/user-attachments/assets/433e6998-04ff-46aa-9b59-2e249982ec6f" /> ### **After** <img width="428" alt="Screenshot 2025-03-11 at 13 57 30" src="https://github.com/user-attachments/assets/b60b26c8-1025-4a9b-9a4a-ad2d3a70dda1" /> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
## **Description** Update the transaction confirmation to handle account upgrades via EIP-7702. Specifically: - Add `TransactionAccountDetails` component. - Show new `UpgradeCancelModal` on `Cancel` to provide alternate cancel buttons. - Add `Acknowledge` component with required checkbox in order to `Confirm` transaction. - Add `accountUpgradeDisabledChains` to `PreferencesController` to persist if user rejects upgrade. - Check preference in `getCapabilities` and `processSendCalls` middleware hooks. [](https://codespaces.new/MetaMask/metamask-extension/pull/30347?quickstart=1) ## **Related issues** Fixes: [#4214](MetaMask/MetaMask-planning#4214) ## **Manual testing steps** ## **Screenshots/Recordings** ### **Before** ### **After** <img width="300" alt="Confirmation" src="https://github.com/user-attachments/assets/a61ce2c6-9594-47a6-966e-02cdd493ac29" /> <img width="300" alt="Cancel Modal" src="https://github.com/user-attachments/assets/6a879531-01f8-45cd-afc8-639f78c6a589" /> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Skip these 2 specs to unblock CI as they are constantly failing: - Smart Transactions dApp Transaction - Smart Transactions Swap The issue is because the mock was not correctly set, see slack discussion here: https://consensys.slack.com/archives/CTQAGKY5V/p1741793405288299?thread_ts=1741781685.372319&cid=CTQAGKY5V we need to reactivate them when the mock issue is fixed by this PR: #30932 [](https://codespaces.new/MetaMask/metamask-extension/pull/30939?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Temporarily ignoring babel failure to unblock ci  After:  [](https://codespaces.new/MetaMask/metamask-extension/pull/30946?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Check github action ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
…rk in the installed extension (#30895) ## **Description** Due to: - MegaETH Testnet is not in the list of default network of `NetworkController` - MegaETH Testnet is only available for Extension for now - MegaETH Testnet is not using Infura Therefore, we add the MegaETH Testnet via Extension itself, rather than `NetworkController` default state. This PR is to add a migration script to add the `MegaETH Testnet` for existing user, which the new installed user has already handled by PR #30871 ### **Changes**: - Add a migration script `146` to add the `MegaETH Testnet` for existing user. - Add a hashmap `DEFAULT_CUSTOM_TESTNET_MAP ` to store the custom testnet network list , hence we can share this configuration from `MetamaskController` and `migration`. - While init the state of `NetworkController`, Instead of checking if the networkClientId is `megaeth-testnet` to by pass the block explorer URL assignment, it is better to verify if the networkClientId is in `BlockExplorerUrl` or not. - Update display ticker from `ETH` to `MegaETH`. - Update display name from `MegaETH Testnet` to `Mega Testnet`. [](https://codespaces.new/MetaMask/metamask-extension/pull/30895?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** - Install a version before this commit 5535411 - Setup a new wallet - Click on network menu and show test networks - You should only see Sepolia , Linea Sepolia on test networks section - Then Install the build from this PR - Reload the wallet - Click on network menu (assume the test networks has already visible) - You will see Sepolia , Linea Sepolia and Mega Testnet on test networks section - Click on Mega Testnet - Send a transaction - Check the transaction result in the explorer ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <img width="347" alt="Screenshot 2025-03-07 at 18 17 28" src="https://github.com/user-attachments/assets/1a4a43d5-7797-47f0-a1d5-56ef862a4d98" /> <!-- [screenshots/recordings] --> ### **After** <img width="347" alt="image" src="https://github.com/user-attachments/assets/44b5e1af-df01-45dc-bfc2-d7cbb0046844" /> ## **Pre-merge author checklist** - [X] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [X] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [X] I've included manual testing steps - [X] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [X] I’ve properly set the pull request status: - [X ] In case it's not yet "ready for review", I've set it to "draft". - [] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: David Walsh <[email protected]> Co-authored-by: wantedsystem <[email protected]> Co-authored-by: Salim TOUBAL <[email protected]> Co-authored-by: Micaela Estabillo <[email protected]> Co-authored-by: sahar-fehri <[email protected]>
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** A mock was missing making the specs fail. This also re-enables the specs  [](https://codespaces.new/MetaMask/metamask-extension/pull/30932?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Check ci ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Jongsun Suh <[email protected]>
## **Description** Display nested transaction data in batch transaction confirmations. Specifically: - Add `NestedTransactionData` component. - Replace properties of `useFourByte` hook with `data` and `to`. - Extend `useDecodedTransactionData` hook to support optional `data` and `to` properties. - Extend `TransactionData` component to support optional `data` and `to` properties. - Extend `RecipientRow` to support optional `recipient` property. - Hide root `TransactionData` if nested transactions. [](https://codespaces.new/MetaMask/metamask-extension/pull/30447?quickstart=1) ## **Related issues** Fixes: [#4272](MetaMask/MetaMask-planning#4272) ## **Manual testing steps** ## **Screenshots/Recordings** ### **Before** ### **After** <img width="200" alt="Confirmation" src="https://github.com/user-attachments/assets/82032221-2c8a-45ed-b66f-fd03c0b87329" /> <img width="200" alt="Collapsed" src="https://github.com/user-attachments/assets/0c4d5392-0e58-4fc6-8b15-5c172ea2182e" /> <img width="200" alt="Expanded" src="https://github.com/user-attachments/assets/4ececad9-28ef-444b-95eb-7894d49680de" /> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
…30952) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This adds a 10-minute buffer after the tx estimated completion time, before showing the support/delay banner <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/30952?quickstart=1) ## **Related issues** Fixes: #30325 ## **Manual testing steps** 1. Bridge from Optimism to Arbitrum 2. Open tx details 3. Verify that the delay banner does not show up ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
…nding indefinitely (#30918) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Depends on bridge-api update: consensys-vertical-apps/va-mmcx-bridge-api#182 Addresses these issues - getTxStatus reponses get rejected due to EVM-specific validation - Activity details for bridging from EVM > Solana has missing network info [](https://codespaces.new/MetaMask/metamask-extension/pull/30918?quickstart=1) ## **Related issues** Fixes: #30885 , #30801 ## **Manual testing steps** 1. Bridge EVM <> EVM 2. Bridge EVM <> Solana 3. Bridge Solana <> EVM 4. After 5 mins, verify that there are no failing getTxStatus calls in the background 5. Verify that polling for these new transactions stop eventually ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] -->   ### **After** <!-- [screenshots/recordings] -->   ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Fixes #30900 * Show small amount as `<0.00001` * Move the display logic to a hook <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/30926?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <img width="356" alt="Screenshot 2025-03-12 at 10 01 58" src="https://github.com/user-attachments/assets/adc2f3b9-2466-441e-9e13-7a95c504d63b" /> <img width="358" alt="Screenshot 2025-03-12 at 10 03 32" src="https://github.com/user-attachments/assets/96a82e1f-dc35-445d-bda9-e2e2a2470b63" /> <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Javier <[email protected]> Co-authored-by: javiergarciavera <[email protected]>
## **Description** Following up with this PR to update code fences After this one #30786. The fix was not working on the beta build; so i removed the code fence beta-build and kept only multichain code fence since the multichain feature is already added to the beta build. [](https://codespaces.new/MetaMask/metamask-extension/pull/30935?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
…30511) ## **Description** Decode approvals from nested transaction data and include them in the simulation details. Specifically: - Add `BatchSimulationDetails` component to display simulation details including approvals. - Add `useBatchApproveBalanceChanges` hook to generate balance changes for approvals. - Add optional `staticRows` property to `SimulationDetails` to display additional static data. - Add `parseApprovalTransactionData` function to shared utils to centralise approval data parsing. - Add `buildXTransactionData` helper functions to avoid hardcoding transaction data strings. - Add `isApproval`, `isAllApproval`, and `isUnlimitedApproval` to `BalanceChange` type. - Extend `AmountPill` to support approval styles and handle unlimited and all. - Extend `BalanceChangeRow` to include edit icon if `onEdit` provided in balance change. - Extend `EditSpendingCapModal` to support optional `data` and `to` properties. [](https://codespaces.new/MetaMask/metamask-extension/pull/30511?quickstart=1) ## **Related issues** Fixes [#4283](MetaMask/MetaMask-planning#4283) ## **Manual testing steps** ## **Screenshots/Recordings** ### **Before** ### **After** <img width="200" alt="Confirmation" src="https://github.com/user-attachments/assets/c5fd554a-385c-481d-ba0f-8a9eb9c6d694" /> <img width="200" alt="Edit Modal" src="https://github.com/user-attachments/assets/fdc59615-a595-4079-ac82-2380dd019ef4" /> <img width="200" alt="Storybook" src="https://github.com/user-attachments/assets/f831427c-e479-4b43-ab38-e8bbdbb1fe94" /> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
… are pending requests from origin. (#30674) ## **Description** When switching network alert the user and get approval if there are pending requests from origin. ## **Related issues** Fixes: MetaMask/MetaMask-planning#4269 Fixes: MetaMask/MetaMask-planning#4327 ## **Manual testing steps** 1. Enable EVM multichain locally using env variable `EVM_MULTICHAIN_ENABLED` 2. Submit a confirmation 3. Switch network - ensure a warning appears and pending confirmations are deleted as user confirms the warning ## **Screenshots/Recordings** <img width="363" alt="Screenshot 2025-03-03 at 4 13 03 PM" src="https://github.com/user-attachments/assets/cf3f341a-0f4a-4b6f-97b7-ed5f85a5ccb7" /> ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
…rs.js by moving permissions.js into selectors.js (#30791) Part of #29927 I tried neatly separating them out but it just kept resulting in more and more circular dependencies issues. So here we are just joining two files together. For QA/CS: This PR solves an issue with circular dependencies. _It does not change the behavior of the application._ It only rearranges functions/files to avoid circular references. <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. ## **Description** [](https://codespaces.new/MetaMask/metamask-extension/pull/30791?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. -->
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> > NOTE: E2E test fails appear flaky and unrelated to changes, as evidenced by passing on retry. **_What is the reason for the change?_** Smart Transactions are currently supported on Ethereum Mainnet and BNB Smart Chain, but not on Base. As part of our effort to expand Smart Transactions functionality to more networks, Base needs to be added to the list of supported chains. **_What is the improvement/solution?_** This PR adds Base to the list of supported chains for Smart Transactions in the extension by: - Adding `CHAIN_IDS.BASE` to `ALLOWED_SMART_TRANSACTIONS_CHAIN_IDS_DEVELOPMENT` - Adding `CHAIN_IDS.BASE` to `ALLOWED_SMART_TRANSACTIONS_CHAIN_IDS_PRODUCTION` - Updating tests to include Base in the expected supported chains list These changes allow the extension to recognize Base as a valid network for Smart Transactions, enabling users to benefit from Smart Transactions functionality when interacting with the Base network. I have also updated the `en` locale `stxOptInEthereumBnbDescription` with a new description `stxOptInSupportedNetworksDescription` which states "supported networks" rather than listing networks. [](https://codespaces.new/MetaMask/metamask-extension/pull/30678?quickstart=1) ## **Related issues** Fixes: TXL-687 ## **Manual testing steps** 1. Verify that STX still works correctly on Ethereum Mainnet (see screenshot image) 2. Check that network switching between supported networks maintains proper STX state 3. Ensure STX settings UI correctly displays supported networks 4. Confirm swap transactions with STX enabled complete successfully 5. Verify that STX Description in Advanced Settings is correctly updated (see before/after images) 6. A screenshot shows a successful ETH send tx on Base, processed as a regular transaction (not a Smart Transaction). This confirms: - Base transactions work properly in your wallet - Smart Transactions are not being used for Base (testing a production build where Base commented out) ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <img width="250" alt="ETH2USDC-Swap" src="https://github.com/user-attachments/assets/8a2ec9bc-cebd-474d-ac9b-abd68b52e5d4" /> ### **Before** <!-- [screenshots/recordings] --> <img width="250" alt="after-stx-content" src="https://github.com/user-attachments/assets/55021297-3c77-4da2-8bf3-9261a4cf0556" /> ### **After** <!-- [screenshots/recordings] --> <img width="250" alt="after-stx-content" src="https://github.com/user-attachments/assets/713f41be-9023-47b7-8121-4d4ee9fd45f3" /> <img width="250" alt="SwapBase_Extension" src="https://github.com/user-attachments/assets/9cde205b-d82a-4183-9384-88fa6826dfc3" /> Swap on Ethereum after change: <img width="250" alt="swapETHMainnet_Extension-01" src="https://github.com/user-attachments/assets/8199ae55-0d4b-4c88-bad9-7453ecc439dc" /> <img width="250" alt="swapETHMainnet_Extension02" src="https://github.com/user-attachments/assets/f160a551-3b60-4872-aba3-647cbc8e2d0e" /> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
…I e2e tests from firefox e2e test runs (#30937) All of the[ multichain API tests are currently failing on firefox in CI](https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/129633/workflows/971003c4-a97a-443b-8baf-3f4e11872528/jobs/4630272/tests). This is expected because the Multichain API is not currently supported on firefox. This PR adds a `describeChromeOnly` helper function to conditionally skip these tests in non-chrome environments - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
## **Description** Migrate the locales-only workflow to GitHub Actions [](https://codespaces.new/MetaMask/metamask-extension/pull/30898?quickstart=1) ## **Related issues** Fixes: #30787 <!--## **Manual testing steps** ## **Screenshots/Recordings** ## **Pre-merge author checklist** ## **Pre-merge reviewer checklist**--> --------- Co-authored-by: Norbert Elter <[email protected]>
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Reference latest shared workflows for create release [](https://codespaces.new/MetaMask/metamask-extension/pull/30979?quickstart=1) ## **Related issues** Fixes: Release Automation Updates ## **Manual testing steps** CI/CD Testing Only ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> N/A - CICD Only ### **After** <!-- [screenshots/recordings] --> N/A - CICD Only ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
…tedPercentageOverview (#30876) ## **Description** Fixes console warnings for these two components by providing required dependencies [](https://codespaces.new/MetaMask/metamask-extension/pull/30876?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Ensure both components display accurate information 2. Don't see warnings in console. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
## **Description** Set a default token populated when going to the swap page [](https://codespaces.new/MetaMask/metamask-extension/pull/30929?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to the swap page 2. Check token populated ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** ### **After** https://github.com/user-attachments/assets/6e2b43ad-bad5-4c36-9869-54b3b26b2040 ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
…yml (#30977) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> build-beta.yml had hard coded or missing values for 3 env vars that caused the generated builds to not work properly. This PR corrects that. ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR allows the user to add an account to a specific srp. Depends on #30598 <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/30604?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** **Creating an account for a specific SRP** 1. Import a new SRP 2. Click on add new account 3. Select the SRP you want to create the account to. 4. See a new account is created ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** Creating accounts associated to an srp https://github.com/user-attachments/assets/c8b0d197-18d2-4695-ae8b-0d84b4926da3 ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Charly Chevalier <[email protected]>
## **Description** Prevents re-renders of the receive modal due to passing a likewise but different object. [](https://codespaces.new/MetaMask/metamask-extension/pull/30881?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Ensure correct address shows up when scanning QR code. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. Co-authored-by: Nick Gambino <[email protected]>
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/31002?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: MetaMask Bot <[email protected]> Co-authored-by: Marina Boboc <[email protected]> Co-authored-by: António Regadas <[email protected]> Co-authored-by: Maarten Zuidhoorn <[email protected]> Co-authored-by: infiniteflower <[email protected]> Co-authored-by: Micaela Estabillo <[email protected]> Co-authored-by: Sébastien Van Eyck <[email protected]> Co-authored-by: Xiaoming Wang <[email protected]> Co-authored-by: Pedro Figueiredo <[email protected]> Co-authored-by: MetaMask Bot <[email protected]> Co-authored-by: Matthew Walsh <[email protected]> Co-authored-by: Nidhi Kumari <[email protected]> Co-authored-by: Derek Brans <[email protected]> Co-authored-by: Charly Chevalier <[email protected]> Co-authored-by: Eric Bishard <[email protected]> Co-authored-by: Ramon Acitores <[email protected]> Co-authored-by: OGPoyraz <[email protected]> Co-authored-by: Harika <[email protected]> Co-authored-by: Matteo Scurati <[email protected]> Co-authored-by: Bryan Fullam <[email protected]> Co-authored-by: David Walsh <[email protected]> Co-authored-by: Salim TOUBAL <[email protected]> Co-authored-by: Prithpal Sooriya <[email protected]> Co-authored-by: Alex Donesky <[email protected]> Co-authored-by: jiexi <[email protected]> Co-authored-by: sahar-fehri <[email protected]> Co-authored-by: seaona <[email protected]> Co-authored-by: ffmcgee <[email protected]> Co-authored-by: Daniel <[email protected]> Co-authored-by: runway-github[bot] <73448015+runway-github[bot]@users.noreply.github.com> Co-authored-by: Xiaoming Wang <[email protected]> Co-authored-by: dddddanica <[email protected]> Co-authored-by: Norbert Elter <[email protected]> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: Mathieu Artu <[email protected]> Co-authored-by: Mark Stacey <[email protected]> Co-authored-by: seaona <[email protected]> Co-authored-by: Nick Gambino <[email protected]> Co-authored-by: Vince Howard <[email protected]> Co-authored-by: Howard Braham <[email protected]> Co-authored-by: Hassan Malik <[email protected]> Co-authored-by: Frederik Bolding <[email protected]>
* origin/master: (49 commits) Update Attributions chore: Remove beta heading from v12.14.0 changelog (#31008) chore: Add v12.14.0 changelog entries (#30985) chore: v12.14.0 revert commit (#30996) Revert "chore: v12.14.0 master merge (#30989)" chore: v12.14.0 master merge (#30989) chore: v12.14.0 revert commit (#30990) chore: v12.14.0 master merge (#30988) fix: mms-2049 solana slipagge (#30760) (#30981) chore: v12.14.0-rc changelog (#30980) chore(runway): cherry-pick fix: cp-12.14.0 duplicate dest assets visible in bridge page (#30914) chore(runway): cherry-pick fix: cp-12.14.0 set automatic slippage for swap transactions (#30915) chore(runway): cherry-pick fix: cp-12.14.0 bridge status validation causes transactions to be pending indefinitely (#30953) fix: fix code fencing for beta build (#30935) (#30963) cherry-pick: "fix: multichain transactions display (#30926)" (#30962) Cherry pick 12.14.0 megaeth testnet (#30951) fix: cp-12.14.0 use networkClientId if included in transaction (#30758) (#30948) fix: cp-12.14.0 CAIP chain ids are not parsed to Hex correctly (#30913) chore: cp-12.14.0 (#30946, #30932) (#30950) chore(runway): cherry-pick fix: cp-12.14.0 (MMS-2061) prompt user to create solana acct in bridge flow if selected tochain and no account (#30923) ...
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
](https://codespaces.new/MetaMask/metamask-extension/pull/30613?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30616?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30615?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30574?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30600?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30619?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30622?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30618?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30552?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30631?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30640?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30644?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30591?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30680?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30042?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30148?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30486?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/29979?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30671?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30515?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30536?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30686?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30614?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30528?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30905?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30347?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30939?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30946?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30895?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30932?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30447?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30952?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30918?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30926?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30935?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30511?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30791?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30678?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30898?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30979?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30876?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30929?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30604?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/30881?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/31002?quickstart=1){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist