Dry address comparison #31750
Open
Dry address comparison #31750
+74
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨🖥️ @MetaMask/wallet-ux
|
jiexi
force-pushed
the
jl/sip-26/dry-address-comparison
branch
from
1e81837 to
99d48d0
Compare
adonesky1
reviewed
Apr 14, 2025
Comment on lines
+120
to
+127
| * Checks if an CAIP account ID is connected to any of the permitted accounts | ||
| * based on scope matching | ||
| * | ||
| * @param accountId - The CAIP account ID to check against permitted accounts | ||
| * @param permittedAccounts - Array of CAIP account IDs that are permitted | ||
| * @returns True if the account is connected to any permitted account | ||
| */ | ||
| export function isAccountIdInPermittedAccountIds( |
There was a problem hiding this comment.
I think the key thing to highlight about this function is that the "permittedAccounts" will contain 0 as references, which is why we can't just do a simple includes() check?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist