Skip to content

WIP: refactor notification state listener logic #32132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jiexi
Copy link
Contributor

@jiexi jiexi commented Apr 18, 2025

Description

Moves beefy state listeners that handle eth subscriptions and solana accountChange events into separate files

Open in GitHub Codespaces

Related issues

See: https://github.com/orgs/MetaMask/projects/146/views/6?pane=issue&itemId=105350449&issue=MetaMask%7CMetaMask-planning%7C4599

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [8e61003]
UI Startup Metrics (1203 ± 62 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1203108114576212321317
load103793911745210711150
domContentLoaded103192811695110641144
domInteractive17146161627
firstPaint73876115540010491123
backgroundConnect74152811
firstReactRender22165172237
getState1353782030
initialActions001001
loadScripts79570893050824890
setupStore85233814
WebpackHomeuiStartup21061722257617422262386
load16261351196813517341818
domContentLoaded16201348195813417281814
domInteractive15115391341
firstPaint1836434464237321
backgroundConnect24981142459
firstReactRender20354401122333370
getState174264331436
initialActions317135
loadScripts16151343193413417251812
setupStore216300372030
FirefoxBrowserifyHomeuiStartup13531192170710314031539
load12071006158410712731400
domContentLoaded12071006158410712711400
domInteractive1143634856123253
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect1913103102025
firstReactRender22195452230
getState7424279
initialActions001001
loadScripts1189993157110712571385
setupStore1041952568
WebpackHomeuiStartup14891319206312315411735
load12791140178511413261513
domContentLoaded12781140178511413261512
domInteractive81371662595135
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2213285272030
firstReactRender34275343641
getState8473789
initialActions002111
loadScripts12581127176811113061484
setupStore7514189
cc: @HowardBraham
Benchmark value 183 exceeds gate value 175 for chrome webpack home mean firstPaint
Benchmark value 322 exceeds gate value 310 for chrome webpack home p95 firstPaint
Benchmark value 114 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 253 exceeds gate value 195 for firefox browserify home p95 domInteractive
Sum of mean exceeds: 13ms | Sum of p95 exceeds: 70ms
Sum of all benchmark exceeds: 83ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 3.94 KiB (0.07%)
  • ui: 8 Bytes (0%)
  • common: -481 Bytes (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants