-
Notifications
You must be signed in to change notification settings - Fork 5.2k
test: test withKeyring for readonly ops #32414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ccharly
wants to merge
1
commit into
main
Choose a base branch
from
test/with-keyring
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Merged
4 tasks
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
597464e
to
951ed90
Compare
Builds ready [48f2a59]
UI Startup Metrics (1244 ± 71 ms)
Benchmark value 1079 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1072 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 831 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1369 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 20 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 1481 exceeds gate value 1475 for firefox browserify home p95 loadScripts Sum of mean exceeds: 32ms | Sum of p95 exceeds: 12ms Sum of all benchmark exceeds: 44ms |
ccharly
added a commit
to MetaMask/core
that referenced
this pull request
May 5, 2025
…withKeyring` (#5732) ## Explanation We were always calling `#updateVault` when using `withKeyring` even when the keyring was not mutated. This PR now compare the states after the operation execution and see if the keyring got updated or not and decide to call `#updateVault` only if needed. Testing PR: - MetaMask/metamask-extension#32414 ## References N/A ## Changelog N/A ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs), highlighting breaking changes as necessary - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes --------- Co-authored-by: Michele Esposito <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing:
:stageChange
inwithKeyring
core#5732Related issues
N/A
Manual testing steps
N/A
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist