Skip to content

chore: Move Multichain API + Solana Wallet Standard tests out of flask/ directory #32473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adonesky1
Copy link
Contributor

@adonesky1 adonesky1 commented May 2, 2025

Blocked by #32284

Description

Now that the Multichain API (and Solana support) are available on stable builds, we should move the Multichain API + Solana Wallet Standard tests to run on non flask builds.

Open in GitHub Codespaces

Copy link
Contributor

github-actions bot commented May 2, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@adonesky1 adonesky1 changed the title move Multichain API tests out of flask/ directory chore: Move Multichain API + Solana Wallet Standard tests out of flask/ directory May 2, 2025
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label May 2, 2025
@adonesky1 adonesky1 force-pushed the ad/move-multichain-api-tests branch from 1c32c0b to 1907872 Compare May 2, 2025 16:48
@metamaskbot
Copy link
Collaborator

Builds ready [1907872]
UI Startup Metrics (1206 ± 69 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1206109514506912371343
load104894212686610801178
domContentLoaded104293912506510751173
domInteractive17136581629
firstPaint784144125939310561181
backgroundConnect74182710
firstReactRender21154662140
getState14592112027
initialActions001001
loadScripts806713101162834935
setupStore74182710
WebpackHomeuiStartup21161695253519022402393
load16431309207715317651862
domContentLoaded16361305206515217601854
domInteractive15115291341
firstPaint1766269381215299
backgroundConnect339285413362
firstReactRender20355383118307359
getState1246881527
initialActions317145
loadScripts16311304204115117561852
setupStore186156162235
FirefoxBrowserifyHomeuiStartup13771216173810314361626
load12241068158310412871418
domContentLoaded12241067158310412861418
domInteractive1033720425116140
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2213234232038
firstReactRender22203222327
getState9418018819
initialActions0029301
loadScripts12041053156910412601404
setupStore6423269
WebpackHomeuiStartup15021356200911915601753
load12901169174011013331529
domContentLoaded12901168173911013331528
domInteractive79431892088119
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect20144652330
firstReactRender34285753644
getState94356829
initialActions002111
loadScripts12721152172210913161484
setupStore85305814
Benchmark value 1181 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Sum of mean exceeds: 0ms | Sum of p95 exceeds: 1ms
Sum of all benchmark exceeds: 1ms

Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template team-wallet-api-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants