fix: discard duplicate accounts on unlock

[mikesposito]

Description

Dependent on:

• fix: remove metadata for unsupported keyrings core#5725
• fix: discard duplicate accounts on unlock core#5775

Updating @metamask/keyring-controller with these fixes:

### Fixed

- Discard keyrings with duplicate accounts when unlock the wallet ([#5775](https://github.com/MetaMask/core/pull/5775))
- Metadata for unsupported keyring is removed on unlock ([#5725](https://github.com/MetaMask/core/pull/5725))

Related issues

Fixes:

Manual testing steps

1. Add duplicate to the wallet state

1.1. Switch to the v11.7.3 branch, build locally, and install the extension from chrome://extensions
1.2. Onboard with an SRP of which we know the second account (child guilt hollow arrive average popular nasty soon summer like scheme diary pill country rapid)
1.3. Import an account that is part of the mnemonic ( 0x80842b7e3cfb1118e86a427cdec418e3b4179ef5bbbfd71c02a76349831c8a8b which is the account at index 2 of the above SRP)
1.4. Add a new account on the main HD
1.5. Switch to Version-v12.17.1 branch, and refresh the extension in chrome://extensions
1.6. Unlock the wallet, you should see duplicates in your accounts list and you won't be able to add new accounts

2. Test the fix

2.1. Switch to this branch, build locally, and refresh the extension in chrome://extensions
2.2 Unlock the wallet, you shouldn't see duplicate accounts anymore, and you should be able to add new accounts

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@​metamask/​keyring-controller@​21.0.5 ⏵ 21.0.6			+1	+1

View full report

[socket-security]

Caution

Review the following alerts detected in dependencies.

According to your organization's Security Policy, you must resolve all "Block" alerts before proceeding. Learn more about Socket for GitHub.

Action	Severity	Alert (click for details)
Block		[email protected] has Native code. Location: Package overview From: ? → npm/[email protected] → npm/[email protected] → npm/[email protected] → npm/[email protected] → npm/@metamask/[email protected] → npm/[email protected] ℹ Read more on: This package | This alert | Why is native code a concern? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected]. Suggestion: Verify that the inclusion of native code is expected and necessary for this package's functionality. If it is unnecessary or unexpected, consider using alternative packages without native code to mitigate potential risks. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Block		[email protected] has a New author. New Author: perrymitchell Previous Author: alizain From: ? → npm/@metamask/[email protected] → npm/[email protected] ℹ Read more on: This package | This alert | What is new author? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected]. Suggestion: Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

[metamaskbot]

✨ Files requiring CODEOWNER review ✨

🧩 @MetaMask/extension-devs

• lavamoat/browserify/beta/policy.json
• lavamoat/browserify/flask/policy.json
• lavamoat/browserify/main/policy.json
• lavamoat/browserify/mmi/policy.json

📜 @MetaMask/policy-reviewers

• lavamoat/browserify/beta/policy.json
• lavamoat/browserify/flask/policy.json
• lavamoat/browserify/main/policy.json
• lavamoat/browserify/mmi/policy.json

🔗 @MetaMask/supply-chain

• lavamoat/browserify/beta/policy.json
• lavamoat/browserify/flask/policy.json
• lavamoat/browserify/main/policy.json
• lavamoat/browserify/mmi/policy.json

🖥️ @MetaMask/wallet-ux

• ui/components/multichain/account-details/account-details.tsx
• ui/components/multichain/account-list-menu/account-list-menu.test.tsx
• ui/components/multichain/edit-accounts-modal/edit-accounts-modal.test.tsx
• ui/components/multichain/multi-srp/srp-list/srp-list.test.tsx

[metamaskbot]

Builds ready [a12ebda]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all CircleCI artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1231 ± 67 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1231	1083	1417	67	1271	1355
			load	1074	967	1232	59	1128	1179
			domContentLoaded	1068	964	1211	58	1122	1169
			domInteractive	17	13	43	5	17	25
			firstPaint	791	147	1218	407	1094	1172
			backgroundConnect	7	4	31	4	7	12
			firstReactRender	20	15	37	4	21	29
			getState	14	6	44	8	19	31
			initialActions	0	0	1	0	0	0
			loadScripts	826	719	962	56	873	926
			setupStore	8	4	24	3	9	15
	Webpack	Home	uiStartup	2152	1737	2587	189	2294	2415
			load	1678	1248	2033	150	1767	1882
			domContentLoaded	1671	1243	2022	150	1759	1871
			domInteractive	16	11	64	11	13	51
			firstPaint	165	62	412	69	174	338
			backgroundConnect	34	10	441	54	33	57
			firstReactRender	146	54	351	95	192	333
			getState	14	4	190	20	16	30
			initialActions	3	1	7	1	3	4
			loadScripts	1666	1237	2017	150	1754	1857
			setupStore	24	7	280	38	21	50
Firefox	Browserify	Home	uiStartup	1365	1149	1761	112	1429	1594
			load	1218	1025	1537	103	1280	1426
			domContentLoaded	1217	1025	1537	103	1280	1426
			domInteractive	102	39	242	32	113	165
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	12	178	18	20	48
			firstReactRender	23	19	58	7	22	44
			getState	8	4	30	4	8	19
			initialActions	0	0	1	0	0	1
			loadScripts	1199	1016	1523	101	1261	1408
			setupStore	9	4	203	26	6	8
	Webpack	Home	uiStartup	1588	1392	2136	156	1687	1929
			load	1361	1200	1855	141	1442	1664
			domContentLoaded	1361	1200	1855	141	1442	1664
			domInteractive	84	43	396	37	90	130
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	16	48	6	24	41
			firstReactRender	36	29	63	5	39	45
			getState	13	5	270	27	10	31
			initialActions	1	0	2	1	1	1
			loadScripts	1341	1182	1835	141	1422	1641
			setupStore	10	5	180	17	9	12

Benchmark value 1075 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1068 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 339 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1664 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1664 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1641 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 13ms | Sum of p95 exceeds: 24ms
Sum of all benchmark exceeds: 37ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 0 Bytes (0%)
• ui: 0 Bytes (0%)
• common: 417 Bytes (0%)

[metamaskbot]

Builds ready [7a8160e]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all CircleCI artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1196 ± 56 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1196	1072	1339	56	1229	1303
			load	1044	942	1155	50	1080	1139
			domContentLoaded	1037	937	1149	51	1072	1132
			domInteractive	16	13	46	4	16	24
			firstPaint	790	135	1169	389	1063	1136
			backgroundConnect	8	4	28	5	7	22
			firstReactRender	19	15	39	4	19	31
			getState	13	5	39	8	18	28
			initialActions	0	0	1	0	0	1
			loadScripts	797	707	903	48	826	883
			setupStore	7	5	20	2	8	12
	Webpack	Home	uiStartup	2186	1732	2530	187	2330	2419
			load	1710	1345	2283	156	1792	1923
			domContentLoaded	1704	1340	2272	155	1787	1917
			domInteractive	16	11	70	10	13	44
			firstPaint	157	63	395	54	180	259
			backgroundConnect	30	10	236	31	32	51
			firstReactRender	162	55	383	112	294	351
			getState	14	4	250	25	15	24
			initialActions	6	1	348	34	3	5
			loadScripts	1699	1336	2270	155	1782	1908
			setupStore	28	6	272	48	20	175
Firefox	Browserify	Home	uiStartup	1342	1139	1692	112	1389	1600
			load	1197	1017	1571	104	1241	1397
			domContentLoaded	1197	1017	1571	104	1241	1397
			domInteractive	98	36	186	25	105	155
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	14	213	20	21	36
			firstReactRender	24	20	59	7	23	43
			getState	11	4	234	29	8	10
			initialActions	0	0	1	0	0	1
			loadScripts	1177	1004	1555	103	1218	1376
			setupStore	6	4	26	3	6	11
	Webpack	Home	uiStartup	1530	1369	1902	130	1618	1795
			load	1311	1178	1653	114	1370	1558
			domContentLoaded	1311	1178	1652	114	1369	1557
			domInteractive	78	54	170	16	84	110
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	15	51	7	23	41
			firstReactRender	35	28	49	5	38	43
			getState	10	5	45	6	10	28
			initialActions	0	0	2	1	1	1
			loadScripts	1292	1154	1632	114	1349	1539
			setupStore	14	5	312	42	8	28

Benchmark value 23 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 175 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore
Sum of mean exceeds: 3ms | Sum of p95 exceeds: 115ms
Sum of all benchmark exceeds: 118ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: -110 Bytes (0%)
• ui: 0 Bytes (0%)
• common: 474 Bytes (0%)

[metamaskbot]

Builds ready [ca12a89]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all CircleCI artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1208 ± 69 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1208	1085	1628	69	1248	1307
			load	1058	953	1364	58	1091	1149
			domContentLoaded	1051	951	1353	58	1085	1141
			domInteractive	16	13	45	4	17	25
			firstPaint	785	93	1359	406	1080	1146
			backgroundConnect	8	3	40	5	7	22
			firstReactRender	19	15	47	5	20	32
			getState	13	5	35	8	19	29
			initialActions	0	0	1	0	0	1
			loadScripts	808	712	1058	55	842	894
			setupStore	7	4	19	2	7	12
	Webpack	Home	uiStartup	2148	1725	2597	176	2271	2438
			load	1685	1306	2036	137	1774	1918
			domContentLoaded	1678	1302	2027	136	1770	1906
			domInteractive	16	11	55	10	13	45
			firstPaint	166	64	358	58	189	274
			backgroundConnect	32	10	263	37	30	75
			firstReactRender	147	43	353	108	281	339
			getState	11	4	46	7	13	29
			initialActions	5	1	226	22	3	4
			loadScripts	1674	1300	2004	134	1769	1881
			setupStore	17	6	249	24	19	32
Firefox	Browserify	Home	uiStartup	1419	1205	1785	123	1503	1669
			load	1254	1084	1597	111	1330	1464
			domContentLoaded	1254	1083	1597	111	1330	1463
			domInteractive	106	37	289	33	120	155
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	13	135	20	23	55
			firstReactRender	25	20	59	8	25	53
			getState	15	5	214	35	9	31
			initialActions	0	0	1	0	0	1
			loadScripts	1233	1070	1583	107	1308	1432
			setupStore	7	4	37	4	7	9
	Webpack	Home	uiStartup	1601	1398	2287	161	1657	1887
			load	1374	1182	1979	146	1439	1645
			domContentLoaded	1373	1182	1978	146	1439	1644
			domInteractive	79	38	141	18	87	118
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	16	71	8	25	38
			firstReactRender	36	30	56	5	39	44
			getState	11	4	104	12	10	29
			initialActions	0	0	2	1	1	1
			loadScripts	1353	1167	1960	145	1421	1629
			setupStore	8	5	28	4	8	20

Benchmark value 22 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 1420 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1255 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1255 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 15 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 1234 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 1669 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 31 exceeds gate value 24 for firefox browserify home p95 getState
Sum of mean exceeds: 50ms | Sum of p95 exceeds: 20ms
Sum of all benchmark exceeds: 70ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: -22.11 KiB (-0.41%)
• ui: 6.43 KiB (0.09%)
• common: 26.86 KiB (0.29%)