test: EIP-5792 methods on Multichain API #33077

wenfix · 2025-05-20T14:52:15Z

Description

We want to ensure there is support for calling EIP-5792 methods via the Multichain API. Adds E2E tests for it.

Related issues

https://github.com/MetaMask/MetaMask-planning/issues/4784

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…refactor' into jl/adopt-sip-26-post-merge-core-refactor

…cunt

socket-security · 2025-05-20T14:54:15Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Package	Supply Chain Security	Quality	Maintenance	License
@metamask/multichain-api-middleware@0.1.1 ⏵ 0.3.0	⁺¹	⁺¹
@metamask/chain-agnostic-permission@0.2.0 ⏵ 0.7.0	⁺¹	⁺¹	⁺¹
@metamask/test-dapp-multichain@0.10.0 ⏵ 0.12.0	⁺²	⁺¹	⁺²	^-50
@metamask/api-specs@0.10.15 ⏵ 0.14.0	⁺¹	⁺¹

View full report

wenfix · 2025-05-20T14:57:43Z

app/scripts/lib/rpc-method-middleware/handlers/wallet-createSession/handler.ts

@@ -11,7 +11,7 @@ import {
  NormalizedScopesObject,
  getSupportedScopeObjects,
  Caip25CaveatValue,
-  setPermittedAccounts,
+  setNonSCACaipAccountIdsInCaip25CaveatValue


This change is unrelated but required due to breaking changes on the @metamask/[email protected] package that went into this. Diff should go away after #32152 is merged.

metamaskbot · 2025-05-20T15:06:00Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2025-05-20T15:08:22Z

✨ Files requiring CODEOWNER review ✨

🧩 @MetaMask/extension-devs

lavamoat/browserify/beta/policy.json
lavamoat/browserify/flask/policy.json
lavamoat/browserify/main/policy.json
lavamoat/browserify/mmi/policy.json

📜 @MetaMask/policy-reviewers

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.

lavamoat/browserify/beta/policy.json
lavamoat/browserify/flask/policy.json
lavamoat/browserify/main/policy.json
lavamoat/browserify/mmi/policy.json

🔗 @MetaMask/supply-chain

lavamoat/browserify/beta/policy.json
lavamoat/browserify/flask/policy.json
lavamoat/browserify/main/policy.json
lavamoat/browserify/mmi/policy.json

adonesky1 · 2025-05-21T14:49:05Z

test/e2e/flask/multichain-api/wallet_invokeMethod.spec.ts

@@ -1,4 +1,6 @@
+/* eslint-disable prettier/prettier */


why is this disable necessary?

it's not, must've been a fat finger 😅

…middleware and @metamask/test-dapp-multichain versions

…ichain API

wenfix · 2025-05-21T15:25:59Z

@metamaskbot update-policies

metamaskbot · 2025-05-21T15:40:59Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2025-05-21T16:16:39Z

Builds ready [329f6ba]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1187 ± 64 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1187	1070	1593	64	1213	1278
			load	1021	899	1436	62	1046	1104
			domContentLoaded	1013	892	1427	63	1041	1096
			domInteractive	16	13	34	3	16	24
			firstPaint	797	138	1437	373	1038	1092
			backgroundConnect	9	4	33	6	8	25
			firstReactRender	20	15	47	6	20	35
			getState	14	5	52	8	20	30
			initialActions	0	0	1	0	0	1
			loadScripts	775	652	1176	62	801	851
			setupStore	8	4	33	4	8	17
	Webpack	Home	uiStartup	2162	1732	2753	218	2300	2508
			load	1668	1354	1951	154	1765	1896
			domContentLoaded	1660	1350	1938	152	1760	1883
			domInteractive	16	12	58	10	13	46
			firstPaint	155	68	350	51	171	265
			backgroundConnect	27	10	249	26	29	51
			firstReactRender	169	42	375	116	309	332
			getState	19	5	303	41	14	39
			initialActions	3	1	8	1	4	5
			loadScripts	1656	1348	1925	151	1756	1871
			setupStore	38	6	304	70	23	279
Firefox	Browserify	Home	uiStartup	1312	1134	1771	134	1333	1623
			load	1160	992	1568	118	1200	1437
			domContentLoaded	1160	992	1568	118	1199	1437
			domInteractive	95	39	265	31	102	158
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	19	13	58	8	20	40
			firstReactRender	23	20	50	4	23	28
			getState	11	4	203	26	8	13
			initialActions	0	0	5	1	0	1
			loadScripts	1144	979	1554	117	1185	1420
			setupStore	9	4	339	33	6	11
	Webpack	Home	uiStartup	1588	1372	2344	165	1664	1905
			load	1368	1186	1934	143	1441	1676
			domContentLoaded	1368	1186	1934	143	1441	1676
			domInteractive	80	56	256	23	86	124
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	15	71	10	24	45
			firstReactRender	39	26	54	5	42	48
			getState	14	5	237	32	10	30
			initialActions	1	0	2	1	1	1
			loadScripts	1348	1172	1911	143	1421	1657
			setupStore	9	5	93	10	8	22

Benchmark value 25 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 39 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2508 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 279 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 39 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1676 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1676 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1657 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 9ms | Sum of p95 exceeds: 334ms
Sum of all benchmark exceeds: 343ms

wenfix · 2025-05-21T16:24:18Z

@metamaskbot update-policies

metamaskbot · 2025-05-21T16:38:57Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2025-05-21T17:12:49Z

Builds ready [93b1c7a]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1189 ± 59 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1189	1075	1409	59	1229	1284
			load	1026	919	1186	55	1072	1107
			domContentLoaded	1019	915	1182	56	1064	1100
			domInteractive	16	13	55	5	15	24
			firstPaint	774	91	1188	387	1045	1105
			backgroundConnect	8	4	35	6	8	26
			firstReactRender	21	15	54	7	21	39
			getState	12	5	27	7	18	26
			initialActions	0	0	1	0	0	1
			loadScripts	782	681	930	55	832	859
			setupStore	8	4	31	4	8	13
	Webpack	Home	uiStartup	2287	1712	2716	197	2413	2611
			load	1773	1351	2206	168	1889	2046
			domContentLoaded	1763	1347	2200	164	1884	2012
			domInteractive	16	12	54	8	14	41
			firstPaint	170	68	687	77	181	314
			backgroundConnect	36	11	351	48	37	61
			firstReactRender	181	44	365	119	313	352
			getState	18	5	276	27	20	36
			initialActions	3	1	8	1	4	7
			loadScripts	1759	1345	2198	163	1881	2009
			setupStore	40	7	310	70	28	282
Firefox	Browserify	Home	uiStartup	1303	1132	1820	138	1337	1577
			load	1159	987	1675	134	1216	1439
			domContentLoaded	1159	986	1675	134	1216	1438
			domInteractive	93	38	177	25	101	156
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	19	13	58	7	20	31
			firstReactRender	24	20	56	6	23	33
			getState	8	4	62	7	8	10
			initialActions	0	0	1	0	0	1
			loadScripts	1142	972	1660	132	1179	1414
			setupStore	7	4	71	8	6	11
	Webpack	Home	uiStartup	1576	1340	2108	142	1683	1803
			load	1370	1157	1895	135	1485	1607
			domContentLoaded	1370	1157	1894	135	1484	1607
			domInteractive	79	42	146	19	85	127
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	15	52	6	23	35
			firstReactRender	38	28	51	5	41	45
			getState	11	5	240	23	9	28
			initialActions	1	0	2	1	1	1
			loadScripts	1351	1141	1879	136	1465	1578
			setupStore	8	5	28	4	8	12

cc: @HowardBraham
Benchmark value 26 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 2288 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1773 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1763 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 1759 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 40 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2611 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2046 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2012 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 2009 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 282 exceeds gate value 65 for chrome webpack home p95 setupStore
Sum of mean exceeds: 285ms | Sum of p95 exceeds: 444ms
Sum of all benchmark exceeds: 729ms

jiexi added 30 commits April 21, 2025 11:44

delete inlined

ee1d790

use preview build 634cc823

da393fb

replace imports

23612f9

use preview build c76a33e4

b10942f

lint

bb48c8f

Merge branch 'main' into jl/adopt-sip-26-post-merge-core-refactor

7f2728b

fix breaking renames

7e5c734

fix breaking renames

65be89c

DRY permission page account comparison

ecd2b24

Merge remote-tracking branch 'origin/jl/adopt-sip-26-post-merge-core-…

246bb9d

…refactor' into jl/adopt-sip-26-post-merge-core-refactor

use preview build 90695ddf

c42a9ce

Merge branch 'main' into jl/adopt-sip-26-post-merge-core-refactor

86d3492

fix bad import

e0701a0

use preview build 363db98c

bf64354

use preview build 514219da

1c1af1e

use preview build 514219da

e410093

fix renamed import

12c46ab

fix isInternalAccountInPermittedAccountIds called without internalAco…

1e6c8b6

…cunt

fix fixtures

e1efe73

storybook

79a0d1d

storybook

110605a

fix send test

0f79030

use preview build

44631c8

storybook

d8d5a26

unit test

51242f7

try guarding against undefined account

f6222bd

unit test

5ce3c8f

fix spec

6b54b30

bump to 0.5.0

8663889

Merge branch 'main' into jl/adopt-sip-26-post-merge-core-refactor

bc81eee

wenfix commented May 20, 2025

View reviewed changes

Merge branch 'main' into jl/adopt-sip-26-post-merge-core-refactor

c9937c4

adonesky1 reviewed May 21, 2025

View reviewed changes

wenfix marked this pull request as ready for review May 21, 2025 14:53

wenfix requested review from a team as code owners May 21, 2025 14:53

wenfix and others added 6 commits May 21, 2025 17:03

update @metamask/chain-agnostic-permission, @metamask/multichain-api-…

713982f

…middleware and @metamask/test-dapp-multichain versions

add wallet_sendCalls and wallet_getCapabilities test for the mult…

67e0d0d

…ichain API

Update LavaMoat policies

dcc3551

add wallet_getCallsStatus test

413ebfe

fix lint issues

f50e881

remove unnecessary disable eslint

6cb35c8

wenfix force-pushed the am/multichain-eip5792-methods-test branch from 3778f97 to 6cb35c8 Compare May 21, 2025 15:15

wenfix requested review from a team as code owners May 21, 2025 15:15

wenfix changed the base branch from main to jl/adopt-sip-26-post-merge-core-refactor May 21, 2025 15:26

Update LavaMoat policies

329f6ba

dedupe dependencies

df0eb7a

Update LavaMoat policies

93b1c7a

Base automatically changed from jl/adopt-sip-26-post-merge-core-refactor to main May 21, 2025 18:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test: EIP-5792 methods on Multichain API #33077

test: EIP-5792 methods on Multichain API #33077

wenfix commented May 20, 2025 •

edited by github-actions bot

Loading

Uh oh!

socket-security bot commented May 20, 2025 •

edited

Loading

Uh oh!

wenfix May 20, 2025

Uh oh!

metamaskbot commented May 20, 2025

Uh oh!

metamaskbot commented May 20, 2025 •

edited

Loading

Uh oh!

adonesky1 May 21, 2025

Uh oh!

wenfix May 21, 2025

Uh oh!

wenfix commented May 21, 2025

Uh oh!

metamaskbot commented May 21, 2025

Uh oh!

metamaskbot commented May 21, 2025

Uh oh!

wenfix commented May 21, 2025

Uh oh!

metamaskbot commented May 21, 2025

Uh oh!

metamaskbot commented May 21, 2025

Uh oh!

Uh oh!

test: EIP-5792 methods on Multichain API #33077

Are you sure you want to change the base?

test: EIP-5792 methods on Multichain API #33077

Conversation

wenfix commented May 20, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

socket-security bot commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wenfix May 20, 2025

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented May 20, 2025

Uh oh!

metamaskbot commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

adonesky1 May 21, 2025

Choose a reason for hiding this comment

Uh oh!

wenfix May 21, 2025

Choose a reason for hiding this comment

Uh oh!

wenfix commented May 21, 2025

Uh oh!

metamaskbot commented May 21, 2025

Uh oh!

metamaskbot commented May 21, 2025

Uh oh!

wenfix commented May 21, 2025

Uh oh!

metamaskbot commented May 21, 2025

Uh oh!

metamaskbot commented May 21, 2025

Uh oh!

Uh oh!

wenfix commented May 20, 2025 •

edited by github-actions bot

Loading

socket-security bot commented May 20, 2025 •

edited

Loading

metamaskbot commented May 20, 2025 •

edited

Loading