fix: dapp receiving two accountsChanged and wallet_sessionChanged events when adding and removing accounts/chainIds in the same edit action #33082

jiexi · 2025-05-20T18:30:09Z

Description

This PR adds and uses setPermittedChains and setPermittedAccounts helpers in the ReviewPermissionsPage, replacing usage of addPermittedAccounts, removePermittedAccount, addPermittedChains, and removePermittedChain.

This is necessary because the previous implementation broke up account and chain permission updates into separate add and remove mutations to state. This resulted in two accountsChanged and wallet_sessionChanged events being fired whenever the user added and removed an account / chainId in a single edit action.

Related issues

Fixes:

Manual testing steps

Permission a dapp
On the dapp tab, enter window.ethereum.on("accountsChanged", console.log) into console
edit permissions by opening the extension popup, clicking the globe icon, and editing accounts to permit a new account and unpermit an existing account
See that the accountsChanged event only fired once for the dapp

Permission the multichain test dapp
edit permissions by opening the extension popup, clicking the globe icon, and editing accounts to permit a new account and unpermit an existing account
See that the session changed event inpage UI only shows one event
Repeat above for permitted chains

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-05-20T18:30:26Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-05-20T18:32:24Z

✨ Files requiring CODEOWNER review ✨

🖥️ @MetaMask/wallet-ux

ui/components/multichain/pages/review-permissions-page/review-permissions-page.tsx

metamaskbot · 2025-05-20T19:06:53Z

Builds ready [f13682f]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1225 ± 63 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1225	1079	1381	63	1261	1331
			load	1054	936	1229	60	1101	1156
			domContentLoaded	1047	929	1223	60	1091	1148
			domInteractive	16	13	41	4	16	23
			firstPaint	795	141	1229	394	1071	1145
			backgroundConnect	8	4	38	5	8	21
			firstReactRender	21	15	50	6	21	37
			getState	14	6	35	7	19	29
			initialActions	0	0	1	0	0	1
			loadScripts	808	692	981	59	849	915
			setupStore	8	6	23	3	8	15
	Webpack	Home	uiStartup	2090	1584	2587	209	2230	2465
			load	1621	1254	2007	158	1717	1894
			domContentLoaded	1608	1250	1972	147	1705	1864
			domInteractive	14	11	40	7	13	36
			firstPaint	149	62	349	57	167	263
			backgroundConnect	28	9	338	45	25	48
			firstReactRender	131	42	363	97	152	324
			getState	19	4	306	44	14	46
			initialActions	6	1	293	29	3	5
			loadScripts	1605	1249	1962	145	1701	1854
			setupStore	40	7	316	81	20	297
Firefox	Browserify	Home	uiStartup	1276	1108	1917	138	1307	1602
			load	1133	973	1609	126	1177	1435
			domContentLoaded	1133	973	1609	126	1177	1434
			domInteractive	91	33	232	28	103	133
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	19	12	64	7	19	34
			firstReactRender	23	20	51	6	23	35
			getState	10	4	190	19	8	27
			initialActions	0	0	1	0	0	1
			loadScripts	1117	964	1593	125	1160	1416
			setupStore	6	4	32	3	6	8
	Webpack	Home	uiStartup	1564	1362	2134	154	1631	1916
			load	1359	1186	1928	138	1438	1647
			domContentLoaded	1359	1185	1928	138	1438	1646
			domInteractive	75	52	158	14	83	93
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	15	260	24	24	31
			firstReactRender	37	28	49	5	40	44
			getState	11	5	176	17	9	25
			initialActions	0	0	1	0	1	1
			loadScripts	1337	1171	1912	136	1415	1571
			setupStore	10	5	76	11	8	32

Benchmark value 21 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 40 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2465 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 297 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 27 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 32 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 8ms | Sum of p95 exceeds: 253ms
Sum of all benchmark exceeds: 261ms

app/scripts/controllers/permissions/background-api.js

adonesky1

Code looks good and tested and it works great 🙏

metamaskbot · 2025-05-20T21:14:58Z

Builds ready [33e02a3]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1220 ± 78 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1220	1077	1441	78	1267	1383
			load	1053	926	1230	73	1093	1219
			domContentLoaded	1045	920	1227	74	1088	1211
			domInteractive	16	13	85	7	16	24
			firstPaint	761	137	1249	397	1059	1138
			backgroundConnect	9	4	29	6	9	24
			firstReactRender	21	16	52	7	21	39
			getState	15	6	40	8	20	32
			initialActions	0	0	1	0	0	1
			loadScripts	804	679	985	74	842	966
			setupStore	8	5	26	3	9	17
	Webpack	Home	uiStartup	2073	1654	2582	220	2232	2447
			load	1614	1299	1965	158	1717	1882
			domContentLoaded	1608	1295	1960	157	1711	1873
			domInteractive	15	11	49	8	13	40
			firstPaint	161	59	391	65	206	283
			backgroundConnect	21	8	75	10	24	37
			firstReactRender	120	42	373	95	122	335
			getState	17	3	291	40	12	43
			initialActions	8	1	295	40	3	5
			loadScripts	1605	1293	1958	155	1709	1863
			setupStore	33	6	306	69	18	275
Firefox	Browserify	Home	uiStartup	1326	1141	1827	135	1374	1621
			load	1175	1019	1641	123	1228	1446
			domContentLoaded	1175	1019	1641	123	1228	1446
			domInteractive	93	37	191	27	104	147
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	13	210	20	21	36
			firstReactRender	24	20	52	5	23	30
			getState	9	5	201	19	8	10
			initialActions	0	0	2	0	0	1
			loadScripts	1156	1006	1613	119	1212	1382
			setupStore	8	4	67	8	6	32
	Webpack	Home	uiStartup	1531	1338	2204	144	1609	1827
			load	1330	1154	1934	139	1416	1556
			domContentLoaded	1329	1153	1934	139	1416	1556
			domInteractive	77	52	153	17	80	112
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	14	193	18	23	41
			firstReactRender	37	28	50	5	41	44
			getState	8	5	33	4	9	13
			initialActions	0	0	2	1	1	1
			loadScripts	1310	1138	1802	132	1400	1539
			setupStore	10	5	239	23	8	20

Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 1383 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1220 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1212 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 966 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 33 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 275 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 32 exceeds gate value 27 for firefox browserify home p95 setupStore
Sum of mean exceeds: 4ms | Sum of p95 exceeds: 327ms
Sum of all benchmark exceeds: 331ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0%)
ui: -397 Bytes (-0.01%)
common: 496 Bytes (0.01%)

metamaskbot · 2025-05-21T18:50:28Z

Builds ready [dec7d0f]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1192 ± 66 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1192	1074	1428	66	1227	1323
			load	1026	929	1203	56	1059	1104
			domContentLoaded	1019	921	1200	56	1051	1097
			domInteractive	16	13	85	8	15	24
			firstPaint	778	77	1169	384	1044	1094
			backgroundConnect	8	4	33	5	8	23
			firstReactRender	20	15	52	6	20	34
			getState	14	6	46	8	19	29
			initialActions	0	0	1	0	0	1
			loadScripts	781	679	933	55	813	867
			setupStore	8	5	18	2	8	13
	Webpack	Home	uiStartup	2125	1674	2579	205	2258	2492
			load	1659	1307	1997	154	1745	1965
			domContentLoaded	1653	1304	1983	152	1741	1951
			domInteractive	15	12	55	9	13	41
			firstPaint	163	65	360	62	178	301
			backgroundConnect	31	10	337	53	26	40
			firstReactRender	159	42	367	116	299	343
			getState	16	4	268	33	14	26
			initialActions	3	1	7	1	3	5
			loadScripts	1647	1302	1972	147	1733	1888
			setupStore	30	6	322	60	19	155
Firefox	Browserify	Home	uiStartup	1321	1132	1693	126	1369	1644
			load	1168	1000	1537	113	1224	1412
			domContentLoaded	1167	1000	1537	113	1224	1412
			domInteractive	93	38	301	34	99	168
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	13	111	13	21	48
			firstReactRender	24	20	59	6	24	29
			getState	9	5	154	15	8	18
			initialActions	0	0	1	0	0	1
			loadScripts	1149	987	1519	112	1207	1393
			setupStore	9	4	229	23	6	19
	Webpack	Home	uiStartup	1599	1393	2254	173	1684	2014
			load	1384	1207	1963	162	1471	1820
			domContentLoaded	1383	1207	1962	162	1471	1820
			domInteractive	79	44	152	18	85	119
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	16	53	8	23	42
			firstReactRender	38	30	50	4	42	45
			getState	10	5	37	6	9	30
			initialActions	0	0	2	1	1	1
			loadScripts	1364	1186	1945	162	1451	1802
			setupStore	11	5	218	22	9	15

cc: @HowardBraham
Benchmark value 23 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 2492 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 155 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 1384 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1384 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 39 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1364 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2014 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1820 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1820 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1802 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 13ms | Sum of p95 exceeds: 704ms
Sum of all benchmark exceeds: 717ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0%)
ui: -397 Bytes (-0.01%)
common: 496 Bytes (0.01%)

…unts' into jl/fix-add-remove-permitted-accounts

metamaskbot · 2025-05-22T16:11:59Z

Builds ready [cf2e2e9]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1271 ± 87 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1271	1115	1626	87	1325	1409
			load	1095	941	1389	87	1165	1224
			domContentLoaded	1088	938	1381	87	1158	1218
			domInteractive	17	13	55	5	17	30
			firstPaint	767	150	1386	437	1142	1214
			backgroundConnect	9	4	33	5	9	22
			firstReactRender	21	17	53	6	21	35
			getState	14	6	39	8	19	29
			initialActions	0	0	1	0	0	1
			loadScripts	844	703	1097	85	913	971
			setupStore	8	5	24	3	9	16
	Webpack	Home	uiStartup	2111	1674	2534	216	2249	2460
			load	1629	1299	1944	157	1735	1884
			domContentLoaded	1622	1295	1929	155	1727	1875
			domInteractive	16	11	61	10	13	43
			firstPaint	158	62	344	63	180	290
			backgroundConnect	22	9	58	9	26	36
			firstReactRender	147	44	361	103	272	331
			getState	14	4	309	30	13	27
			initialActions	3	1	7	1	3	4
			loadScripts	1619	1294	1918	154	1723	1865
			setupStore	29	7	307	60	19	246
Firefox	Browserify	Home	uiStartup	1348	1127	1854	143	1397	1708
			load	1194	1005	1611	131	1253	1549
			domContentLoaded	1193	1005	1611	131	1253	1548
			domInteractive	100	35	225	33	107	174
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	13	181	18	21	49
			firstReactRender	23	20	52	3	23	27
			getState	8	4	41	6	8	13
			initialActions	0	0	2	0	0	1
			loadScripts	1174	993	1598	127	1235	1527
			setupStore	7	4	64	8	6	11
	Webpack	Home	uiStartup	1561	1354	2025	156	1671	1905
			load	1352	1151	1827	148	1461	1646
			domContentLoaded	1352	1151	1827	148	1461	1646
			domInteractive	81	39	257	26	87	111
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	14	50	7	22	40
			firstReactRender	39	27	56	5	42	46
			getState	9	5	34	6	9	28
			initialActions	0	0	2	1	1	1
			loadScripts	1334	1134	1807	147	1444	1630
			setupStore	11	5	247	25	8	23

cc: @HowardBraham
Benchmark value 1272 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1096 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1088 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 844 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1409 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1225 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1219 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1214 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 23 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 971 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 2461 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 246 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 1708 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 1549 exceeds gate value 1495 for firefox browserify home p95 load
Benchmark value 1548 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded
Benchmark value 1527 exceeds gate value 1475 for firefox browserify home p95 loadScripts
Benchmark value 39 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 106ms | Sum of p95 exceeds: 583ms
Sum of all benchmark exceeds: 689ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0%)
ui: -393 Bytes (-0.01%)
common: 464 Bytes (0.01%)

metamaskbot · 2025-05-23T19:35:06Z

Builds ready [d678edc]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1259 ± 80 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1259	1096	1481	80	1302	1452
			load	1087	963	1315	75	1136	1240
			domContentLoaded	1080	959	1306	75	1128	1233
			domInteractive	17	13	36	5	17	29
			firstPaint	840	149	1311	410	1124	1241
			backgroundConnect	8	4	37	5	8	14
			firstReactRender	21	16	47	5	22	35
			getState	14	6	54	8	19	25
			initialActions	0	0	1	0	0	1
			loadScripts	835	714	1066	74	881	975
			setupStore	8	5	15	2	9	13
	Webpack	Home	uiStartup	2108	1692	2620	212	2257	2457
			load	1631	1318	1998	153	1723	1866
			domContentLoaded	1626	1314	1987	152	1718	1857
			domInteractive	16	11	93	12	13	42
			firstPaint	168	65	401	61	192	290
			backgroundConnect	22	9	64	9	25	37
			firstReactRender	151	42	366	107	277	337
			getState	12	4	100	11	13	28
			initialActions	3	1	7	1	3	5
			loadScripts	1622	1312	1976	151	1717	1847
			setupStore	38	6	321	78	19	305
Firefox	Browserify	Home	uiStartup	1368	1162	1896	129	1427	1631
			load	1210	1033	1709	126	1267	1462
			domContentLoaded	1210	1033	1709	126	1267	1462
			domInteractive	100	38	290	32	116	153
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	14	87	10	22	31
			firstReactRender	26	21	62	9	24	54
			getState	10	5	201	20	8	11
			initialActions	0	0	5	1	0	1
			loadScripts	1192	1020	1686	124	1251	1437
			setupStore	6	4	37	3	6	11
	Webpack	Home	uiStartup	1535	1346	1894	131	1605	1863
			load	1319	1176	1697	118	1383	1610
			domContentLoaded	1319	1175	1697	118	1382	1610
			domInteractive	78	51	268	25	82	127
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	15	56	8	25	44
			firstReactRender	38	29	49	4	40	45
			getState	11	5	69	9	10	30
			initialActions	1	0	2	1	1	1
			loadScripts	1300	1159	1681	119	1367	1590
			setupStore	10	5	61	9	8	27

Benchmark value 1260 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1088 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1081 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 841 exceeds gate value 800 for chrome browserify home mean firstPaint
Benchmark value 836 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1452 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1240 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1233 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1242 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 975 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 38 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2457 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 305 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 39 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 119ms | Sum of p95 exceeds: 530ms
Sum of all benchmark exceeds: 649ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0%)
ui: -393 Bytes (-0.01%)
common: 464 Bytes (0.01%)

jiexi added 4 commits May 20, 2025 10:21

add setPermittedAccounts and setPermittedChains

e13df83

Merge branch 'main' into jl/fix-add-remove-permitted-accounts

5354695

cleanup. add more specs

e5f27aa

Merge branch 'main' into jl/fix-add-remove-permitted-accounts

f13682f

jiexi requested a review from a team as a code owner May 20, 2025 18:30

metamaskbot added the team-wallet-api-platform label May 20, 2025

jiexi changed the title ~~Fix: add setPermittedChains and setPermittedAccounts background methods~~ fix: add setPermittedChains and setPermittedAccounts background methods May 20, 2025

jiexi changed the title ~~fix: add setPermittedChains and setPermittedAccounts background methods~~ fix: dapp receiving two accountsChanged and wallet_sessionChanged events when adding and removing accounts/chainIds in the same edit action May 20, 2025

adonesky1 reviewed May 20, 2025

View reviewed changes

app/scripts/controllers/permissions/background-api.js Outdated Show resolved Hide resolved

adonesky1 reviewed May 20, 2025

View reviewed changes

app/scripts/controllers/permissions/background-api.js Show resolved Hide resolved

adonesky1 previously approved these changes May 20, 2025

View reviewed changes

Merge branch 'main' into jl/fix-add-remove-permitted-accounts

33e02a3

ffmcgee725 previously approved these changes May 21, 2025

View reviewed changes

vinnyhoward previously approved these changes May 21, 2025

View reviewed changes

Merge branch 'main' into jl/fix-add-remove-permitted-accounts

dec7d0f

jiexi enabled auto-merge May 21, 2025 18:16

jiexi added 2 commits May 22, 2025 08:38

Merge branch 'main' into jl/fix-add-remove-permitted-accounts

f5b6c9d

Merge remote-tracking branch 'origin/jl/fix-add-remove-permitted-acco…

cf2e2e9

…unts' into jl/fix-add-remove-permitted-accounts

jiexi dismissed stale reviews from vinnyhoward, adonesky1, and ffmcgee725 via cf2e2e9 May 22, 2025 15:38

adonesky1 previously approved these changes May 22, 2025

View reviewed changes

jiexi added 2 commits May 23, 2025 11:22

lint

1c8e4e3

Merge branch 'main' into jl/fix-add-remove-permitted-accounts

5a76eca

Trigger

d678edc

jiexi dismissed adonesky1’s stale review via d678edc May 23, 2025 19:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: dapp receiving two accountsChanged and wallet_sessionChanged events when adding and removing accounts/chainIds in the same edit action #33082

fix: dapp receiving two accountsChanged and wallet_sessionChanged events when adding and removing accounts/chainIds in the same edit action #33082

jiexi commented May 20, 2025 •

edited by github-actions bot

Loading

Uh oh!

github-actions bot commented May 20, 2025

Uh oh!

metamaskbot commented May 20, 2025

Uh oh!

metamaskbot commented May 20, 2025

Uh oh!

Uh oh!

Uh oh!

adonesky1 left a comment

Uh oh!

metamaskbot commented May 20, 2025

Uh oh!

metamaskbot commented May 21, 2025

Uh oh!

metamaskbot commented May 22, 2025

Uh oh!

metamaskbot commented May 23, 2025

Uh oh!

Uh oh!

fix: dapp receiving two accountsChanged and wallet_sessionChanged events when adding and removing accounts/chainIds in the same edit action #33082

Are you sure you want to change the base?

fix: dapp receiving two accountsChanged and wallet_sessionChanged events when adding and removing accounts/chainIds in the same edit action #33082

Conversation

jiexi commented May 20, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented May 20, 2025

Uh oh!

metamaskbot commented May 20, 2025

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented May 20, 2025

Uh oh!

Uh oh!

Uh oh!

adonesky1 left a comment

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented May 20, 2025

Uh oh!

metamaskbot commented May 21, 2025

Uh oh!

metamaskbot commented May 22, 2025

Uh oh!

metamaskbot commented May 23, 2025

Uh oh!

Uh oh!

jiexi commented May 20, 2025 •

edited by github-actions bot

Loading