Feat/trigger gator permissions revoke transaction#34373
Merged
V00D00-child merged 10 commits intoAug 14, 2025
Merged
Conversation
Collaborator
✨ Files requiring CODEOWNER review ✨🖥️ @MetaMask/wallet-ux (2 files, +39 -24)
|
…unction using @metamask/delegation-core package
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
…k/metamask-extension into feat/trigger-gator-permissions-revoke-transaction
V00D00-child
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
MoMannn
requested changes
Aug 1, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| // TODO: Implement revoke logic | ||
| console.log('erc20TokenStream to revoke:', erc20TokenStream); | ||
| const handleRevokeClick = async (stream) => { | ||
| await revokeGatorPermission(stream); |
There was a problem hiding this comment.
Bug: Async Function Error Handling Missing
The async handleRevokeClick function in ReviewTokenSubscriptionsPage and ReviewTokenStreamsPage lacks error handling. When revokeGatorPermission is called, any errors (e.g., from validation or transaction failures) result in unhandled promise rejections. This can lead to UI crashes, an inconsistent state, or silent failures without user feedback on failed revoke operations.
Additional Locations (1)
V00D00-child
merged commit 2bce330
into
feat/gator-permissions-revoke-ui
47 of 87 checks passed
V00D00-child
deleted the
feat/trigger-gator-permissions-revoke-transaction
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Submit transactions to revoke gator permissions. Support single and batch revokes.
Changelog
CHANGELOG entry: Adds a button for the user to revoke a gator permission.
Related issues
requires: #33996
requires: MetaMask/core#6033
requires: MetaMask/snap-7715-permissions#108
relates to: MetaMask/snap-7715-permissions#84
Manual testing steps
yarn dist --build-type flask --apply-lavamoat false@metamask/permissions-kernel-snapand@metamask/gator-permissions-snap.Pre-merge author checklist
Pre-merge reviewer checklist