feat: Add feature flag for gator permissions page#35307
Conversation
✨ Files requiring CODEOWNER review ✨🖥️ @MetaMask/wallet-ux (2 files, +65 -0)
|
Builds ready [6b86a49]
UI Startup Metrics (1242 ± 73 ms)
Benchmark value 239 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 1373 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 260 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 8 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2236 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 35 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2630 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 392 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 288 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 22 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 30 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 248 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 31 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 35 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1632 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 108 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 60 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 276 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 51 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 78 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 14 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 360ms | Sum of p95 exceeds: 802.8ms Sum of all benchmark exceeds: 1162.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [3e4bbd4]
UI Startup Metrics (1229 ± 65 ms)
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 254 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 19 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2226 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 31 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2546 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 391 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 271 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 12 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1467 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1263 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1263 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 35 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1237 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 236 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 71 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 38 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 106 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 59 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 3 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 257 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 71 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 11 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 427ms | Sum of p95 exceeds: 643.8ms Sum of all benchmark exceeds: 1070.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [9684fbf]
UI Startup Metrics (1241 ± 63 ms)
Benchmark value 241 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 258 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 15 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2196 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 34 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2582 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 384 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 274 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 294 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 29 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 205 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 27 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 39 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 108 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 60 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 283 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 72 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 22 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 305ms | Sum of p95 exceeds: 911.8ms Sum of all benchmark exceeds: 1216.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
9684fbf to
1c14355
Compare
…MetaMask/metamask-extension into feat/add-gator-permissions-feature-flag
Builds ready [f60c62e]
UI Startup Metrics (1228 ± 65 ms)
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 249 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2231 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 2529 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 388 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 271 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 11 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 296 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 1414 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 35 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 211 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 96 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 39 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1675 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1400 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1400 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 128 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 61 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1378 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 1943 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 275 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 72 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 15 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 37 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 473ms | Sum of p95 exceeds: 884.8ms Sum of all benchmark exceeds: 1357.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [0fa6c81]
UI Startup Metrics (1271 ± 75 ms)
Benchmark value 1116 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1109 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 256 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 861 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1411 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1256 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1251 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 1224 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 270 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 10 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 997 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2226 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1722 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1715 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 36 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 1710 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2605 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 390 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 268 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 2 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 206 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 8 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 30 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 109 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 57 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 264 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 67 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 8 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 526ms | Sum of p95 exceeds: 942.8ms Sum of all benchmark exceeds: 1468.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [0715f7f]
UI Startup Metrics (1229 ± 63 ms)
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 264 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 23 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 40 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2585 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 283 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 10 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1416 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 115 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 35 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 251 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 83 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 110 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 253 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 52 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 7 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 312ms | Sum of p95 exceeds: 666.8ms Sum of all benchmark exceeds: 978.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [2c0c795]
UI Startup Metrics (1256 ± 68 ms)
Benchmark value 1091 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1083 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 250 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 841 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1382 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1181 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 265 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 944 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 36 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2476 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 285 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 12 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1406 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 115 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 35 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 251 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 83 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 9 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 31 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 108 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 34 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 266 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 11 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 378ms | Sum of p95 exceeds: 596.8ms Sum of all benchmark exceeds: 974.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [e4ea8e2]
UI Startup Metrics (1211 ± 67 ms)
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 1183 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 251 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 35 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 277 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1436 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 121 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 38 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1752 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 264 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 112 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 45 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 105 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 266 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 53 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 11 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 328ms | Sum of p95 exceeds: 681.8ms Sum of all benchmark exceeds: 1009.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [4378c40]
UI Startup Metrics (1217 ± 73 ms)
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 1389 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1241 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1233 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 262 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 1004 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2502 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 66 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 255 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 30 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 238 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 9 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 48 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 106 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 35 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1940 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 289 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 55 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 12 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 281ms | Sum of p95 exceeds: 792.8ms Sum of all benchmark exceeds: 1073.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
jeffsmale90
left a comment
There was a problem hiding this comment.
A couple of minor nits. Feel free to ping me for re-approval if you feel any of those are worth updates.
As an aside, #35193 introduces the feature flag with the environment variable EIP_7715_READABLE_PERMISSIONS_ENABLED, it would be nice to have aligned with this.
|
|
||
| # Enables gator permissions feature | ||
| - GATOR_PERMISSIONS_ENABLED: false |
There was a problem hiding this comment.
Is it necessary to duplicate the definition for flask build, rather than allowing the default to take precedence?
| }); | ||
|
|
||
| describe('isGatorPermissionsFeatureEnabled', () => { | ||
| it('should return true when GATOR_PERMISSIONS_ENABLED is "true"', () => { |
There was a problem hiding this comment.
What's the expected behaviour for strings other than "true" or "false"?
Description
Add a new build feature flag
GATOR_PERMISSIONS_ENABLEDthat defaults to false. It is intended to serve as a feature flag for the development of the gator-permission page.GATOR_PERMISSIONS_ENABLED=true, the/permissionspath will route to theGatorPermissionsPagecomponent.GATOR_PERMISSIONS_ENABLED=falseor empty, the/permissionspath will continue to route to thePermissionsPagecomponent.Changelog
CHANGELOG entry: This PR is not End-User-Facing, and it is intended to serve as a feature flag for the development of the gator-permission page.
Related issues
relates to: MetaMask/core#6033
required by: #35219
relates to: MetaMask/snap-7715-permissions#84
Manual testing steps
GATOR_PERMISSIONS_ENABLED=truein.metamaskrcyarn dist --build-type flask --apply-lavamoat falseAll Permissions pagePre-merge author checklist
Pre-merge reviewer checklist