Skip to content

feat: Add feature flag for gator permissions page#35307

Merged
V00D00-child merged 18 commits into
mainfrom
feat/add-gator-permissions-feature-flag
Sep 3, 2025
Merged

feat: Add feature flag for gator permissions page#35307
V00D00-child merged 18 commits into
mainfrom
feat/add-gator-permissions-feature-flag

Conversation

@V00D00-child

@V00D00-child V00D00-child commented Aug 21, 2025

Copy link
Copy Markdown
Member

Description

Add a new build feature flag GATOR_PERMISSIONS_ENABLED that defaults to false. It is intended to serve as a feature flag for the development of the gator-permission page.

  • When GATOR_PERMISSIONS_ENABLED=true, the /permissions path will route to the GatorPermissionsPage component.
  • When GATOR_PERMISSIONS_ENABLED=false or empty, the /permissions path will continue to route to the PermissionsPage component.

Changelog

CHANGELOG entry: This PR is not End-User-Facing, and it is intended to serve as a feature flag for the development of the gator-permission page.

Related issues

relates to: MetaMask/core#6033
required by: #35219
relates to: MetaMask/snap-7715-permissions#84

Manual testing steps

  1. Set GATOR_PERMISSIONS_ENABLED=true in .metamaskrc
  2. Build Flask: yarn dist --build-type flask --apply-lavamoat false
  3. Navigate to the All Permissions page
  4. A Blank page will show as a placeholder to the Gator permission management UI(ie, permission revocation flow).

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@V00D00-child V00D00-child requested a review from a team as a code owner August 21, 2025 16:36
@V00D00-child V00D00-child added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed team-delegation MetaMask Delegation Team labels Aug 21, 2025
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Aug 21, 2025
@metamaskbot

metamaskbot commented Aug 21, 2025

Copy link
Copy Markdown
Collaborator

✨ Files requiring CODEOWNER review ✨

🖥️ @MetaMask/wallet-ux (2 files, +65 -0)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain/
        • 📁 pages/
          • 📁 gator-permissions/
            • 📄 gator-permissions-page.test.tsx +12 -0
            • 📄 gator-permissions-page.tsx +53 -0

cursor[bot]

This comment was marked as outdated.

@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [6b86a49]
UI Startup Metrics (1242 ± 73 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1242106914687312941372
load106092612706810941174
domContentLoaded105292212636910881167
domInteractive17134871738
firstPaint715150127442910821169
backgroundConnect23822428410243259
firstReactRender24164362638
getState1143871528
initialActions3017348
loadScripts822702102968862935
setupStore943641016
WebpackHomeuiStartup22351695279822723772630
load16811213210419817891955
domContentLoaded16741209209919517821941
domInteractive181282141449
firstPaint1616845865169305
backgroundConnect3416252333263
firstReactRender19091403104187392
getState3553077613288
initialActions9217924622
loadScripts16681207206119017781926
setupStore236314561533
FirefoxBrowserifyHomeuiStartup13851196180510314441559
load1198104615098712611352
domContentLoaded1198104615098712601352
domInteractive1083243960113248
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect291690133169
firstReactRender26218072837
getState828512531
initialActions30274212
loadScripts1176102914928612341336
setupStore935811635
WebpackHomeuiStartup16321414204214017091865
load13661182166712014491587
domContentLoaded13651181166712014491586
domInteractive1073331453109276
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3119101123551
firstReactRender60488186578
getState9213615726
initialActions6013318314
loadScripts13431155164011914331554
setupStore95316927
Benchmark value 1242 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 239 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 1373 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 260 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 8 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2236 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 35 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 2630 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 392 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 288 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 22 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 30 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 248 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 31 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 35 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1632 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 108 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 60 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 276 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 51 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 78 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 14 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 360ms | Sum of p95 exceeds: 802.8ms
Sum of all benchmark exceeds: 1162.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 2.81 KiB (0.04%)
  • common: 10 Bytes (0%)

@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [3e4bbd4]
UI Startup Metrics (1229 ± 65 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1229109014206512641337
load104892812036110901152
domContentLoaded104091811956210831144
domInteractive17134451735
firstPaint67473121242510691160
backgroundConnect2362232689240254
firstReactRender23164152435
getState1255081428
initialActions40366319
loadScripts81168997461856916
setupStore85223914
WebpackHomeuiStartup22251649268318323372545
load16751201199314517471896
domContentLoaded16681196198214317391885
domInteractive181298161445
firstPaint1676249665196282
backgroundConnect3112298293358
firstReactRender20987407112338391
getState3053077012271
initialActions52283612
loadScripts16641190196914117311872
setupStore236303531531
FirefoxBrowserifyHomeuiStartup14671275200411515231648
load1263111514618513321418
domContentLoaded1262111514608513321417
domInteractive1073528751119236
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3418137203471
firstReactRender27224042935
getState8218319622
initialActions5018919214
loadScripts1236109714438313071386
setupStore11422124638
WebpackHomeuiStartup15911376197612716641831
load13441135165911314151535
domContentLoaded13441135165811314141535
domInteractive1053331657111257
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect28207683045
firstReactRender58487966171
getState72487623
initialActions30173311
loadScripts13241109164011313961516
setupStore94829722
Benchmark value 237 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 254 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 19 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2226 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 31 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 2546 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 391 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 271 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 12 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1467 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1263 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1263 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 35 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 1237 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 236 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 71 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 38 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 106 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 59 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 3 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 257 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 71 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 11 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 427ms | Sum of p95 exceeds: 643.8ms
Sum of all benchmark exceeds: 1070.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 2.81 KiB (0.04%)
  • common: 10 Bytes (0%)

@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [9684fbf]
UI Startup Metrics (1241 ± 63 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1241112314376312831344
load105895312245810861160
domContentLoaded105094712165910791152
domInteractive17144051731
firstPaint69777120843110791151
backgroundConnect2402252669246258
firstReactRender25176772640
getState1256891628
initialActions40305415
loadScripts81771497258846914
setupStore851831014
WebpackHomeuiStartup21951654264421423072582
load16521204195318717571911
domContentLoaded16461199194618717541901
domInteractive1812104151452
firstPaint1656239361203279
backgroundConnect3315328413156
firstReactRender1799038987178384
getState3443227612274
initialActions5223369
loadScripts16421196193318517511892
setupStore2863066814294
FirefoxBrowserifyHomeuiStartup13671171178110814251556
load1181101714818312281336
domContentLoaded1181101714818312281335
domInteractive1003225743111205
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2918125133153
firstReactRender25223632733
getState7210614527
initialActions5018920214
loadScripts115999914618312051318
setupStore11320823739
WebpackHomeuiStartup15951376215715716721901
load13311152177013014351578
domContentLoaded13301152176913014351578
domInteractive1073129961109283
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect312097103545
firstReactRender59448776372
getState72277824
initialActions6114720322
loadScripts13081128174312914151560
setupStore95355821
Benchmark value 1241 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 241 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 258 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 15 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2196 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 34 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 2582 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 384 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 274 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 294 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 29 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 205 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 27 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 39 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 108 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 60 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 283 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 72 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 22 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 305ms | Sum of p95 exceeds: 911.8ms
Sum of all benchmark exceeds: 1216.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 3.23 KiB (0.04%)
  • common: 817 Bytes (0.01%)

@V00D00-child V00D00-child force-pushed the feat/add-gator-permissions-feature-flag branch from 9684fbf to 1c14355 Compare August 22, 2025 15:40
cursor[bot]

This comment was marked as outdated.

@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [f60c62e]
UI Startup Metrics (1228 ± 65 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1228111614636512661332
load105294112686410991159
domContentLoaded104593412596410871152
domInteractive17135361725
firstPaint72270126643010861162
backgroundConnect2362252637240249
firstReactRender23154562337
getState1243471528
initialActions40599416
loadScripts816705103664854924
setupStore85222813
WebpackHomeuiStartup22311645263619623332528
load16701205197317017761905
domContentLoaded16641199196317017701900
domInteractive171291141447
firstPaint1556942556173265
backgroundConnect281285113155
firstReactRender21090414105324388
getState2743106511271
initialActions52213611
loadScripts16591197195016917681895
setupStore2963016815296
FirefoxBrowserifyHomeuiStartup14141200185011514861624
load1220104614378412681376
domContentLoaded1219104614378412681376
domInteractive1053431747118211
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3518116193496
firstReactRender26235842831
getState62506521
initialActions4017217212
loadScripts1192102814187812381334
setupStore835410639
WebpackHomeuiStartup16751418315721317631943
load14001169291120014901634
domContentLoaded14001167291020014891634
domInteractive128341738171116275
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3121137123443
firstReactRender61478576672
getState83397824
initialActions40628315
loadScripts13781147289220014681612
setupStore12519522837
Benchmark value 237 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 249 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2231 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 2529 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 388 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 271 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 11 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 296 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 1414 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 35 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 211 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 96 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 39 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1675 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1400 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1400 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 128 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 61 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1378 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 1943 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 275 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 72 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 15 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 37 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 473ms | Sum of p95 exceeds: 884.8ms
Sum of all benchmark exceeds: 1357.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 2.23 KiB (0.03%)
  • common: 10 Bytes (0%)

Comment thread builds.yml Outdated
@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [0fa6c81]
UI Startup Metrics (1271 ± 75 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1271111515127513211411
load111697513207011511256
domContentLoaded110896713127111451250
domInteractive18144871737
firstPaint743116132144411201224
backgroundConnect2552432808260270
firstReactRender24177592445
getState13590131632
initialActions30495310
loadScripts860726104068896997
setupStore95274918
WebpackHomeuiStartup22251686267120823242605
load17221293199616218131960
domContentLoaded17141288199116018071929
domInteractive171272121552
firstPaint1726651771215307
backgroundConnect301486133270
firstReactRender2059139697203390
getState3632827612268
initialActions5219269
loadScripts17101285198915918041919
setupStore237303511628
FirefoxBrowserifyHomeuiStartup13421125167911014141558
load1186100915229212351352
domContentLoaded1185100815229212351352
domInteractive953329948105206
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect28166373241
firstReactRender27226052936
getState6210111521
initialActions2011228
loadScripts116499414999112201328
setupStore937711730
WebpackHomeuiStartup15531357190813916411824
load13241148157211414091535
domContentLoaded13241147157211414081534
domInteractive1083429554111264
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect28198683240
firstReactRender57437366067
getState825910625
initialActions3030438
loadScripts13021126155011313881514
setupStore1049510920
Benchmark value 1272 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1116 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1109 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 256 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 861 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1411 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1256 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1251 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1224 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 270 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 10 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 997 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2226 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1722 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1715 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 36 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 1710 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2605 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 390 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 268 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 2 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 206 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 8 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 30 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 109 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 57 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 264 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 67 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 8 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 526ms | Sum of p95 exceeds: 942.8ms
Sum of all benchmark exceeds: 1468.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 1.81 KiB (0.02%)
  • common: 143 Bytes (0%)

@V00D00-child V00D00-child enabled auto-merge August 27, 2025 20:57
@metamaskbot

Copy link
Copy Markdown
Collaborator

📊 Page Load Benchmark Results

Current Commit: 18c5419 | Date: 9/2/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.29s (±109ms) 🟡 | historical mean value: 1.30s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 972ms (±105ms) 🟢 | historical mean value: 982ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 90ms (±38ms) 🟢 | historical mean value: 94ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.29s 109ms 1.24s 1.91s 1.38s 1.91s
domContentLoaded 972ms 105ms 935ms 1.58s 1.05s 1.58s
firstPaint 90ms 38ms 68ms 288ms 176ms 288ms
firstContentfulPaint 90ms 38ms 68ms 288ms 176ms 288ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [0715f7f]
UI Startup Metrics (1229 ± 63 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1229112214546312621337
load106496612685810941175
domContentLoaded105795612595810851168
domInteractive17143541825
firstPaint66783126843810831148
backgroundConnect2462312728250263
firstReactRender24165062640
getState1363461529
initialActions50406612
loadScripts818705102257843924
setupStore1143051223
WebpackHomeuiStartup21151496275927423082585
load16821206211921618431972
domContentLoaded16711194210421418301960
domInteractive1912112181456
firstPaint1666446069198286
backgroundConnect331781133662
firstReactRender1004034460105284
getState3943088017283
initialActions62243710
loadScripts16671192209221318261947
setupStore177282271523
FirefoxBrowserifyHomeuiStartup14161241169210714871628
load1232105815109412941406
domContentLoaded1232105715109412941406
domInteractive1153230453120251
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect351999163683
firstReactRender27225142836
getState736110622
initialActions418710311
loadScripts1205103514919312591373
setupStore94446825
WebpackHomeuiStartup15811360192712916661805
load13581169162311314471533
domContentLoaded13571168162211314471533
domInteractive1093429050109253
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect29225063340
firstReactRender44366154652
getState6265669
initialActions611842137
loadScripts13361152160211414271517
setupStore96254917
Benchmark value 246 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 264 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 23 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 40 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 2585 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 283 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 10 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1416 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 115 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 35 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 251 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 83 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 110 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 253 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 52 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 7 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 312ms | Sum of p95 exceeds: 666.8ms
Sum of all benchmark exceeds: 978.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 1.84 KiB (0.02%)
  • common: 143 Bytes (0%)

@metamaskbot

Copy link
Copy Markdown
Collaborator

📊 Page Load Benchmark Results

Current Commit: 1e9a2f9 | Date: 9/2/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.28s (±68ms) 🟡 | historical mean value: 1.30s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 964ms (±60ms) 🟢 | historical mean value: 980ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 86ms (±26ms) 🟢 | historical mean value: 94ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.28s 68ms 1.25s 1.91s 1.32s 1.91s
domContentLoaded 964ms 60ms 935ms 1.53s 1.00s 1.53s
firstPaint 86ms 26ms 72ms 316ms 120ms 316ms
firstContentfulPaint 86ms 26ms 72ms 316ms 120ms 316ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [2c0c795]
UI Startup Metrics (1256 ± 68 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1256109414126812971382
load109096812626211291190
domContentLoaded108296212546211171179
domInteractive18145271738
firstPaint73673123544211081180
backgroundConnect2502343009255265
firstReactRender24174462538
getState1468691826
initialActions50657613
loadScripts840723100261878943
setupStore962631014
WebpackHomeuiStartup20451523267326622122476
load16361226205520717751925
domContentLoaded16261220202720617681905
domInteractive171295121446
firstPaint1687039658194276
backgroundConnect3418340333167
firstReactRender96373387388316
getState3653137614285
initialActions62223612
loadScripts16201217201520217561888
setupStore177279301525
FirefoxBrowserifyHomeuiStartup14051213173210914801603
load1221106715868912921388
domContentLoaded1221106715858912921388
domInteractive1143228952123251
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3420132193583
firstReactRender27234842937
getState62838611
initialActions3127339
loadScripts1194105014608512541368
setupStore94569831
WebpackHomeuiStartup15821402218815016911857
load13461189166812114391575
domContentLoaded13461188166712114391575
domInteractive1073331850103266
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect33208193746
firstReactRender43375144650
getState8213013715
initialActions5112214311
loadScripts13221161164612214201552
setupStore10611912924
Benchmark value 1256 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1091 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1083 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 250 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 841 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1382 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1181 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 265 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 944 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 36 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 2476 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 285 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 12 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1406 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 115 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 35 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 251 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 83 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 9 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 31 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 108 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 34 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 266 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 11 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 378ms | Sum of p95 exceeds: 596.8ms
Sum of all benchmark exceeds: 974.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 1.84 KiB (0.02%)
  • common: 143 Bytes (0%)

@metamaskbot

Copy link
Copy Markdown
Collaborator

📊 Page Load Benchmark Results

Current Commit: 6eee2a5 | Date: 9/2/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.29s (±74ms) 🟡 | historical mean value: 1.30s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 969ms (±64ms) 🟢 | historical mean value: 981ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 86ms (±16ms) 🟢 | historical mean value: 93ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.29s 74ms 1.25s 1.85s 1.33s 1.85s
domContentLoaded 969ms 64ms 939ms 1.43s 1.00s 1.43s
firstPaint 86ms 16ms 68ms 172ms 116ms 172ms
firstContentfulPaint 86ms 16ms 68ms 172ms 116ms 172ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [e4ea8e2]
UI Startup Metrics (1211 ± 67 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1211109414826712571342
load105195313106410951189
domContentLoaded104494613056410881183
domInteractive17144161738
firstPaint655102119642510561132
backgroundConnect2402282697244250
firstReactRender24164862437
getState1354381631
initialActions40506512
loadScripts810700105963853933
setupStore963241016
WebpackHomeuiStartup19861515259426021552445
load15871226193119817201882
domContentLoaded15771215192019717111871
domInteractive1711100151446
firstPaint1716942359195283
backgroundConnect28177493053
firstReactRender81383285285123
getState3552897514277
initialActions5242569
loadScripts15711213190919317061853
setupStore146274261321
FirefoxBrowserifyHomeuiStartup14351209189814315061752
load12391058163410612981424
domContentLoaded12391058163310612981424
domInteractive1213447565134264
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect38201602735112
firstReactRender28226862939
getState73507714
initialActions507610310
loadScripts1210103215399412631362
setupStore11410214845
WebpackHomeuiStartup15651368204213316821823
load13381168158611714541558
domContentLoaded13371168158511714541558
domInteractive105323226099266
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect32215773743
firstReactRender44336354753
getState63142711
initialActions40436311
loadScripts13141151155711914301537
setupStore10514013918
Benchmark value 241 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 1183 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 251 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 35 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 277 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1436 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 121 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 38 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1752 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 264 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 112 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 45 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 105 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 266 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 53 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 11 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 328ms | Sum of p95 exceeds: 681.8ms
Sum of all benchmark exceeds: 1009.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 1.84 KiB (0.02%)
  • common: 143 Bytes (0%)

@metamaskbot

Copy link
Copy Markdown
Collaborator

📊 Page Load Benchmark Results

Current Commit: 5b02771 | Date: 9/2/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.28s (±106ms) 🟡 | historical mean value: 1.30s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 971ms (±101ms) 🟢 | historical mean value: 979ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 95ms (±51ms) 🟢 | historical mean value: 93ms ⬆️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.28s 106ms 1.23s 1.96s 1.39s 1.96s
domContentLoaded 971ms 101ms 926ms 1.60s 1.07s 1.60s
firstPaint 95ms 51ms 68ms 336ms 188ms 336ms
firstContentfulPaint 95ms 51ms 68ms 336ms 188ms 336ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [4378c40]
UI Startup Metrics (1217 ± 73 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1217108514417312491389
load105594012807110801241
domContentLoaded104793212737110731233
domInteractive17134861728
firstPaint64371128042510421161
backgroundConnect24422930210249262
firstReactRender25186672639
getState1557391731
initialActions50385613
loadScripts8116871037718351003
setupStore1062841019
WebpackHomeuiStartup20031496255927221522502
load16081216197220817511905
domContentLoaded15981208196420717411891
domInteractive181292161466
firstPaint1698336253189284
backgroundConnect3214331323158
firstReactRender85363406083281
getState2652846113255
initialActions5221369
loadScripts15951204195220617391879
setupStore176292381326
FirefoxBrowserifyHomeuiStartup13691156184610814521541
load1192101714858512591354
domContentLoaded1192101714858512591353
domInteractive1013426448110238
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2919103133240
firstReactRender27225052937
getState53495610
initialActions511821839
loadScripts1169100113928212331326
setupStore1047912848
WebpackHomeuiStartup15741365209616116621940
load13341165166213414321624
domContentLoaded13341165166213414321624
domInteractive105353066096289
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect342295113847
firstReactRender45327264755
getState73445717
initialActions41748412
loadScripts13091141163013214141599
setupStore1056171022
Benchmark value 245 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 1389 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1241 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1233 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 262 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 1004 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2502 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 66 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 255 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 30 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 238 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 9 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 48 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 106 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 35 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1940 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 289 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 55 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 12 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 281ms | Sum of p95 exceeds: 792.8ms
Sum of all benchmark exceeds: 1073.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 1.84 KiB (0.02%)
  • common: 143 Bytes (0%)

@jeffsmale90 jeffsmale90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor nits. Feel free to ping me for re-approval if you feel any of those are worth updates.

As an aside, #35193 introduces the feature flag with the environment variable EIP_7715_READABLE_PERMISSIONS_ENABLED, it would be nice to have aligned with this.

Comment thread builds.yml
Comment on lines +110 to +112

# Enables gator permissions feature
- GATOR_PERMISSIONS_ENABLED: false

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to duplicate the definition for flask build, rather than allowing the default to take precedence?

});

describe('isGatorPermissionsFeatureEnabled', () => {
it('should return true when GATOR_PERMISSIONS_ENABLED is "true"', () => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the expected behaviour for strings other than "true" or "false"?

@V00D00-child V00D00-child added this pull request to the merge queue Sep 3, 2025
@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Sep 3, 2025
Merged via the queue into main with commit 3f23d46 Sep 3, 2025
274 of 276 checks passed
@V00D00-child V00D00-child deleted the feat/add-gator-permissions-feature-flag branch September 3, 2025 00:36
@github-project-automation github-project-automation Bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Sep 3, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 3, 2025
@metamaskbot metamaskbot added the release-13.4.0 Issue or pull request that will be included in release 13.4.0 label Sep 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-13.4.0 Issue or pull request that will be included in release 13.4.0 size-M team-delegation MetaMask Delegation Team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants