fix: Fix first time interaction alert to check real recipient and contract address #36763
+68
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (2 files, +68 -50)
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [01064ff]
UI Startup Metrics (1224 ± 72 ms)
|
OGPoyraz
added
the
no-changelog
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [526afa2]
UI Startup Metrics (1294 ± 76 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
| state: TrustSignalDisplayState.Verified, | ||
| label: null, | ||
| }, | ||
| ]); |
There was a problem hiding this comment.
Bug: Mock Returns Single Signal, Fails Multi-Address Testing
The useTrustSignals mock in tests consistently returns a single trust signal, even though the hook can request signals for multiple addresses (like contract and recipient in token transfers). This prevents accurate testing of multi-address scenarios and conditions that rely on checking all or some trust signals.
Additional Locations (1)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [a9b8a2b]
UI Startup Metrics (1213 ± 65 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix first time interaction alert to check recipient derived from transaction data when sending ERCX tokens. It still checks the
toparameter regardless of the changes.Changelog
CHANGELOG entry: null
Related issues
Fixes: #35595
Manual testing steps
See task details to repro steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Update first-time interaction alert to check both the transaction
toand derived recipient withuseTrustSignals, refining loading/verified logic and tests.useFirstTimeInteractionAlertto useuseTrustSignalswith multiple requests (fortxParams.toand derived recipient fromuseTransferRecipient).isFirstTimeInteractiontrue, no first-party contract, no loading trust signals, and all addresses not verified.transactionToseparately; compare internal accounts against the derived recipient; usegetExperienceontxParams.to.useTrustSignalsand return arrays; addtoin transaction mocks and set explicit types where needed.Written by Cursor Bugbot for commit a9b8a2b. This will update automatically on new commits. Configure here.