Skip to content

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Oct 10, 2025

Description

Changing codewners for activity list code following the ownership change announced here:

https://consensys.slack.com/archives/C01PKA4QC3C/p1759416645335399

Open in GitHub Codespaces

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds Core Extension UX as codeowners for activity/transaction list components in CODEOWNERS.

  • CODEOWNERS:
    • Core Extension UX ownership expanded to cover:
      • ui/components/app/transaction-list
      • ui/components/app/transaction-list-item
      • ui/components/app/transaction-list-item-details

Written by Cursor Bugbot for commit b7675c9. This will update automatically on new commits. Configure here.

@pedronfigueiredo pedronfigueiredo self-assigned this Oct 10, 2025
@pedronfigueiredo pedronfigueiredo requested a review from a team as a code owner October 10, 2025 16:17
@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Oct 10, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

🔒 @MetaMask/extension-security-team (1 files, +8 -5)
  • 📁 .github/
    • 📄 CODEOWNERS +8 -5

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: b7675c9 | Date: 10/10/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±74ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 732ms (±70ms) 🟢 | historical mean value: 737ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±18ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 74ms 1.01s 1.39s 1.28s 1.39s
domContentLoaded 732ms 70ms 698ms 1.05s 935ms 1.05s
firstPaint 76ms 18ms 60ms 240ms 88ms 240ms
firstContentfulPaint 76ms 18ms 60ms 240ms 88ms 240ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [b7675c9]
UI Startup Metrics (1210 ± 70 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1210110914707012321339
load104495912386010711160
domContentLoaded103795312336010651156
domInteractive16133851630
firstPaint649141125042310441171
backgroundConnect2512392838254271
firstReactRender24185862435
getState1158081220
initialActions50567417
loadScripts79270498559820918
setupStore85173915
WebpackHomeuiStartup841711110271863991
load64958793972658814
domContentLoaded64158192971652808
domInteractive16116991539
firstPaint19358848178196620
backgroundConnect23114772833
firstReactRender27166293244
getState842031013
initialActions2012247
loadScripts63857991769650798
setupStore84162912
FirefoxBrowserifyHomeuiStartup14761284199315215331823
load1247110715289313251433
domContentLoaded1247110615289313251432
domInteractive1043531256108260
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3321133163661
firstReactRender32255663550
getState9313016631
initialActions6119323226
loadScripts1223108615069112961412
setupStore14419529884
WebpackHomeuiStartup15221347207612015431829
load1321118816417613661466
domContentLoaded1320118816417613651465
domInteractive933233043105177
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2918121133450
firstReactRender3626144163573
getState73607522
initialActions408610223
loadScripts1297117016177313391445
setupStore13314724744
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 10 Bytes (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size-S team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants