release(runway): cherry-pick feat: path based blocking #36824
+1,179
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![runway-github[bot]](https://avatars.githubusercontent.com/in/86225?s=80&v=4){kind=small}
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (1 files, +1 -0)
🧩 @MetaMask/extension-devs (4 files, +20 -0)
📜 @MetaMask/policy-reviewers (4 files, +20 -0)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 🔗 @MetaMask/supply-chain (4 files, +20 -0)
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…ask/metamask-extension into cherry-pick-13-4-3-8bdd1e1
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [ecbd824]
UI Startup Metrics (1258 ± 73 ms)
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [5b54350]
UI Startup Metrics (1239 ± 72 ms)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces URL path based blocking within the extension. This allows
websites like
example.com/pathto be blocked rather than blocking allof
example.com.Changelog
CHANGELOG entry: Added path-based blocking for URLs
Related issues
Fixes:
Manual testing steps
sites.google.com/view/aoooop/aave-comand make sure that ityou are redirected to the Phishing Warning Page
sites.google.com/view/aoooop/and make sure that it does notredirect you.
sites.google.com/view/aoooop/aave-com/pathand make sure thatyou are redirected to the Phishing Warning Page.
sites.google.com/view/aoooop/aave-comshould also nolonger redirect to the Phishing Warning Page.
sites.google.com/view/aoooop/aave-com/pathshould also nolonger redirect to the Phishing Warning Page (implicit in step 4).
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask
Extension Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Adds path-based phishing detection (blocklistPaths + whitelistPaths), updates diffs API to v2, and extends tests/mocks/policies accordingly.
PathTriewithinsertToTrie,deleteFromTrie,matchedPathPrefix, and helpers for efficient path checks.PhishingDetectorto block byblocklistPathsand exposeblockingPath(url).PhishingController:whitelistPathsstate and path-based bypass logic.matchedPathPrefixto allow whitelisted paths.getPathnameFromUrl.getHostnameAndPathComponentsandgetPathnameFromUrl.applyDiffsto handleblocklistPathswith trie ops and deep copy (deepCopyPathTrie).'/v2/diffsSince'.whitelistPaths; default state includes empty trie; update removal keys and metrics allowlist.blocklistPathssupport.blocklistPathsin list state.PathTrie_*globals.@metamask/phishing-controllervia Yarn; bump related deps (@metamask/base-controller,@metamask/controller-utils,@metamask/messenger,@metamask/utils,@metamask/phishing-warning).Written by Cursor Bugbot for commit 5b54350. This will update automatically on new commits. Configure here.
Co-authored-by: augmentedmode [email protected] 8bdd1e1