Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Contributor
Builds ready [f024598]
⚡ Performance Benchmarks (Total: 🟢 18 pass · 🟡 0 warn · 🔴 0 fail)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
david0xd
reviewed
Apr 6, 2026
|
david0xd
approved these changes
Apr 6, 2026
Contributor
Builds ready [8e8206a]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 12 warn · 🔴 0 fail)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
gantunesr
approved these changes
Apr 6, 2026
metamaskbot
added
the
release-13.27.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The bug hasn't been reproducible nor do the sentry errors lead to the reason why
accountIdByAddresswould beundefined, nonetheless a fallback has been added as a defense mechanism.Changelog
CHANGELOG entry: null
Related issues
Fixes: #41441
Manual testing steps
N/A
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk: selector now defensively falls back to an immutable
EMPTY_OBJECTwhenaccountIdByAddressis missing, avoiding crashes and unnecessary recomputation; no business logic changes beyond this fallback.Overview
Adds a defensive fallback in
getAccountIdByAddress(ui/selectors/accounts.ts) to return an immutableEMPTY_OBJECTwhenstate.metamask.accountIdByAddressisundefined.This prevents
getInternalAccountByAddress(and other downstreamcreateSelectorconsumers) from breaking or recomputing due to unstable/undefined references, with a small import cleanup to support the new constant.Reviewed by Cursor Bugbot for commit 8e8206a. Bugbot is set up for automated code reviews on this repo. Configure here.