Skip to content

chore: enable batched account creation for Solana #41464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HowardBraham merged 4 commits into from
Apr 7, 2026
+15 −8
Merged

chore: enable batched account creation for Solana #41464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf42bec
bump(@metamask/solana-wallet-snap): enable batched account creation f…
gantunesr Apr 2, 2026
79c7ddc
Merge branch 'main' into feat/solana-batched-account-creation
gantunesr Apr 3, 2026
17c44c9
Merge branch 'main' into feat/solana-batched-account-creation
gantunesr Apr 6, 2026
619add4
Merge branch 'main' into feat/solana-batched-account-creation
gantunesr Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/scripts/controller-init/multichain/multichain-account-service-init.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ describe('MultichainAccountServiceInit', () => {
});
});

it('passes Solana provider config with maxConcurrency 1 and discovery/createAccounts timeouts', () => {
it('passes Solana provider config with maxConcurrency 1, discovery/createAccounts timeouts, and batched true', () => {
const requestMock = buildInitRequestMock();
MultichainAccountServiceInit(requestMock);

Expand All @@ -102,6 +102,7 @@ describe('MultichainAccountServiceInit', () => {
},
createAccounts: {
timeoutMs: 3000,
batched: true,
},
},
});
Expand Down
8 changes: 7 additions & 1 deletion app/scripts/controller-init/multichain/multichain-account-service-init.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,13 @@ export const MultichainAccountServiceInit: ControllerInitFunction<
const controller = new MultichainAccountService({
messenger: controllerMessenger,
providerConfigs: {
[SOL_ACCOUNT_PROVIDER_NAME]: snapAccountProviderConfig,
[SOL_ACCOUNT_PROVIDER_NAME]: {
...snapAccountProviderConfig,
createAccounts: {
...snapAccountProviderConfig.createAccounts,
batched: true,
},
},
[BTC_ACCOUNT_PROVIDER_NAME]: snapAccountProviderConfig,
[TRX_ACCOUNT_PROVIDER_NAME]: snapAccountProviderConfig,
},
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@
"@metamask/snaps-rpc-methods": "^15.0.1",
"@metamask/snaps-sdk": "^11.0.0",
"@metamask/snaps-utils": "^12.1.2",
"@metamask/solana-wallet-snap": "^2.7.3",
"@metamask/solana-wallet-snap": "^2.8.0",
"@metamask/solana-wallet-standard": "^0.6.0",
"@metamask/storage-service": "^1.0.0",
"@metamask/subscription-controller": "^6.0.0",
Expand Down
10 changes: 5 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8137,10 +8137,10 @@ __metadata:
languageName: node
linkType: hard

"@metamask/solana-wallet-snap@npm:^2.7.3":
version: 2.7.3
resolution: "@metamask/solana-wallet-snap@npm:2.7.3"
checksum: 10/d7d5fa02a9dc5a6cc271fb46e20a5c44a8de845d01985537df576591fe1d7e572ece6d82731c3765548488718cc9f776d2310f7aea2528d0f6aeaa853136bd94
"@metamask/solana-wallet-snap@npm:^2.8.0":
version: 2.8.0
resolution: "@metamask/solana-wallet-snap@npm:2.8.0"
checksum: 10/5e26f28d585aa00c4da204a7311f15048de30ff336baa90df1ca82f0d151b25dcf7b3fc3daa8b9ab02914aca35f31eb7a2854bf167008f6e96f99e215f02767c
languageName: node
linkType: hard

Expand Down Expand Up @@ -34164,7 +34164,7 @@ __metadata:
"@metamask/snaps-rpc-methods": "npm:^15.0.1"
"@metamask/snaps-sdk": "npm:^11.0.0"
"@metamask/snaps-utils": "npm:^12.1.2"
"@metamask/solana-wallet-snap": "npm:^2.7.3"
"@metamask/solana-wallet-snap": "npm:^2.8.0"
"@metamask/solana-wallet-standard": "npm:^0.6.0"
"@metamask/storage-service": "npm:^1.0.0"
"@metamask/subscription-controller": "npm:^6.0.0"
Expand Down
Loading