chore: upgrade design-system deps and migrate bold to semibold#41467
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (5 files, +16 -2)
🔐 @MetaMask/web3auth (2 files, +10 -10)
|
Builds ready [1c845f5]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 12 warn · 🔴 0 fail)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
1c845f5 to
c074978
Compare
c074978 to
2b28493
Compare
2b28493 to
818775c
Compare
| @font-face { | ||
| font-family: 'Geist'; | ||
| src: url('#{$font-path}/Geist/Geist-SemiBold.woff2') format('woff2'); | ||
| font-weight: 700; |
There was a problem hiding this comment.
Mapping both 600 and 700 to Geist-SemiBold keeps semantic bold aligned with MMDS while preserving compatibility for legacy static font-weight: 700 styles that still exist in extension code.
| /> | ||
| <div | ||
| class="relative flex size-6 items-center justify-center rounded border-2 p-0 transition-transform active:scale-95 bg-default hover:bg-default-hover active:bg-default-pressed border-default" | ||
| class="relative flex size-6 items-center justify-center rounded border-2 p-0 transition-transform active:scale-95 peer-focus-visible:outline peer-focus-visible:outline-2 peer-focus-visible:outline-offset-2 peer-focus-visible:outline-primary-default bg-default hover:bg-default-hover active:bg-default-pressed border-default" |
There was a problem hiding this comment.
This snapshot delta captures the checkbox focus-visible outline classes added by the DS fix in this release, so it documents an intentional accessibility behavior change rather than unrelated UI drift.
| "@metamask/design-system-react": "^0.13.0", | ||
| "@metamask/design-system-tailwind-preset": "^0.6.1", | ||
| "@metamask/design-tokens": "^8.2.2", | ||
| "@metamask/design-tokens": "^8.3.0", |
There was a problem hiding this comment.
These version bumps are the minimum needed for the v27 migration on extension web: design-system-react picks up the semibold bold semantics and design-tokens provides the updated font-weight token values.
Builds ready [a83c8ac]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 12 warn · 🔴 0 fail)
Dapp page load benchmarks: data not available. Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
79348aa
a83c8ac to
79348aa
Compare
|
Builds ready [79348aa]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 12 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|




Description
Upgrades MetaMask Extension to the latest web design-system packages and applies
Geist-Bold=>Geist-SemiBoldmigration. Also includes small fix to Checkbox to show focus for keyboard navigation.https://github.com/MetaMask/metamask-design-system/releases/tag/v27.0.0
This mirrors the intent of MetaMask Mobile PR MetaMask/metamask-mobile#28363 but with extension-specific changes.
Changes included:
@metamask/design-system-reactfrom^0.12.0to^0.13.0@metamask/design-tokensfrom^8.2.2to^8.3.0@metamask/design-system-tailwind-presetremains^0.6.1(already latest)Geist-SemiBold.woff2Geist-SemiBoldItalic.woff2@font-facedeclarations to semibold mappings per migration guidancefont-weight: 700usages to600for bold semanticsReference:
Changelog
CHANGELOG entry: Updated extension typography and design-system dependencies to align semantic bold with the v27 semibold migration.
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/DSYS-665
Manual testing steps
yarn webpack --watchor equivalent local flow).Screenshots/Recordings
Before
extension.before720.mov
After
extension.after720.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Moderate risk due to dependency upgrades and global font-weight mapping changes that can cause visual regressions across the UI; functional impact is limited to styling/focus states.
Overview
Upgrades
@metamask/design-system-reactto^0.13.0(and relateddesign-system-shared) and@metamask/design-tokensto^8.3.0, updatingyarn.lockaccordingly.Migrates Geist typography by adding
Geist-SemiBold/Geist-SemiBoldItalic@font-faceentries and remapping the previous “bold” weights (700) to the semibold assets.Improves checkbox keyboard accessibility by adding
peer/peer-focus-visibleoutline classes to checkbox markup; Jest snapshots are updated to match.Reviewed by Cursor Bugbot for commit 79348aa. Bugbot is set up for automated code reviews on this repo. Configure here.