chore(7107): Include a Sentry Explore Link in the Announcement#41481
chore(7107): Include a Sentry Explore Link in the Announcement#41481DDDDDanica wants to merge 5 commits intomainfrom
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/extension-platform (7 files, +635 -49)
👨🔧 @HowardBraham (7 files, +635 -49)
👨🔧 @itsyoboieltr (7 files, +635 -49)
|
Builds ready [c5713a1]
⚡ Performance Benchmarks (Total: 🟢 2 pass · 🟡 5 warn · 🔴 0 fail)
Bundle size diffs
|
a19e172 to
79ae6e7
Compare
79ae6e7 to
393b767
Compare
393b767 to
afec841
Compare
afec841 to
0cfde3a
Compare
Builds ready [0cfde3a]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 12 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
0cfde3a to
13ea7c9
Compare
Builds ready [13ea7c9]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 12 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
13ea7c9 to
e8cf8cf
Compare
Builds ready [3241eba]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 12 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
3241eba to
40d9bc3
Compare
Builds ready [40d9bc3]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 12 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
40d9bc3 to
3f5499c
Compare
Builds ready [3f5499c]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 12 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
3f5499c to
8c7c9f0
Compare
8c7c9f0 to
f00462a
Compare
Builds ready [f00462a]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 12 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
f00462a to
eaf4008
Compare
|
Builds ready [eaf4008]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 12 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit eaf4008. Configure here.
| const logHref = entry.artifactUrl ?? runUrl; | ||
| const logAnchor = logHref ? ` <a href="${logHref}">[Show logs]</a>` : ''; | ||
| const links = buildCiLogLinkHtml(logHref); | ||
| const rowSentry = buildBenchmarkRowSentryLinkHtml(entry.benchmarkName); |
There was a problem hiding this comment.
String passed instead of object to Sentry link builder
High Severity
buildBenchmarkRowSentryLinkHtml expects a Pick<BenchmarkEntry, 'benchmarkName' | 'benchmarkType'> object, but entry.benchmarkName (a plain string) is passed instead of entry. This causes entry.benchmarkName inside the function to resolve to undefined, producing a malformed Sentry log message like benchmark.undefined. The two other call sites (lines 904 and 1029) correctly pass the full entry object.
Reviewed by Cursor Bugbot for commit eaf4008. Configure here.





Description
Add a direct link to Sentry Logs Explorer in the PR comment, pre-filtered to:
Changelog
CHANGELOG entry: null
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/7107
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk: changes are confined to CI workflows and PR comment generation, primarily adding links/labels and reading an existing
SENTRY_DSN_PERFORMANCEvariable.Overview
Adds optional Sentry Logs Explorer links to the performance benchmark PR comment output, including per-benchmark-row links prefiltered to
ci.branch:mainand the CI log message, whenSENTRY_DSN_PERFORMANCEis available.Updates GitHub Actions workflows to consistently expose
SENTRY_DSN_PERFORMANCEvia job/step env (and useenv.*inif:conditions), and renames benchmark log link text from [Show logs] to [CI log]. Introducessentry-utils.tsto parse the DSN and construct the Logs Explorer URL, with expanded unit tests around link rendering and DSN parsing.Reviewed by Cursor Bugbot for commit eaf4008. Bugbot is set up for automated code reviews on this repo. Configure here.