Merged
Conversation
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/perps (9 files, +1017 -7)
|
Contributor
Builds ready [cb0b483]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 12 warn · 🔴 0 fail)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [3cc5ee9]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 12 warn · 🔴 0 fail)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
geositta
reviewed
Apr 6, 2026
Contributor
geositta
left a comment
geositta
left a comment
There was a problem hiding this comment.
The modal looks good overall and the cancel flow is clean. Even though it is more of a code hygiene thing, I would like to see it addressed before merging: the finally block on the success path fires a state update after the component has already unmounted, and the PR baselines that warning rather than fixing it. That is a straightforward reorder, once that is in and the baseline entry is removed, this is good to go.
The No string is quick to fix; the date locale is fine as a followup.
Optional: Should this cancel-order flow show a perps toast too? We already do that on mobile, and the page is wired for perps toasts, but there is no cancel specific toast key yet and even the current cancel all flow only uses inline error state. If we want parity with the other async perps actions, this seems like it should add dedicated cancel success/failure toasts instead of silently closing on success.
Contributor
Builds ready [42b5a3d]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 12 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
…tamask-extension into perps/fix-cancel-limit-order
Contributor
Builds ready [8e9057f]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 12 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
geositta
approved these changes
Apr 7, 2026
Contributor
geositta
left a comment
geositta
left a comment
There was a problem hiding this comment.
Thanks for making requested changes, this looks good from my end.
Contributor
Builds ready [9e33444]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 12 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
aganglada
approved these changes
Apr 7, 2026
metamaskbot
added
the
release-13.27.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cancel limit order flow was missing from market detail screen.
Changelog
CHANGELOG entry: Add cancel order flow from market detail entrypoint
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Screen.Recording.2026-04-03.at.10.53.46.AM.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Adds a new perps order-cancellation flow that triggers a background
perpsCancelOrderrequest and new toast states; mistakes here could prevent cancellations or show incorrect feedback. Scope is UI-focused with tests, but it touches user trading actions and navigation paths.Overview
Adds a Cancel Order flow in perps market detail: clicking an order card now opens a new
CancelOrderModalthat shows key order details and submitsperpsCancelOrder, with loading/error handling and success/failure perps toasts.Updates perps activity so clicking order transactions navigates to the relevant market detail page.
Introduces new i18n strings (
Cancel order, order detail labels,Reduce only,No) and extends perps toast key/presentation mappings; adds/updates Jest baselines and tests for the new modal and navigation behavior.Reviewed by Cursor Bugbot for commit 9e33444. Bugbot is set up for automated code reviews on this repo. Configure here.