chore: [DSYS-616] replace single Input instance and update @deprecated JSDoc by cursor[bot] · Pull Request #41487 · MetaMask/metamask-extension

cursor · 2026-04-05T14:12:31Z

Description

Processes the latest DSYS-616 Input migration docs and applies one safe extension migration step.

Changes made:

Updated legacy Input @deprecated JSDoc to include the migration guide link.
Replaced exactly one production usage of legacy Input with MMDS Input in DropdownEditor.
Updated the migrated callsite to align with Input migration guidance:
- readOnly -> isReadonly
- Removed legacy style utility props (paddingTop, paddingBottom) and used className (py-3) instead.

DSYS_EPIC: DSYS-616
Processed MIGRATION_DOCS_VERSION: 22f3e4c7

Changelog

CHANGELOG entry: null

Related issues

Fixes: DSYS-636

Manual testing steps

Open a flow that renders DropdownEditor with no selected item.
Verify the placeholder input still renders as read-only and non-interactive.
Open/close the dropdown and verify existing behavior remains unchanged.
Confirm ui/components/component-library/input/input.tsx contains the Input migration guide link in the @deprecated JSDoc.

Migration doc discrepancies found

None.

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>

metamaskbotv2 · 2026-04-05T14:13:21Z

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (2 files, +5 -13)

📁 ui/
- 📁 components/
  - 📁 multichain/
    - 📁 dropdown-editor/
      - 📄 dropdown-editor.tsx +3 -5
    - 📁 network-list-menu/
      - 📁 __snapshots__/
        
        📄 network-list-menu.test.tsx.snap +2 -8

🎨 @MetaMask/design-system-engineers (1 files, +1 -0)

📁 ui/
- 📁 components/
  - 📁 component-library/
    - 📁 input/
      - 📄 input.tsx +1 -0

metamaskbotv2 · 2026-04-05T14:46:39Z

Builds ready [aa706cd]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
webpack builds: chrome, firefox
webpack builds (beta): chrome, firefox
webpack builds (flask): chrome, firefox
webpack builds (test): chrome, firefox
webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 12 warn · 🔴 0 fail)

Baseline (latest main): f34f804 | Date: 9/10/58222 | Pipeline: 24003270514 | Baseline logs

Interaction Benchmarks

Benchmark chrome-browserify
loadNewAccount 🟡 [Show logs]
confirmTx 🟡 [Show logs]
bridgeUserActions 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ loadNewAccount/load_new_account: -14%
↓ loadNewAccount/total: -14%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 loadNewAccount/FCP: p75 2.5s
🟡 confirmTx/FCP: p75 2.5s
🟡 bridgeUserActions/FCP: p75 2.5s

Startup Benchmarks

Benchmark chrome-browserify chrome-webpack firefox-browserify firefox-webpack
startupStandardHome 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs]
startupPowerUserHome 🟡 [Show logs] 🟡 [Show logs] 🟡 [Show logs] 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ startupStandardHome/uiStartup: -14%
↓ startupStandardHome/load: -16%
↓ startupStandardHome/domContentLoaded: -18%
↓ startupStandardHome/firstReactRender: -17%
↓ startupStandardHome/initialActions: -38%
↓ startupStandardHome/loadScripts: -21%
↓ startupPowerUserHome/domInteractive: -14%
↑ startupPowerUserHome/backgroundConnect: +78%
↑ startupPowerUserHome/setupStore: +17%
↓ startupPowerUserHome/numNetworkReqs: -50%
↓ startupStandardHome/uiStartup: -12%
↓ startupStandardHome/load: -12%
↓ startupStandardHome/domContentLoaded: -11%
↓ startupStandardHome/backgroundConnect: -34%
↓ startupStandardHome/firstReactRender: -24%
↓ startupStandardHome/loadScripts: -11%
↓ startupStandardHome/numNetworkReqs: -29%
↓ startupPowerUserHome/domInteractive: -15%
↑ startupPowerUserHome/numNetworkReqs: +46%
↓ startupStandardHome/domInteractive: -58%
↓ startupStandardHome/initialActions: -38%
↓ startupStandardHome/numNetworkReqs: -18%
↓ startupPowerUserHome/backgroundConnect: -23%
↓ startupStandardHome/domInteractive: -32%
↓ startupStandardHome/backgroundConnect: -17%
↓ startupStandardHome/initialActions: -44%
↓ startupStandardHome/setupStore: -60%
↓ startupPowerUserHome/backgroundConnect: -33%
↓ startupPowerUserHome/setupStore: -15%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🔴 startupPowerUserHome/INP: p75 672ms
🔴 startupPowerUserHome/INP: p75 744ms
🟡 startupPowerUserHome/LCP: p75 3.5s
🟡 startupPowerUserHome/LCP: p75 3.7s

User Journey Benchmarks

Benchmark chrome-browserify
onboardingImportWallet 🟢 [Show logs]
onboardingNewWallet 🟢 [Show logs]
assetDetails 🟡 [Show logs]
solanaAssetDetails 🟡 [Show logs]
importSrpHome 🟡 [Show logs]
sendTransactions 🟡 [Show logs]
swap 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ onboardingImportWallet/doneButtonToHomeScreen: -75%
↑ onboardingImportWallet/openAccountMenuToAccountListLoaded: +33%
↓ onboardingImportWallet/total: -39%
↓ onboardingNewWallet/skipBackupToMetricsScreen: -16%
↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -27%
↓ onboardingNewWallet/doneButtonToAssetList: -28%
↓ onboardingNewWallet/total: -24%
↓ assetDetails/assetClickToPriceChart: -63%
↓ assetDetails/total: -63%
↓ solanaAssetDetails/assetClickToPriceChart: -61%
↓ solanaAssetDetails/total: -61%
↓ importSrpHome/openAccountMenuAfterLogin: -72%
↓ importSrpHome/homeAfterImportWithNewWallet: -37%
↓ importSrpHome/total: -31%
↑ sendTransactions/openSendPageFromHome: +151%
↑ sendTransactions/total: +10%
↓ swap/openSwapPageFromHome: -86%
↑ swap/fetchAndDisplaySwapQuotes: +31%
↑ swap/total: +13%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 assetDetails/INP: p75 208ms
🟡 assetDetails/FCP: p75 2.4s
🟡 solanaAssetDetails/FCP: p75 2.5s
🟡 importSrpHome/INP: p75 216ms
🟡 importSrpHome/FCP: p75 2.5s
🟡 sendTransactions/INP: p75 208ms
🟡 sendTransactions/FCP: p75 2.5s
🟡 swap/FCP: p75 2.6s

🌐 Dapp Page Load Benchmarks

Current Commit: aa706cd | Date: 4/5/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 950ms (±41ms) 🟢 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 671ms (±37ms) 🟢 | historical mean value: 728ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 79ms (±11ms) 🟢 | historical mean value: 86ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	950ms	41ms	927ms	1.24s	972ms	1.24s
domContentLoaded	671ms	37ms	651ms	932ms	684ms	932ms
firstPaint	79ms	11ms	64ms	172ms	88ms	172ms
firstContentfulPaint	79ms	11ms	64ms	172ms	88ms	172ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: 57 Bytes (0%)
common: 20 Bytes (0%)

georgewrmarshall · 2026-04-07T21:20:09Z

@cursor upate failing snapshot tests for ui/components/multichain/network-list-menu

cursor · 2026-04-07T21:20:20Z

Updated failing snapshots for ui/components/multichain/network-list-menu.
Verified by running the specific unit test; all tests and snapshots for this suite now pass.
Linted changed files, committed, pushed to cursor/component-instance-jsdoc-8eed, and updated the existing PR.

What I changed:

Updated ui/components/multichain/network-list-menu/__snapshots__/network-list-menu.test.tsx.snap to reflect the DropdownEditor Input migration (new MMDS Input classes and attributes).

…migration Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>

sonarqubecloud · 2026-04-07T21:39:54Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

metamaskbotv2 · 2026-04-07T22:01:52Z

Builds ready [69b79c5]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
webpack builds: chrome, firefox
webpack builds (beta): chrome, firefox
webpack builds (flask): chrome, firefox
webpack builds (test): chrome, firefox
webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 12 warn · 🔴 0 fail)

Baseline (latest main): f34f804 | Date: 9/10/58222 | Pipeline: 24105237282 | Baseline logs

Interaction Benchmarks · Samples: 5

Benchmark chrome-browserify
loadNewAccount 🟡 [Show logs]
confirmTx 🟡 [Show logs]
bridgeUserActions 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ bridgeUserActions/bridge_load_asset_picker: -43%
↑ bridgeUserActions/bridge_search_token: +44%
↑ bridgeUserActions/total: +18%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 loadNewAccount/FCP: p75 2.4s
🟡 confirmTx/FCP: p75 2.5s
🟡 bridgeUserActions/FCP: p75 2.5s

Startup Benchmarks · Samples: 100

Benchmark chrome-browserify chrome-webpack firefox-browserify firefox-webpack
startupStandardHome 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs]
startupPowerUserHome 🟡 [Show logs] 🟡 [Show logs] 🟡 [Show logs] 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ startupStandardHome/uiStartup: -11%
↓ startupStandardHome/load: -13%
↓ startupStandardHome/domContentLoaded: -15%
↑ startupStandardHome/backgroundConnect: +12%
↓ startupStandardHome/initialActions: -38%
↓ startupStandardHome/loadScripts: -18%
↓ startupStandardHome/numNetworkReqs: -21%
↓ startupPowerUserHome/uiStartup: -16%
↑ startupPowerUserHome/backgroundConnect: +76%
↑ startupPowerUserHome/setupStore: +11%
↓ startupPowerUserHome/numNetworkReqs: -22%
↓ startupStandardHome/uiStartup: -13%
↓ startupStandardHome/load: -13%
↓ startupStandardHome/domContentLoaded: -13%
↓ startupStandardHome/backgroundConnect: -35%
↓ startupStandardHome/firstReactRender: -24%
↓ startupStandardHome/loadScripts: -12%
↓ startupStandardHome/numNetworkReqs: -29%
↓ startupPowerUserHome/domInteractive: -12%
↓ startupPowerUserHome/numNetworkReqs: -44%
↓ startupStandardHome/domInteractive: -33%
↓ startupStandardHome/initialActions: -38%
↑ startupStandardHome/setupStore: +14%
↓ startupStandardHome/numNetworkReqs: -11%
↓ startupPowerUserHome/backgroundConnect: -26%
↑ startupPowerUserHome/setupStore: +50%
↓ startupStandardHome/domInteractive: -19%
↓ startupStandardHome/backgroundConnect: -12%
↓ startupStandardHome/initialActions: -44%
↓ startupStandardHome/setupStore: -54%
↓ startupPowerUserHome/uiStartup: -12%
↓ startupPowerUserHome/domInteractive: -16%
↓ startupPowerUserHome/backgroundConnect: -26%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🔴 startupPowerUserHome/INP: p75 720ms
🔴 startupPowerUserHome/INP: p75 608ms
🟡 startupPowerUserHome/LCP: p75 3.7s
🟡 startupPowerUserHome/LCP: p75 3.4s

User Journey Benchmarks · Samples: 5 · mock API

Benchmark chrome-browserify
onboardingImportWallet 🟢 [Show logs]
onboardingNewWallet 🟢 [Show logs]
assetDetails 🟡 [Show logs]
solanaAssetDetails 🟡 [Show logs]
importSrpHome 🟡 [Show logs]
sendTransactions 🟡 [Show logs]
swap 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ onboardingImportWallet/srpButtonToSrpForm: -85%
↓ onboardingImportWallet/metricsToWalletReadyScreen: -44%
↓ onboardingImportWallet/doneButtonToHomeScreen: -76%
↑ onboardingImportWallet/openAccountMenuToAccountListLoaded: +33%
↓ onboardingImportWallet/total: -42%
↓ onboardingNewWallet/srpButtonToPwForm: -78%
↓ onboardingNewWallet/skipBackupToMetricsScreen: -69%
↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -29%
↓ onboardingNewWallet/doneButtonToAssetList: -26%
↓ onboardingNewWallet/total: -27%
↓ assetDetails/assetClickToPriceChart: -42%
↓ assetDetails/total: -42%
↓ solanaAssetDetails/assetClickToPriceChart: -68%
↓ solanaAssetDetails/total: -68%
↓ importSrpHome/openAccountMenuAfterLogin: -76%
↓ importSrpHome/homeAfterImportWithNewWallet: -69%
↓ importSrpHome/total: -60%
↓ sendTransactions/selectTokenToSendFormLoaded: -29%
↑ sendTransactions/reviewTransactionToConfirmationPage: +37%
↑ sendTransactions/total: +35%
↓ swap/openSwapPageFromHome: -96%
↑ swap/fetchAndDisplaySwapQuotes: +31%
↑ swap/total: +12%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 assetDetails/INP: p75 216ms
🟡 assetDetails/FCP: p75 2.5s
🟡 solanaAssetDetails/FCP: p75 2.5s
🟡 importSrpHome/INP: p75 216ms
🟡 importSrpHome/FCP: p75 2.4s
🟡 sendTransactions/INP: p75 256ms
🟡 sendTransactions/FCP: p75 2.5s
🟡 swap/FCP: p75 2.5s

Dapp Page Load Benchmarks · Samples: 100

Benchmark chrome-browserify
dappPageLoad 🟢 [Show logs]

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -24 Bytes (0%)
ui: 6.38 KiB (0.08%)
common: 4.49 KiB (0.04%)

chore(dsys-616): replace one Input usage and add migration JSDoc link

aa706cd

Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>

cursor bot temporarily deployed to pr-comment April 5, 2026 14:12 Inactive

github-actions bot added the size-XS label Apr 5, 2026

cursor bot temporarily deployed to pr-comment April 5, 2026 14:42 Inactive

test(network-list-menu): update snapshots after DropdownEditor Input …

69b79c5

…migration Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>

cursor bot temporarily deployed to pr-comment April 7, 2026 21:26 Inactive

cursor bot temporarily deployed to pr-comment April 7, 2026 21:57 Inactive

georgewrmarshall self-assigned this Apr 8, 2026

georgewrmarshall added the team-design-system All issues relating to design system in Extension label Apr 8, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: [DSYS-616] replace single Input instance and update @deprecated JSDoc#41487

chore: [DSYS-616] replace single Input instance and update @deprecated JSDoc#41487
cursor[bot] wants to merge 2 commits intomainfrom
cursor/component-instance-jsdoc-8eed

cursor bot commented Apr 5, 2026

Uh oh!

metamaskbotv2 bot commented Apr 5, 2026 •

edited

Loading

Uh oh!

metamaskbotv2 bot commented Apr 5, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

georgewrmarshall commented Apr 7, 2026

Uh oh!

cursor bot commented Apr 7, 2026 •

edited

Loading

Uh oh!

sonarqubecloud bot commented Apr 7, 2026

Uh oh!

metamaskbotv2 bot commented Apr 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

cursor bot commented Apr 5, 2026

Description

Changelog

Related issues

Manual testing steps

Migration doc discrepancies found

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbotv2 bot commented Apr 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbotv2 bot commented Apr 5, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

georgewrmarshall commented Apr 7, 2026

Uh oh!

cursor bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud bot commented Apr 7, 2026

Quality Gate passed

Uh oh!

metamaskbotv2 bot commented Apr 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

metamaskbotv2 bot commented Apr 5, 2026 •

edited

Loading

cursor bot commented Apr 7, 2026 •

edited

Loading