Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (10 files, +632 -0)
|
david0xd
force-pushed
the
dd/add-qr-adapter
branch
from
bd61c26 to
51fcdfa
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Builds ready [51fcdfa]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 12 warn · 🔴 0 fail)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 69ff639. Configure here.
Contributor
Builds ready [69ff639]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 12 warn · 🔴 0 fail)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [2d502fa]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 12 warn · 🔴 0 fail)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [19b9d1f]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 12 warn · 🔴 0 fail)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
hmalik88
reviewed
Apr 6, 2026
|
hmalik88
approved these changes
Apr 6, 2026
Contributor
Builds ready [46822f7]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 12 warn · 🔴 0 fail)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ccharly
reviewed
Apr 7, 2026
| * Resets local connection state. | ||
| */ | ||
| destroy(): void { | ||
| this.connected = false; |
Contributor
There was a problem hiding this comment.
Nit: But I wonder if destroy should also call disconnect implicitly in-case the device is still connected (I know we're not doing that for the LedgerAdapter, but that might be something we should discuss internally cc @montelaidev)
Contributor
There was a problem hiding this comment.
(not something we need to handle on this PR btw)
| @@ -86,6 +87,7 @@ const ERROR_PROPERTIES_MAP = (() => { | |||
|
|
|||
| // Extract from Ledger | |||
Contributor
There was a problem hiding this comment.
Nit: But given that we have more adapters now, this comment should be changed at some point
Comment on lines
+34
to
+37
| if (globalThis.window === undefined) { | ||
| return false; | ||
| } | ||
| const { navigator } = globalThis; |
Contributor
There was a problem hiding this comment.
Just double-checking: Did you want to check .window only? Or also for .navigator?
Since navigator could effectively be undefined here when we use navigator.mediaDevices below.
(Not sure this object can ever be undefined, but I prefer to double-check with you!)
Contributor
There was a problem hiding this comment.
But from what I read, navigator is similar to window.navigator anyway, so if window is defined, navigator should be available, we should be safe I think
| video: true, | ||
| }); | ||
|
|
||
| stream.getTracks().forEach((track) => track.stop()); |
Contributor
There was a problem hiding this comment.
Nit: Just to make sure I understand, are we requesting + stopping everything, just to be able to request the camera permission only once?
Like we request, then queryCameraPermissionDomState() should already be set to the proper value so we know we can use it without asking again?
If yes, then having a comment could have been great!
ccharly
approved these changes
Apr 7, 2026
Contributor
ccharly
left a comment
ccharly
left a comment
There was a problem hiding this comment.
LGTM! Left some nits and potential questions about the HW adapter in general, but other than that, the code is good!
metamaskbot
added
the
release-13.27.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds QR adapter which will be used for the new QR hardware wallet flow.
Changelog
CHANGELOG entry: null
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MUL-1643
Manual testing steps
Nothing specifically here that we can manually test.
Unit tests are added to cover all new functionalities.
Screenshots/Recordings
Before
No UI changes. Nothing to show here.
After
No UI changes. Nothing to show here.
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Introduces a new
QrAdapterand adds camera permission probing/requesting to sharedwebConnectionUtils, which could affect hardware-wallet permission UX and error mapping if browser permission APIs behave unexpectedly.Overview
Adds QR hardware wallet support via a new
QrAdapterthat manages QR-flow connection state and gatesensureDeviceReadyon browser camera permission, emitting mapped device events/errors for denied/prompt/unknown cases.Extends
webConnectionUtilsto support camera availability checks, camera permission probing (checkCameraPermission/checkCameraPermissionState), and camera permission requests (requestCameraPermission), and wires these intocheckHardwareWalletPermission/requestHardwareWalletPermissionforHardwareWalletType.Qr(with a no-op event subscription path).Updates error-property mapping to include
QR_WALLET_ERROR_MAPPINGS, and expands mocks and unit tests to cover the new QR adapter and camera permission behaviors.Reviewed by Cursor Bugbot for commit 46822f7. Bugbot is set up for automated code reviews on this repo. Configure here.