feat: enable sidepanel for social login rehydration#41491
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c877d2d. Configure here.
Builds ready [c877d2d]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 12 warn · 🔴 0 fail)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
✨ Files requiring CODEOWNER review ✨🔐 @MetaMask/web3auth (2 files, +226 -25)
|
|
Builds ready [890d6d6]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 12 warn · 🔴 0 fail)
Dapp page load benchmarks: data not available. Bundle size diffs
|




Description
This PR enables SidePanel for the social login rehydration.
Changelog
CHANGELOG entry: enable sidepanel for the social login rehydration
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2026-04-06.at.12.43.25.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Changes unlock/rehydration completion logic for
FirstTimeFlowType.socialImport, including new sidepanel-specific completion actions and navigation, which can affect onboarding state and routing if mis-ordered or if async completion fails.Overview
Enables sidepanel-aware completion for social login rehydration during onboarding unlock. When seedless
socialImportusers unlock, onboarding now conditionally sets sidepanel as default and dispatchessetCompletedOnboardingWithSidepanel, then navigates immediately to the post-unlock route; non-sidepanel flows continue to mark onboarding complete and rely on the existingcompletedOnboardingredirect.Tests were updated to mock thunk-style action creators and add coverage ensuring the loading overlay stays visible until the async rehydration completion action resolves (both sidepanel and non-sidepanel cases).
Reviewed by Cursor Bugbot for commit 890d6d6. Bugbot is set up for automated code reviews on this repo. Configure here.