Repository navigation
Conversation
Contributor
✨ Files requiring CODEOWNER review ✨📜 @MetaMask/policy-reviewers (8 files, +16 -8)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 🔄 @MetaMask/swaps-engineers (2 files, +22 -22)
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning MetaMask internal reviewing guidelines:
|
micaelae
enabled auto-merge
October 27, 2026 23:34
Contributor
Builds ready [566a36e]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 4 warn · 🔴 2 fail)
Bundle Size Diffs
|
GeorgeGkas
previously approved these changes
Oct 28, 2026
Contributor
Builds ready [7fcde1c]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 3 warn · 🔴 4 fail)
Bundle Size Diffs
|
infiniteflower
previously approved these changes
Oct 28, 2026
micaelae
force-pushed
the
swaps-submit-tx-signature
branch
from
November 2, 2026 20:00
7fcde1c to
79fd76c
Compare
micaelae
had a problem deploying
to
segment-schema
November 2, 2026 20:00 — with 
GitHub Actions
Failure
GitHub Actions
Failure
Contributor
Builds ready [79fd76c]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 2 warn · 🔴 3 fail)
Bundle Size Diffs
|
Member
Author
|
@metamaskbot update-policies |
Contributor
|
Policies updated. Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 👀 lavamoat/webpack/mv2/beta/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes |
Contributor
Builds ready [e6cbaa1]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 1 warn · 🔴 3 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
micaelae
had a problem deploying
to
segment-schema
November 3, 2026 16:55 — with
GitHub Actions
Failure
GitHub Actions
Failure
Contributor
Builds ready [efd7d88]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 2 warn · 🔴 4 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
micaelae
had a problem deploying
to
segment-schema
November 3, 2026 22:00 — with
GitHub Actions
Failure
GitHub Actions
Failure
Contributor
Builds ready [48b6314]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 3 warn · 🔴 4 fail)
Bundle Size Diffs
|
Revert "chore: bump bridge controllers" This reverts commit d70639d250f472db5dd28cb10fc97483ef9a06df. fix: mocks Reapply "chore: bump bridge controllers" This reverts commit 4086e2aaedef420b8cd3277bf14bb5098439210b. fix: tests fix: tests, lint tsc chore: undo baseline update chore: rm resolution
micaelae
force-pushed
the
swaps-submit-tx-signature
branch
from
November 9, 2026 22:21
48b6314 to
02a1188
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 02a1188. Configure here.
Contributor
Builds ready [02a1188]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 2 warn · 🔴 4 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [202adb2]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 2 warn · 🔴 2 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
Member
Author
|
@metamaskbot update-policies |
Contributor
|
Policies updated. Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 👀 lavamoat/webpack/mv2/beta/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes |
Contributor
Builds ready [563f260]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 2 warn · 🔴 2 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
|
Member
Author
|
@metamaskbot update-policies |
Contributor
|
LavaMoat validation failed but no policy diffs were produced (the validation job may have crashed before generating diffs). Failed jobs: |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumps the bridge controllers and integrates the new
submitTxfunction signatureChangelog
CHANGELOG entry: chore: update bridge submitTx interface + location enum
Related issues
Fixes: N/A
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Changes the bridge transaction submission RPC payload and upgrades bridge-related controllers; misalignment could break swaps/bridges until manually verified.
Overview
Bumps @metamask/bridge-controller to
^83.1.3and @metamask/bridge-status-controller to^78.0.0, with lockfile churn for related controller/network/Solana deps. Drops the oldbridge-controller@82.0.2yarn resolution.submitTx calls from
ui/ducks/bridge-status/actions.tsnow pass a single options object toBridgeStatusController:submitTx(quoteResponses,isStxEnabled,quotesReceivedContext,location, migration phase, etc.) instead of a long positional argument list; the unit test expectation matches that shape.LavaMoat policies across MV2/MV3 builds narrow @metamask/bridge-controller>uuid globals from blanket
cryptotocrypto.getRandomValuesandcrypto.randomUUID.Reviewed by Cursor Bugbot for commit f65d53e. Bugbot is set up for automated code reviews on this repo. Configure here.