fix(predict): prevent pay token alert flicker

Author: pedronfigueiredo

app/components/UI/Predict/views/PredictBuyWithAnyToken/PredictBuyWithAnyToken.tsx

@@ -257,6 +257,7 @@ const PredictBuyWithAnyToken = (props: PredictBuyPreviewProps) => {
     isInsufficientBalance,
     isConfirming,
     isPayFeesLoading,
+    isPaySystemSettling,
     blockingPayAlertMessage,
     outcomeTokenPrice: outcomeToken?.price,
     isSheetMode,

app/components/UI/Predict/views/PredictBuyWithAnyToken/hooks/usePredictBuyConditions.ts

@@ -150,8 +150,13 @@ export const usePredictBuyConditions = ({
       return null;
     }
 
-    return `${selectedPaymentTokenKey}:${totalPayForPredictBalance}`;
-  }, [selectedPaymentTokenKey, totalPayForPredictBalance]);
+    const amountValue = totalPayForPredictBalance || currentValue;
+    const roundedQuoteAmount = new BigNumber(amountValue)
+      .decimalPlaces(2, BigNumber.ROUND_UP)
+      .toString(10);
+
+    return `${selectedPaymentTokenKey}:${roundedQuoteAmount}`;
+  }, [currentValue, selectedPaymentTokenKey, totalPayForPredictBalance]);
 
   // Tracks the token/amount pair for which a full quote-loading cycle has
   // completed. Keeping the amount in the key makes same-token amount changes

app/components/UI/Predict/views/PredictBuyWithAnyToken/hooks/usePredictBuyError.test.ts

@@ -106,6 +106,7 @@ const defaultParams = {
   isBelowMinimum: false,
   isInsufficientBalance: false,
   isPayFeesLoading: false,
+  isPaySystemSettling: false,
   blockingPayAlertMessage: null as string | null,
   // Inline banner UX is sheet-mode-only; default these tests to sheet mode so
   // banner / errorMessage suppression behavior is exercised. The dedicated
@@ -236,6 +237,28 @@ describe('usePredictBuyError', () => {
       expect(result.current.errorMessageSource).toBe('blocking_pay_alert');
     });
 
+    it('suppresses pay token balance alert message while pay system is settling', () => {
+      mockActiveOrder = { error: 'order failed' };
+      mockIsPredictBalanceSelected = false;
+      mockGetPlaceOrderErrorOutcome.mockReturnValue({
+        status: 'error',
+        error: 'Order placement failed',
+      });
+
+      const { result } = renderHook(() =>
+        usePredictBuyError({
+          ...defaultParams,
+          isPaySystemSettling: true,
+          blockingPayAlertMessage: 'Insufficient payment token balance',
+        }),
+      );
+
+      expect(result.current.errorMessage).toBeUndefined();
+      expect(result.current.buyErrorBanner).toEqual(
+        expect.objectContaining({ variant: 'order_failed' }),
+      );
+    });
+
     it('returns undefined when activeOrder has no error', () => {
       mockActiveOrder = {};
 

app/components/UI/Predict/views/PredictBuyWithAnyToken/hooks/usePredictBuyError.ts

@@ -46,6 +46,7 @@ interface UsePredictBuyInfoParams {
   isBelowMinimum: boolean;
   isInsufficientBalance: boolean;
   isPayFeesLoading: boolean;
+  isPaySystemSettling: boolean;
   blockingPayAlertMessage: string | null;
   outcomeTokenPrice?: number;
   // Inline banner UX (price_changed / order_failed) only exists inside the
@@ -63,6 +64,7 @@ export const usePredictBuyError = ({
   isBelowMinimum,
   isInsufficientBalance,
   isPayFeesLoading,
+  isPaySystemSettling,
   blockingPayAlertMessage,
   outcomeTokenPrice,
   isSheetMode = false,
@@ -96,6 +98,7 @@ export const usePredictBuyError = ({
       !isPlacingOrder &&
       !isConfirming &&
       !isPredictBalanceSelected &&
+      !isPaySystemSettling &&
       !!blockingPayAlertMessage
     ) {
       return {
@@ -141,6 +144,7 @@ export const usePredictBuyError = ({
     isConfirming,
     preview,
     isPayFeesLoading,
+    isPaySystemSettling,
     isPredictBalanceSelected,
     blockingPayAlertMessage,
     activeOrder?.error,
@@ -194,7 +198,11 @@ export const usePredictBuyError = ({
       const bannerWouldSuppress =
         isSheetMode &&
         activeOrder?.error &&
-        !(blockingPayAlertMessage && !isPredictBalanceSelected);
+        !(
+          blockingPayAlertMessage &&
+          !isPredictBalanceSelected &&
+          !isPaySystemSettling
+        );
       if (bannerWouldSuppress) {
         return undefined;
       }
@@ -214,6 +222,7 @@ export const usePredictBuyError = ({
     activeOrder?.error,
     blockingPayAlertMessage,
     isPredictBalanceSelected,
+    isPaySystemSettling,
     isSheetMode,
   ]);
 
@@ -233,7 +242,11 @@ export const usePredictBuyError = ({
         return null;
       }
 
-      if (blockingPayAlertMessage && !isPredictBalanceSelected) {
+      if (
+        blockingPayAlertMessage &&
+        !isPredictBalanceSelected &&
+        !isPaySystemSettling
+      ) {
         return null;
       }
 
@@ -274,6 +287,7 @@ export const usePredictBuyError = ({
       isConfirming,
       blockingPayAlertMessage,
       isPredictBalanceSelected,
+      isPaySystemSettling,
       isSheetMode,
     ]);
 
@@ -298,7 +312,11 @@ export const usePredictBuyError = ({
     !isSheetMode ||
     isPlacingOrder ||
     isConfirming ||
-    Boolean(blockingPayAlertMessage && !isPredictBalanceSelected);
+    Boolean(
+      blockingPayAlertMessage &&
+        !isPredictBalanceSelected &&
+        !isPaySystemSettling,
+    );
 
   const buyErrorBanner =
     currentBuyErrorBanner ??