fix: Fix iOS build issue on Xcode 16.3 #15045

Cal-L · 2025-04-30T23:26:48Z

Description

Fix iOS build issues on Xcode 16.3 by bumping Sentry and Expo deps. RN sentry package is bumped a major version from v5 -> v6, which introduced some breaking changes under the hood. This also updates pods repo so a few other minor version bumps will exist in Podfile.lock as well.

Related issues

Fixes:

Manual testing steps

How it was tested: Both Android and iOS apps should run after running yarn start:ios or yarn start:android

Screenshots/Recordings

Before

Individuals began experiencing iOS build issues with Xcode 16.3 as reported here - https://consensys.slack.com/archives/C02U025CVU4/p1746041871082239. The fix was to bump Expo SDK deps as well as Sentry.

Expo SDK deps - https://expo.dev/changelog/xcode-16-3-patches
Sentry issue - https://github.com/getsentry/sentry-cocoa/releases/tag/8.46.0 (we bumped to stable 8.48.0 with pod repo update)

Sentry spans were not associated correctly in v5

After

Spans are now correctly associated with the parent span with v6

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-04-30T23:26:59Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2025-04-30T23:27:48Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Quality	Maintenance
	npm/@sentry/cli-darwin@2.36.6 ⏵ 2.42.4			⁺¹
	npm/@sentry/cli-linux-arm@2.36.6 ⏵ 2.42.4			⁺¹
	npm/@sentry/cli-linux-arm64@2.36.6 ⏵ 2.42.4			⁺¹
	npm/@sentry/cli-linux-i686@2.36.6 ⏵ 2.42.4			⁺¹
	npm/@sentry/cli-linux-x64@2.36.6 ⏵ 2.42.4			⁺¹
	npm/@sentry/cli-win32-i686@2.36.6 ⏵ 2.42.4			⁺¹
	npm/@sentry/cli-win32-x64@2.36.6 ⏵ 2.42.4			⁺¹
	npm/utrie@1.0.2
	npm/text-segmentation@1.0.3
	npm/@expo/osascript@2.1.5 ⏵ 2.2.4			⁺²
	npm/react-native-get-random-values@1.8.0 ⏵ 1.11.0	⁺¹	⁺¹
	npm/@sentry/types@6.3.1 ⏵ 8.54.0	⁺¹	^-1
	npm/css-line-break@2.1.0
	npm/@expo/prebuild-config@8.0.25 ⏵ 8.2.0	⁺¹	⁺¹	⁺¹
	npm/html2canvas@1.4.1
	npm/expo-dev-client@5.0.19 ⏵ 5.0.20			⁺¹
	npm/@sentry/utils@6.3.1 ⏵ 8.54.0	⁺¹	^-1
	npm/@sentry-internal/feedback@7.119.1 ⏵ 8.54.0	⁺¹	⁺²
	npm/@sentry-internal/browser-utils@8.54.0
	npm/@react-native-masked-view/masked-view@0.3.1 ⏵ 0.3.2
	npm/expo-keep-awake@14.0.2 ⏵ 14.0.3			⁺¹
See 19 more rows in the dashboard

View full report

github-actions · 2025-04-30T23:27:49Z

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 4cbc4fb
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/93cb54fa-0088-4401-968a-48e57fd2dbdc

Note

This comment will auto-update when build completes
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

socket-security · 2025-04-30T23:27:49Z

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

npm/[email protected]
npm/[email protected]
npm/[email protected]
npm/[email protected]
npm/[email protected]
npm/@sentry-internal/[email protected]
npm/@sentry-internal/[email protected]
npm/@expo/[email protected]
npm/@expo/[email protected]
npm/[email protected]
npm/[email protected]
npm/@react-native-masked-view/[email protected]
npm/@sentry-internal/[email protected]
npm/@sentry-internal/[email protected]
npm/@sentry/[email protected]
npm/@sentry/[email protected]
npm/@sentry/[email protected]
npm/@sentry/[email protected]
npm/@sentry/[email protected]
npm/[email protected]
npm/[email protected]
npm/[email protected]
npm/@sentry/[email protected]
npm/@sentry/[email protected]
npm/@sentry/[email protected]
npm/@sentry/[email protected]
npm/@sentry/[email protected]
npm/@sentry/[email protected]
npm/@sentry/[email protected]
npm/@sentry/[email protected]
npm/@sentry/[email protected]
npm/@sentry/[email protected]
npm/@shopify/[email protected]
npm/[email protected]
npm/[email protected]
npm/[email protected]
npm/[email protected]
npm/[email protected]
npm/@expo/[email protected]
npm/[email protected]
npm/[email protected]
npm/@expo/[email protected]
npm/@expo/[email protected]

View full report

chrisleewilcox

LGTM

chrisleewilcox

Nice!

owencraston

This fixed my iOS builds (using xcode 16.3)

This reverts commit 94f8c01.

This reverts commit 92a08a9.

Cal-L · 2025-05-02T06:38:49Z

Skipping sonar cloud since function was not changed on files complaining about coverage

github-actions · 2025-05-02T06:39:31Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: cb96adb
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/14b83cc2-2e73-4f30-a280-f099b7be3874

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sonarqubecloud · 2025-05-02T07:08:27Z

Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Changes have been addressed

Bump Sentry, expo lib deps

4cbc4fb

Cal-L requested a review from a team as a code owner April 30, 2025 23:26

Cal-L added the team-mobile-platform Mobile Platform team label Apr 30, 2025

Cal-L added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 30, 2025

github-project-automation bot added this to PR review queue Apr 30, 2025

Cal-L added the No QA Needed Apply this label when your PR does not need any QA effort. label Apr 30, 2025

github-project-automation bot moved this to Needs dev review in PR review queue Apr 30, 2025

Cal-L added no-changelog Indicates no external facing user changes, therefore no changelog documentation needed Run Smoke E2E Requires smoke E2E testing labels Apr 30, 2025

Cal-L changed the title ~~Fix: Fix iOS build issue on Xcode 16.3~~ fix: Fix iOS build issue on Xcode 16.3 Apr 30, 2025

chrisleewilcox previously approved these changes Apr 30, 2025

View reviewed changes

github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Apr 30, 2025

Fix dedupe

2134721

Cal-L dismissed chrisleewilcox’s stale review via 2134721 April 30, 2025 23:39

chrisleewilcox previously approved these changes Apr 30, 2025

View reviewed changes

tommasini previously approved these changes May 1, 2025

View reviewed changes

Fix Sentry types

71da8bb

Cal-L dismissed stale reviews from tommasini and chrisleewilcox via 71da8bb May 1, 2025 00:04

cortisiko previously approved these changes May 1, 2025

View reviewed changes

owencraston previously approved these changes May 1, 2025

View reviewed changes

Enforce better stack trace with captureException

d0e436e

Cal-L dismissed stale reviews from owencraston and cortisiko via d0e436e May 1, 2025 03:40

Cal-L requested a review from a team as a code owner May 1, 2025 03:40

Cal-L removed the Run Smoke E2E Requires smoke E2E testing label May 1, 2025

Cal-L added 7 commits May 1, 2025 21:52

Revert "Replace captureException with captureErrorException"

ec1c04d

This reverts commit 94f8c01.

Update podfile.lock

ad0ba0c

Add @sentry/react as dep

3a39984

Declare types for @sentry/react-native for captureException

b420fdd

Remove @sentry/react dep from package.json

92a08a9

Revert "Remove @sentry/react dep from package.json"

e86b8ae

This reverts commit 92a08a9.

Ignore @sentry/react for depcheck

cb96adb

Cal-L added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label May 2, 2025

Cal-L added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels May 2, 2025

Lock sentry versions to minor versions

2a9cb1b

metamaskbot added the bitrise-result-ready label May 2, 2025

github-actions bot removed the bitrise-result-ready label May 2, 2025

tommasini approved these changes May 2, 2025

View reviewed changes

OGPoyraz approved these changes May 2, 2025

View reviewed changes

github-project-automation bot moved this from Needs more work from the author to Review finalised - Ready to be merged in PR review queue May 2, 2025

Cal-L added this pull request to the merge queue May 2, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 2, 2025

owencraston approved these changes May 2, 2025

View reviewed changes

owencraston added this pull request to the merge queue May 2, 2025

Merged via the queue into main with commit 419e0cb May 2, 2025
44 of 46 checks passed

owencraston deleted the fix/ios-build-xcode16.3 branch May 2, 2025 20:53

github-actions bot locked and limited conversation to collaborators May 2, 2025

github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 2, 2025

metamaskbot added the release-7.47.0 Issue or pull request that will be included in release 7.47.0 label May 2, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: Fix iOS build issue on Xcode 16.3 #15045

fix: Fix iOS build issue on Xcode 16.3 #15045

Uh oh!

Cal-L commented Apr 30, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Apr 30, 2025

Uh oh!

socket-security bot commented Apr 30, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Apr 30, 2025

Uh oh!

socket-security bot commented Apr 30, 2025 •

edited

Loading

Uh oh!

chrisleewilcox left a comment

Uh oh!

chrisleewilcox left a comment

Uh oh!

owencraston left a comment

Uh oh!

Cal-L commented May 2, 2025

Uh oh!

github-actions bot commented May 2, 2025 •

edited by metamaskbot

Loading

Uh oh!

sonarqubecloud bot commented May 2, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fix: Fix iOS build issue on Xcode 16.3 #15045

fix: Fix iOS build issue on Xcode 16.3 #15045

Uh oh!

Conversation

Cal-L commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Apr 30, 2025

Uh oh!

socket-security bot commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 30, 2025

Bitrise

Uh oh!

socket-security bot commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chrisleewilcox left a comment

Choose a reason for hiding this comment

Uh oh!

chrisleewilcox left a comment

Choose a reason for hiding this comment

Uh oh!

owencraston left a comment

Choose a reason for hiding this comment

Uh oh!

Cal-L commented May 2, 2025

Uh oh!

github-actions bot commented May 2, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

sonarqubecloud bot commented May 2, 2025

Quality Gate failed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Cal-L commented Apr 30, 2025 •

edited

Loading

socket-security bot commented Apr 30, 2025 •

edited

Loading

socket-security bot commented Apr 30, 2025 •

edited

Loading

github-actions bot commented May 2, 2025 •

edited by metamaskbot

Loading