fix: Fix iOS build issue on Xcode 16.3 #15045

Cal-L · 2025-04-30T23:26:48Z

Description

Fix iOS build issues on Xcode 16.3 by bumping Sentry and Expo deps. This also updates pods repo so a few other minor version bumps will exist in Podfile.lock as well

Related issues

Fixes:

Manual testing steps

How it was tested: Both Android and iOS apps should run after running yarn start:ios or yarn start:android

Screenshots/Recordings

Before

Individuals began experiencing iOS build issues with Xcode 16.3 as reported here - https://consensys.slack.com/archives/C02U025CVU4/p1746041871082239. The fix was to bump Expo SDK deps as well as Sentry.

Expo SDK deps - https://expo.dev/changelog/xcode-16-3-patches
Sentry issue - https://github.com/getsentry/sentry-cocoa/releases/tag/8.46.0 (we bumped to stable 8.48.0 with pod repo update)

After

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-04-30T23:26:59Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2025-04-30T23:27:48Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Quality	Maintenance
	npm/@sentry/cli-win32-arm64@2.43.1
	npm/@sentry/cli-darwin@2.36.6 ⏵ 2.43.1			⁺¹
	npm/@sentry/cli-linux-arm@2.36.6 ⏵ 2.43.1			⁺¹
	npm/@sentry/cli-linux-arm64@2.36.6 ⏵ 2.43.1			⁺¹
	npm/@sentry/cli-linux-i686@2.36.6 ⏵ 2.43.1			⁺¹
	npm/@sentry/cli-linux-x64@2.36.6 ⏵ 2.43.1			⁺¹
	npm/@sentry/cli-win32-i686@2.36.6 ⏵ 2.43.1			⁺¹
	npm/@sentry/cli-win32-x64@2.36.6 ⏵ 2.43.1			⁺¹
	npm/utrie@1.0.2
	npm/text-segmentation@1.0.3
	npm/@expo/osascript@2.1.5 ⏵ 2.2.4			⁺²
	npm/react-native-get-random-values@1.8.0 ⏵ 1.11.0	⁺¹	⁺¹
	npm/@sentry/types@6.3.1 ⏵ 8.54.0	⁺¹	^-1	⁺¹
	npm/css-line-break@2.1.0
	npm/@expo/prebuild-config@8.0.25 ⏵ 8.2.0	⁺¹	⁺¹	⁺¹
	npm/html2canvas@1.4.1
	npm/expo-dev-client@5.0.19 ⏵ 5.0.20			⁺¹
	npm/@sentry/utils@6.3.1 ⏵ 8.54.0	⁺¹	^-1
	npm/@sentry-internal/feedback@7.119.1 ⏵ 8.54.0	⁺¹	⁺²
	npm/@sentry-internal/browser-utils@8.54.0
	npm/@react-native-masked-view/masked-view@0.3.1 ⏵ 0.3.2
	npm/expo-keep-awake@14.0.2 ⏵ 14.0.3			⁺¹
See 19 more rows in the dashboard

View full report

github-actions · 2025-04-30T23:27:49Z

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 4cbc4fb
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/93cb54fa-0088-4401-968a-48e57fd2dbdc

Note

This comment will auto-update when build completes
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

socket-security · 2025-04-30T23:27:49Z

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

npm/[email protected]
npm/[email protected]
npm/[email protected]
npm/[email protected]
npm/[email protected]
npm/@sentry-internal/[email protected]
npm/@sentry-internal/[email protected]
npm/@expo/[email protected]
npm/@sentry/[email protected]
npm/@expo/[email protected]
npm/[email protected]
npm/[email protected]
npm/@react-native-masked-view/[email protected]
npm/@sentry-internal/[email protected]
npm/@sentry-internal/[email protected]
npm/@sentry/[email protected]
npm/@sentry/[email protected]
npm/@sentry/[email protected]
npm/@sentry/[email protected]
npm/@sentry/[email protected]
npm/[email protected]
npm/[email protected]
npm/[email protected]
npm/@shopify/[email protected]
npm/[email protected]
npm/[email protected]
npm/[email protected]
npm/[email protected]
npm/@sentry/[email protected]
npm/[email protected]
npm/@expo/[email protected]
npm/[email protected]
npm/[email protected]
npm/@sentry/[email protected]
npm/@sentry/[email protected]
npm/@sentry/[email protected]
npm/@sentry/[email protected]
npm/@sentry/[email protected]
npm/@sentry/[email protected]
npm/@sentry/[email protected]
npm/@sentry/[email protected]
npm/@sentry/[email protected]
npm/@expo/[email protected]
npm/@expo/[email protected]

View full report

chrisleewilcox

LGTM

chrisleewilcox

Nice!

owencraston

This fixed my iOS builds (using xcode 16.3)

Cal-L · 2025-05-01T03:43:56Z

app/util/trace.ts

@@ -285,7 +285,7 @@ function startSpan<T>(
    op: op || OP_DEFAULT,
    // This needs to be parentSpan once we have the withIsolatedScope implementation in place in the Sentry SDK for React Native
    // Reference PR that updates @sentry/react-native: https://github.com/getsentry/sentry-react-native/pull/3895
-    parentSpanId: parentSpan?.spanId,
+    parentSpan,


Takes an entire span now

Do you know where this change is documented? I'm having a bit of trouble following.

I see something about Span mentioned here: https://docs.sentry.io/platforms/javascript/migration/v7-to-v8/#removal-of-span-class-export-from-sdk-packages

Oh I see, the removed the Span class from exports, but they are still exporting the type.

I found a dedicated page about the trace API changes. There is a section about how to set a parent span: https://docs.sentry.io/platforms/javascript/migration/v7-to-v8/v8-new-performance-api/#creating-a-child-span-of-a-specific-span

They suggest a different method (Sentry.withActiveSpan). It's unclear how this differs from setting the parentSpan option 🤔.

Not sure why this option wasn't referenced in the migration docs, but I found it elsewhere in their docs here: https://docs.sentry.io/platforms/javascript/tracing/instrumentation/#starting-spans-as-children-of-a-specific-span

This suggests what we're doing here is correct, no need to use withActiveSpan

Cal-L · 2025-05-01T03:44:28Z

app/util/trace.ts

@@ -373,11 +373,3 @@ function tryCatchMaybePromise<T>(

  return undefined;
 }
-
-function sentrySetMeasurement(


Don't need util. Can just call setMeasurement directly

Cal-L · 2025-05-01T03:45:43Z

patches/@sentry+core+8.54.0.patch

+ * Patch to enforce better stack tracing using Error - https://docs.sentry.io/platforms/javascript/usage/#capturing-errors
+  */
+-export declare function captureException(exception: unknown, hint?: ExclusiveEventHintOrCaptureContext): string;
+export declare function captureException(exception: Error, hint?: ExclusiveEventHintOrCaptureContext): string;


Ensure better stack trace with Error

Agreed that we should be passing errors to captureException, but why do we need this patch?

If we really want this type checked more strictly, we can define our own captureException that calls Sentry's. Typically we avoid patches except as a last resort, as they make updates significantly more difficult.

Cal-L · 2025-05-01T03:48:51Z

@SocketSecurity ignore-all

github-actions · 2025-05-01T04:37:17Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4689ee5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c10e1308-2eb9-4518-bf96-e63c3c1f4f1a

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

OGPoyraz

Confirmation changes LGTM

package.json

Gudahtt · 2025-05-01T14:16:36Z

package.json

@@ -254,7 +254,7 @@
    "@reown/walletkit": "^1.2.3",
    "@segment/sovran-react-native": "^1.0.4",
    "@sentry/integrations": "6.3.1",
-    "@sentry/react-native": "^5.33.0",
+    "@sentry/react-native": "~6.10.0",


Why limit the range just to this minor version? Is there a breaking change in version 6.11?

This specific version was auto updated using Expo CLI via npx expo install --fix. It's part of Expo's workflow for version validation. My guess is that they have a manifest somewhere that keeps track of this. This was just their suggested version but I don't see why we need to limit to the minor version as well. I can update this in a bit

Gudahtt · 2025-05-01T14:29:52Z

package.json

@@ -254,7 +254,7 @@
    "@reown/walletkit": "^1.2.3",
    "@segment/sovran-react-native": "^1.0.4",
    "@sentry/integrations": "6.3.1",
-    "@sentry/react-native": "^5.33.0",
+    "@sentry/react-native": "~6.10.0",


This breaking change made in v6 seems to impact us: https://docs.sentry.io/platforms/react-native/migration/v5-to-v6/#updated-behavior-of-tracepropagationtargets-in-react-native

Effectively it means tracing headers are now added on all network requests made outside of the webview, whereas previously they were not. We may want to explicitly set tracePropagationTargets to the v5 default value to avoid any unintended changes here

Gudahtt · 2025-05-01T14:42:54Z

package.json

@@ -427,7 +427,7 @@
    "@open-rpc/test-coverage": "^2.2.2",
    "@react-native/metro-config": "0.76.9",
    "@rpii/wdio-html-reporter": "^7.7.1",
-    "@sentry/types": "^7.117.0",
+    "@sentry/core": "8.54.0",


The update to v8 includes some breaking changes that haven't been dealt with yet. I'm surprised it isn't throwing an error 🤔

See here: https://docs.sentry.io/platforms/javascript/migration/v7-to-v8/#removal-of-class-based-integrations
We're still using two class-based integrations

Looks like the integrations aren't throwing an error because we're importing them from the integrations package, not from core. And the integrations package was not updated in this PR.

Still seems advisable to update it though, at least according to the migration doc. It's unclear whether there are any consequences to using outdated integrations.

Gudahtt

Seems like some breaking changes are not yet handled

Gudahtt · 2025-05-01T16:47:02Z

app/util/trace.ts

    // This needs to be parentSpan once we have the withIsolatedScope implementation in place in the Sentry SDK for React Native
    // Reference PR that updates @sentry/react-native: https://github.com/getsentry/sentry-react-native/pull/3895


This comment is now obsolete

Suggested change

// This needs to be parentSpan once we have the withIsolatedScope implementation in place in the Sentry SDK for React Native

// Reference PR that updates @sentry/react-native: https://github.com/getsentry/sentry-react-native/pull/3895

…s from @sentry/browser

…os-build-xcode16.3

sonarqubecloud · 2025-05-01T21:37:43Z

Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

This reverts commit 94f8c01.

Bump Sentry, expo lib deps

4cbc4fb

Cal-L requested a review from a team as a code owner April 30, 2025 23:26

Cal-L added the team-mobile-platform Mobile Platform team label Apr 30, 2025

Cal-L added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 30, 2025

github-project-automation bot added this to PR review queue Apr 30, 2025

Cal-L added the No QA Needed Apply this label when your PR does not need any QA effort. label Apr 30, 2025

github-project-automation bot moved this to Needs dev review in PR review queue Apr 30, 2025

Cal-L added no-changelog Indicates no external facing user changes, therefore no changelog documentation needed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 30, 2025

Cal-L changed the title ~~Fix: Fix iOS build issue on Xcode 16.3~~ fix: Fix iOS build issue on Xcode 16.3 Apr 30, 2025

chrisleewilcox previously approved these changes Apr 30, 2025

View reviewed changes

github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Apr 30, 2025

Fix dedupe

2134721

Cal-L dismissed chrisleewilcox’s stale review via 2134721 April 30, 2025 23:39

chrisleewilcox previously approved these changes Apr 30, 2025

View reviewed changes

tommasini previously approved these changes May 1, 2025

View reviewed changes

Fix Sentry types

71da8bb

Cal-L dismissed stale reviews from tommasini and chrisleewilcox via 71da8bb May 1, 2025 00:04

cortisiko previously approved these changes May 1, 2025

View reviewed changes

owencraston previously approved these changes May 1, 2025

View reviewed changes

Enforce better stack trace with captureException

d0e436e

Cal-L dismissed stale reviews from owencraston and cortisiko via d0e436e May 1, 2025 03:40

Cal-L requested a review from a team as a code owner May 1, 2025 03:40

Cal-L removed the Run Smoke E2E Triggers smoke e2e on Bitrise label May 1, 2025

Cal-L commented May 1, 2025

View reviewed changes

Cal-L added 2 commits April 30, 2025 21:00

Fix dep check

f952bd6

Pass errors to capture exception

4689ee5

Cal-L added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 1, 2025

Cal-L enabled auto-merge May 1, 2025 04:51

OGPoyraz previously approved these changes May 1, 2025

View reviewed changes

tommasini previously approved these changes May 1, 2025

View reviewed changes

Gudahtt reviewed May 1, 2025

View reviewed changes

package.json Outdated Show resolved Hide resolved

Gudahtt reviewed May 1, 2025

View reviewed changes

Gudahtt requested changes May 1, 2025

View reviewed changes

github-project-automation bot moved this from Review finalised - Ready to be merged to Needs more work from the author in PR review queue May 1, 2025

Gudahtt reviewed May 1, 2025

View reviewed changes

Replace withScope with withIsolationScope

eb5036c

Cal-L dismissed stale reviews from tommasini and OGPoyraz via eb5036c May 1, 2025 20:46

Cal-L added 3 commits May 1, 2025 14:24

Use v5 tracePropogationTargets and replace integrations with function…

5d09c13

…s from @sentry/browser

Update @sentry/react-native version and add core + browser

51819d2

Merge branch 'main' of github.com:MetaMask/metamask-mobile into fix/i…

3dcedde

…os-build-xcode16.3

Cal-L added 4 commits May 1, 2025 16:57

Replace captureException with captureErrorException

94f8c01

Remove Sentry patch

86c8524

Revert "Replace captureException with captureErrorException"

ec1c04d

This reverts commit 94f8c01.

Update podfile.lock

ad0ba0c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Fix iOS build issue on Xcode 16.3 #15045

fix: Fix iOS build issue on Xcode 16.3 #15045

Cal-L commented Apr 30, 2025 •

edited

Loading

github-actions bot commented Apr 30, 2025

socket-security bot commented Apr 30, 2025 •

edited

Loading

github-actions bot commented Apr 30, 2025

socket-security bot commented Apr 30, 2025 •

edited

Loading

chrisleewilcox left a comment

chrisleewilcox left a comment

owencraston left a comment

Cal-L May 1, 2025 •

edited

Loading

Gudahtt May 1, 2025

Gudahtt May 1, 2025

Gudahtt May 1, 2025

Cal-L May 1, 2025

Cal-L May 1, 2025

Gudahtt May 1, 2025

Cal-L commented May 1, 2025

github-actions bot commented May 1, 2025 •

edited by metamaskbot

Loading

OGPoyraz left a comment

Gudahtt May 1, 2025

Cal-L May 1, 2025 •

edited

Loading

Gudahtt May 1, 2025

Gudahtt May 1, 2025

Gudahtt May 1, 2025

Gudahtt left a comment

Gudahtt May 1, 2025

sonarqubecloud bot commented May 1, 2025

		// This needs to be parentSpan once we have the withIsolatedScope implementation in place in the Sentry SDK for React Native
		// Reference PR that updates @sentry/react-native: https://github.com/getsentry/sentry-react-native/pull/3895

fix: Fix iOS build issue on Xcode 16.3 #15045

Are you sure you want to change the base?

fix: Fix iOS build issue on Xcode 16.3 #15045

Conversation

Cal-L commented Apr 30, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Apr 30, 2025

socket-security bot commented Apr 30, 2025 • edited Loading

github-actions bot commented Apr 30, 2025

Bitrise

socket-security bot commented Apr 30, 2025 • edited Loading

chrisleewilcox left a comment

Choose a reason for hiding this comment

chrisleewilcox left a comment

Choose a reason for hiding this comment

owencraston left a comment

Choose a reason for hiding this comment

Cal-L May 1, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Cal-L commented May 1, 2025

github-actions bot commented May 1, 2025 • edited by metamaskbot Loading

Bitrise

OGPoyraz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Cal-L May 1, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Gudahtt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented May 1, 2025

Quality Gate failed

Cal-L commented Apr 30, 2025 •

edited

Loading

socket-security bot commented Apr 30, 2025 •

edited

Loading

socket-security bot commented Apr 30, 2025 •

edited

Loading

Cal-L May 1, 2025 •

edited

Loading

github-actions bot commented May 1, 2025 •

edited by metamaskbot

Loading

Cal-L May 1, 2025 •

edited

Loading