test: fix perf login tests

[cortisiko]

Description

Updates the LoginScreen WDIO page object to use Appwright getElementByID for the login container when running with a device, aligning element lookup with test IDs.

Refines password field lookup in getPasswordInputElement by switching Android to the more flexible getElementByCatchAll and removing the iOS-specific fallback to a generic textfield, instead targeting LoginViewSelectors.PASSWORD_INPUT directly.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Low Risk
Low risk test-only change that updates element lookup strategies; main risk is flaky or broken login E2E tests if the new IDs/catch-all matching don’t resolve consistently across platforms.

Overview
Updates the WDIO LoginScreen page object to use Appwright getElementByID for the login container when a device is present, instead of using the resource-id based lookup.

Refines getPasswordInputElement to use getElementByCatchAll on Android and removes the iOS fallback to a generic textfield, consistently targeting LoginViewSelectors.PASSWORD_INPUT via Appwright.

^{Written by Cursor Bugbot for commit 7681d1d. This will update automatically on new commits. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: None (no tests recommended)
• Selected Performance tags: None (no tests recommended)
• Risk Level: low
• AI Confidence: 97%

click to see 🤖 AI reasoning details

E2E Test Selection:
The only changed file is wdio/screen-objects/LoginScreen.js, which belongs to the WebdriverIO (wdio) test framework — a completely separate test framework from Detox. The change is a minor refactor of selector logic: simplifying the loginScreen getter to use getElementByID instead of getElementByResourceId, and updating the passwordInput getter to use getElementByCatchAll for Android while unifying the iOS path. No Detox test files import this file, and no app source code was modified. Per the explicit guidance, changes to the wdio/ directory do not require Detox E2E tags unless app code is also changed — which it is not here.

Performance Test Selection:
No app source code was changed. The modification is purely within the wdio test framework's screen object selectors, which has no impact on app rendering, data loading, or any performance-sensitive code paths.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[chloeYue]

LGTM, thanks for the fix !