Skip to content

test: fix perf login tests #27835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cortisiko merged 4 commits into from
Mar 24, 2026
Merged

test: fix perf login tests #27835

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e562e8
test: fix perf login tests
cortisiko Mar 23, 2026
c0c2b8e
fix unified framework locators as well
cortisiko Mar 23, 2026
388053c
address cursor comment
cortisiko Mar 23, 2026
7681d1d
address cursor
cortisiko Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions wdio/screen-objects/LoginScreen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,11 @@ class LoginScreen {
get loginScreen() {
if (!this._device) {
return Selectors.getXpathElementByResourceId(LoginViewSelectors.CONTAINER);
} else {
return AppwrightSelectors.getElementByResourceId(this._device, LoginViewSelectors.CONTAINER);
}
return AppwrightSelectors.getElementByID(
this._device,
LoginViewSelectors.CONTAINER,
);
}

get welcomeBackText() {
Expand Down Expand Up @@ -52,16 +54,17 @@ class LoginScreen {
return Selectors.getXpathElementByResourceId(
LoginViewSelectors.PASSWORD_INPUT,
);
} else {
if (AppwrightSelectors.isAndroid(this._device)) {
return AppwrightSelectors.getElementByID(
this._device,
LoginViewSelectors.PASSWORD_INPUT,
);
} else {
return AppwrightSelectors.getElementByID(this._device, "textfield", true);
}
}
if (AppwrightSelectors.isAndroid(this._device)) {
return AppwrightSelectors.getElementByCatchAll(
this._device,
LoginViewSelectors.PASSWORD_INPUT,
);
}
return AppwrightSelectors.getElementByID(
this._device,
LoginViewSelectors.PASSWORD_INPUT,
);
}

// Migrated to LoginView.ts (tests/page-objects/wallet/LoginView.ts)
Expand Down
Loading