Skip to content

chore: add engagement codeowners#30165

Open
samir-acle wants to merge 1 commit into
mainfrom
GE-217-pre-prompt-for-push-notifications-engagement-codeowners
Open

chore: add engagement codeowners#30165
samir-acle wants to merge 1 commit into
mainfrom
GE-217-pre-prompt-for-push-notifications-engagement-codeowners

Conversation

@samir-acle
Copy link
Copy Markdown
Contributor

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@samir-acle samir-acle requested a review from a team as a code owner May 14, 2026 01:27
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@samir-acle samir-acle enabled auto-merge May 14, 2026 01:34
@samir-acle samir-acle added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label May 14, 2026
@samir-acle samir-acle force-pushed the GE-217-pre-prompt-for-push-notifications-engagement-codeowners branch from 3683118 to b2ec0ee Compare May 15, 2026 14:38
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed size-XS team-engagement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant