Skip to content

chore: add engagement codeowners#30165

Merged
samir-acle merged 2 commits into
mainfrom
GE-217-pre-prompt-for-push-notifications-engagement-codeowners
May 19, 2026
Merged

chore: add engagement codeowners#30165
samir-acle merged 2 commits into
mainfrom
GE-217-pre-prompt-for-push-notifications-engagement-codeowners

Conversation

@samir-acle

@samir-acle samir-acle commented May 14, 2026

Copy link
Copy Markdown
Contributor

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@samir-acle samir-acle requested a review from a team as a code owner May 14, 2026 01:27
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@samir-acle samir-acle enabled auto-merge May 14, 2026 01:34
@samir-acle samir-acle added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label May 14, 2026
@samir-acle samir-acle force-pushed the GE-217-pre-prompt-for-push-notifications-engagement-codeowners branch from 3683118 to b2ec0ee Compare May 15, 2026 14:38
@sonarqubecloud

Copy link
Copy Markdown

@samir-acle samir-acle added this pull request to the merge queue May 19, 2026
Merged via the queue into main with commit bd61a69 May 19, 2026
78 checks passed
@samir-acle samir-acle deleted the GE-217-pre-prompt-for-push-notifications-engagement-codeowners branch May 19, 2026 10:39
@github-actions github-actions Bot locked and limited conversation to collaborators May 19, 2026
@metamaskbot metamaskbot added the release-7.79.0 Issue or pull request that will be included in release 7.79.0 label Jun 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.79.0 Issue or pull request that will be included in release 7.79.0 size-XS team-engagement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants