Skip to content

Fix spelling errors in Documentation #13677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+1 −1
Open

Fix spelling errors in Documentation #13677

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8892b22
fix typos README.md
torrpriius Feb 22, 2025
b9df5f1
fix typo README.md
torrpriius Feb 22, 2025
2b93d1c
Merge branch 'main' into fix/fix
torrpriius Mar 3, 2025
78fd09f
Merge branch 'main' into fix/fix
torrpriius Mar 19, 2025
4003dd6
Merge branch 'main' into fix/fix
torrpriius Apr 9, 2025
f9555a7
Merge branch 'main' into fix/fix
torrpriius Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/confirmation-refactoring/dapp-transaction/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ This is covered already in document for refactoring Approve flow [here](https://

### Other Code Improvements:

Most of these points are covered in previous documents, but addding these here also as these are application to DAPP transaction related components also:
Most of these points are covered in previous documents, but adding these here also as these are application to DAPP transaction related components also:

1. Code to start / stop gas polling is duplicated at couple of places and should be moved to a re-usable hook.
2. As detailed in refactoring send flow document, a lot of components have logic to `updateNavBar` as [here](https://github.com/MetaMask/metamask-mobile/blob/e3f89a49a672b7c74419b4c6c9fc34a3ae9be023/app/components/Views/Approval/index.js#L121). This can be refactored out into a reusable hook.
Expand Down